linux-mm.kvack.org archive mirror
 help / color / mirror / Atom feed
From: Rik van Riel <riel@conectiva.com.br>
To: "David S. Miller" <davem@redhat.com>
Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, torvalds@transmeta.com
Subject: Re: [PATCH *] VM patch for 2.4.0-test8
Date: Thu, 14 Sep 2000 13:53:33 -0300 (BRST)	[thread overview]
Message-ID: <Pine.LNX.4.21.0009141351510.10822-100000@duckman.distro.conectiva> (raw)
In-Reply-To: <200009140525.WAA21446@pizda.ninka.net>

On Wed, 13 Sep 2000, David S. Miller wrote:

> In page_launder() about halfway down there is this sequence of tests
> on LRU pages:
> 
> if (!clearedbuf) {
>  ...
> } else if (!page->mapping) {
>  ...
> } else if (page_count(page) > 1) {
> } else /* page->mapping && page_count(page) == 1 */ {
>  ...
> }
> 
> Above this sequence we've done a page_cache_get.

Indeed, you're right. This bug certainly explains some
of the performance things I've seen in the stress test
last night...

Btw, in case you're wondering ... the box /survived/
a stress test that would get programs killed on quite
a few "stable" kernels we've been shipping lately. ;)

regards,

Rik
--
"What you're running that piece of shit Gnome?!?!"
       -- Miguel de Icaza, UKUUG 2000

http://www.conectiva.com/		http://www.surriel.com/

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux.eu.org/Linux-MM/

  parent reply	other threads:[~2000-09-14 16:53 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2000-09-14  4:30 Rik van Riel
2000-09-14  5:25 ` David S. Miller
2000-09-14  6:11   ` Juan J. Quintela
2000-09-14  8:18     ` David S. Miller
2000-09-14 16:53   ` Rik van Riel [this message]
2000-09-14 17:49     ` Rik van Riel
2000-09-15 17:28     ` Martin Josefsson
2000-09-15 19:37       ` Jamie Lokier
2000-09-15 21:07         ` David Ford
2000-09-15 22:04         ` Rik van Riel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Pine.LNX.4.21.0009141351510.10822-100000@duckman.distro.conectiva \
    --to=riel@conectiva.com.br \
    --cc=davem@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=torvalds@transmeta.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox