linux-mm.kvack.org archive mirror
 help / color / mirror / Atom feed
From: Andrea Arcangeli <andrea@suse.de>
To: "David S. Miller" <davem@redhat.com>
Cc: sct@redhat.com, torvalds@transmeta.com, linux-mm@kvack.org
Subject: Re: 2.3.x swap cache seems to be a big leak
Date: Sat, 3 Jun 2000 14:32:19 -0700 (PDT)	[thread overview]
Message-ID: <Pine.LNX.4.21.0006031428010.7928-100000@inspiron.random> (raw)
In-Reply-To: <200004251203.FAA04709@pizda.ninka.net>

On Tue, 25 Apr 2000, David S. Miller wrote:

>__delete_from_swap_cache depends upon remove_inode_page doing
>a put_page or similar to kill the reference of the swap cache
>itself

__delete_from_swap_cache must not decrease the reference count.

>We changed remove_inode_page during the page cache rewrite such
>that is no longer puts the page, the caller does.

shrink_mmap does in the made_inode_progress path (first release the swap
cache reference and then frees the page by issuing two put_page).

>So if I haven't missed something clever going on here, this would
>explain a lot of problems people have reported with swapping making
>their machines act weird and eventually run out of ram.

That's because the MM balancing is broken. Try to reproduce with the
classzone patch applied.

Andrea

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux.eu.org/Linux-MM/

      reply	other threads:[~2000-06-03 21:32 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2000-04-25 12:03 David S. Miller
2000-06-03 21:32 ` Andrea Arcangeli [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Pine.LNX.4.21.0006031428010.7928-100000@inspiron.random \
    --to=andrea@suse.de \
    --cc=davem@redhat.com \
    --cc=linux-mm@kvack.org \
    --cc=sct@redhat.com \
    --cc=torvalds@transmeta.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox