From: Andrea Arcangeli <andrea@suse.de>
To: "Jones D (ISaCS)" <djones2@glam.ac.uk>
Cc: 'Rik van Riel' <riel@conectiva.com.br>,
Simon Kirby <sim@stormix.com>,
Linus Torvalds <torvalds@transmeta.com>,
linux-mm@kvack.org, linux-kernel@vger.rutgers.edu
Subject: RE: [PATCH] Recent VM fiasco - fixed
Date: Fri, 12 May 2000 09:50:54 +0200 (CEST) [thread overview]
Message-ID: <Pine.LNX.4.21.0005112053430.1652-100000@inspiron> (raw)
In-Reply-To: <B83C33A4F7B6D311A3CA00805F85FBB863C59E@ems2.glam.ac.uk>
On Thu, 11 May 2000, Jones D (ISaCS) wrote:
>As I've been playing with invalidate_inode_pages for the last few
>days, this section of Andrea's classzone diff caught my eye.
>
>I noticed that in Andrea's version, if a page is locked, then it is just
>ignored, and never freed. He reduced the complexity of the function, and
Note that the official kernel clearly ignores it too so I'm not
reinserting any bug there but only avoiding dropping performance for no
good reason and that's why I intentionally backed out such a recent
change.
To avoiding ignoring it you should wait_on_page() (you have no other way)
and according to Trond we can't do that because the caller doesn't handle
a blocking function.
Your patch ignores locked pages too from within
invalidate_inode_pages() as far I can tell.
Andrea
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux.eu.org/Linux-MM/
next prev parent reply other threads:[~2000-05-12 7:50 UTC|newest]
Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top
2000-05-11 11:26 Jones D (ISaCS)
2000-05-12 7:50 ` Andrea Arcangeli [this message]
-- strict thread matches above, loose matches on Subject: below --
2000-05-08 17:21 Zlatko Calusic
2000-05-08 17:43 ` Rik van Riel
2000-05-08 18:16 ` Zlatko Calusic
2000-05-08 18:20 ` Linus Torvalds
2000-05-08 18:46 ` Rik van Riel
2000-05-08 18:53 ` Zlatko Calusic
2000-05-08 19:04 ` Rik van Riel
2000-05-09 7:56 ` Daniel Stone
2000-05-09 8:25 ` Christoph Rohland
2000-05-09 15:44 ` Linus Torvalds
2000-05-09 16:12 ` Simon Kirby
2000-05-09 17:42 ` Christoph Rohland
2000-05-09 19:50 ` Linus Torvalds
2000-05-10 11:25 ` Christoph Rohland
2000-05-10 11:50 ` Zlatko Calusic
2000-05-11 23:40 ` Mark Hahn
2000-05-10 4:05 ` James H. Cloos Jr.
2000-05-10 7:29 ` James H. Cloos Jr.
2000-05-11 0:16 ` Linus Torvalds
2000-05-11 0:32 ` Linus Torvalds
2000-05-11 1:04 ` Juan J. Quintela
2000-05-11 1:53 ` Simon Kirby
2000-05-11 7:23 ` Linus Torvalds
2000-05-11 14:17 ` Simon Kirby
2000-05-11 23:38 ` Simon Kirby
2000-05-12 0:09 ` Linus Torvalds
2000-05-11 11:15 ` Rik van Riel
2000-05-11 5:10 ` Linus Torvalds
2000-05-11 10:09 ` James H. Cloos Jr.
2000-05-11 17:25 ` Juan J. Quintela
2000-05-11 11:12 ` Christoph Rohland
2000-05-11 17:38 ` Steve Dodd
2000-05-09 10:21 ` Rik van Riel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Pine.LNX.4.21.0005112053430.1652-100000@inspiron \
--to=andrea@suse.de \
--cc=djones2@glam.ac.uk \
--cc=linux-kernel@vger.rutgers.edu \
--cc=linux-mm@kvack.org \
--cc=riel@conectiva.com.br \
--cc=sim@stormix.com \
--cc=torvalds@transmeta.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox