From: Rik van Riel <riel@conectiva.com.br>
To: Roger Larsson <roger.larsson@norran.net>
Cc: Arjan van de Ven <arjan@fenrus.demon.nl>, linux-mm@kvack.org
Subject: Re: [patch] active/inactive queues for pre7-4
Date: Tue, 9 May 2000 20:11:57 -0300 (BRST) [thread overview]
Message-ID: <Pine.LNX.4.21.0005092009330.25637-100000@duckman.conectiva> (raw)
In-Reply-To: <3918B66D.C7B7C777@norran.net>
On Wed, 10 May 2000, Roger Larsson wrote:
> I think I found one bug in __page_reactivate
>
> > --- linux-2.3.99-pre7-4/mm/filemap.c.orig Thu May 4 11:38:24 2000
> > +++ linux-2.3.99-pre7-4/mm/filemap.c Tue May 9 12:09:42 2000
> > + pgdat->active_pages++;
> > + pgdat->active_pages++;
>
> pgdat->active_pages is incremented twice!
> second one should IMHO be
> zone->active_pages
Indeed. In the meantime I found another small bug (the return
value from refill_inactivate() doesn't make much sense) and
have fixed a few other minor bugs.
If we continue like this the active/inactive page scheme should
be working soon ;)
Rik
--
The Internet is not a network of computers. It is a network
of people. That is its real strength.
Wanna talk about the kernel? irc.openprojects.net / #kernelnewbies
http://www.conectiva.com/ http://www.surriel.com/
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux.eu.org/Linux-MM/
prev parent reply other threads:[~2000-05-09 23:11 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2000-05-09 15:27 Rik van Riel
2000-05-10 1:07 ` Roger Larsson
2000-05-09 23:11 ` Rik van Riel [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Pine.LNX.4.21.0005092009330.25637-100000@duckman.conectiva \
--to=riel@conectiva.com.br \
--cc=arjan@fenrus.demon.nl \
--cc=linux-mm@kvack.org \
--cc=roger.larsson@norran.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox