Re: Bug in classzone patch?

Re: Bug in classzone patch?

[Andrea Arcangeli]

[ cc'ed to linux-mm to let know people I was wrong about pgdat_list not
  null terminated, sorry ]

On Sat, 6 May 2000, Benjamin Redelings I wrote:

>-	pgdat->node_next = pgdat_list;
>+	pgdat->node_next = NULL;
> 	pgdat_list = pgdat;
>
>Hi Andrea,
>	I don't understand this bit of your classzone patch.  You say that this
>changes makes pgdat_list NULL-terminated.
>	However, pgdat_list is ALREADY null terminated:
>
>telomere:/usr/src/linux/mm> grep 'pgdat_list' *c
>page_alloc.c:pg_data_t *pgdat_list = (pg_data_t *)0;

Ah, I see, you're right. Thanks. (btw there's no reason to initialize the
pgdat_list to zero since it's global and it could fit in the .bss)

>Am I missing something, or is this a bug in your classzone patch?

Yes, it's a bug in the classzone patch that can trigger only in NUMA. I'll
fix it thanks.

Andrea

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux.eu.org/Linux-MM/