From: Andrea Arcangeli <andrea@suse.de>
To: Benjamin Redelings I <bredelin@ucla.edu>
Cc: linux-mm@kvack.org
Subject: Re: Bug in classzone patch?
Date: Sun, 7 May 2000 15:27:42 +0200 (CEST) [thread overview]
Message-ID: <Pine.LNX.4.21.0005071521080.479-100000@alpha.random> (raw)
In-Reply-To: <391430AF.BC96942C@ucla.edu>
[ cc'ed to linux-mm to let know people I was wrong about pgdat_list not
null terminated, sorry ]
On Sat, 6 May 2000, Benjamin Redelings I wrote:
>- pgdat->node_next = pgdat_list;
>+ pgdat->node_next = NULL;
> pgdat_list = pgdat;
>
>Hi Andrea,
> I don't understand this bit of your classzone patch. You say that this
>changes makes pgdat_list NULL-terminated.
> However, pgdat_list is ALREADY null terminated:
>
>telomere:/usr/src/linux/mm> grep 'pgdat_list' *c
>page_alloc.c:pg_data_t *pgdat_list = (pg_data_t *)0;
Ah, I see, you're right. Thanks. (btw there's no reason to initialize the
pgdat_list to zero since it's global and it could fit in the .bss)
>Am I missing something, or is this a bug in your classzone patch?
Yes, it's a bug in the classzone patch that can trigger only in NUMA. I'll
fix it thanks.
Andrea
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux.eu.org/Linux-MM/
parent reply other threads:[~2000-05-07 13:27 UTC|newest]
Thread overview: expand[flat|nested] mbox.gz Atom feed
[parent not found: <391430AF.BC96942C@ucla.edu>]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Pine.LNX.4.21.0005071521080.479-100000@alpha.random \
--to=andrea@suse.de \
--cc=bredelin@ucla.edu \
--cc=linux-mm@kvack.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox