Re: [patch] shrink_mmap() 2.3.99-pre6-3 (take 3)

[Rik van Riel <riel@conectiva.com.br>]

On Thu, 20 Apr 2000, Andrea Arcangeli wrote:
> On Wed, 19 Apr 2000, Rik van Riel wrote:
> 
> >will be needed. It also doesn't eliminate a possible race
> >condition (afaik Ben is working on that one) in shrink_mmap().
> 
> Which shrink_mmap race condition?

Oh, you're right. I was worried about what would happen if we
looped back in the while() loop without the lock held, but now
I see that we grab the pagemap_lru_lock in unlock_continue...

I guess shrink_mmap() needs some comments. ;)

> >The patch does the following:
> >- remove possible race condition from truncate_inode_pages()
> 
> Which truncate_inode_pages race condition? Please provide a
> stack trace, it shouldn't take too time for you if you have the
> race condition in mind.

Stephen has already answered this question a number of
emails ago.

regards,

Rik
--
The Internet is not a network of computers. It is a network
of people. That is its real strength.

Wanna talk about the kernel?  irc.openprojects.net / #kernelnewbies
http://www.conectiva.com/		http://www.surriel.com/

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux.eu.org/Linux-MM/