Re: 2.3.32-pre4/SMP still doesn't boot on Compaq Proliant 1600

Re: 2.3.32-pre4/SMP still doesn't boot on Compaq Proliant 1600

[Benjamin C.R. LaHaise]

On Tue, 14 Dec 1999, Alexander Viro wrote:

> On Tue, 14 Dec 1999, Linus Torvalds wrote:
...
> > Sounds like a capital idea. Mind doing the block device pagecache first,
> > though, if you're already looking at this area?
> 
> Frankly, I'ld rather start with massaging bmap() out of existence. I will
> do block device pagecache, all right, but there is one funny detail - we
> have serious code duplication between loopback and swap.

Ah, I see what you're talking about.  In theory we make rw_swap_page use
the page cache operations of the filesystem (or block device) by simply
relabelling the page from its swap cache entry.  Actually, if we use the
page cache for block device access, doesn't that mean that we can get rid
of the swapper_inode completely?  This seems like an obvious way of doing
things, and unless people point out something that I'm missing entirely
here...  It'll mean that brw_page goes away and is replaced by the use of
i_ops->readpage.  That's seems good =)

		-ben

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://humbolt.geo.uu.nl/Linux-MM/

Re: 2.3.32-pre4/SMP still doesn't boot on Compaq Proliant 1600

[Andrea Arcangeli]

On Tue, 14 Dec 1999, Benjamin C.R. LaHaise wrote:

>Ah, I see what you're talking about.  In theory we make rw_swap_page use
>the page cache operations of the filesystem (or block device) by simply
>relabelling the page from its swap cache entry.  Actually, if we use the
>page cache for block device access, doesn't that mean that we can get rid
>of the swapper_inode completely?  This seems like an obvious way of doing

The swapper_inode only say "I am a swap cache page". Also the
PG_swap_cache bitflag say the same. So we could remove the swapper inode 
even now but that's not a maojor issue.

The swapper inode only deals with the swap cache and the swap cache is not
the right place where to allocate the loop cache.

Andrea

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.nl.linux.org/Linux-MM/