From: Andrea Arcangeli <andrea@suse.de>
To: Steven Hand <Steven.Hand@cl.cam.ac.uk>
Cc: linux-MM@kvack.org
Subject: Re: Asynchronous I/O
Date: Fri, 10 Sep 1999 19:35:18 +0200 (CEST) [thread overview]
Message-ID: <Pine.LNX.4.10.9909101924330.16780-100000@laser.random> (raw)
In-Reply-To: <E11P7JJ-0005Fd-00@heaton.cl.cam.ac.uk>
On Thu, 9 Sep 1999, Steven Hand wrote:
> b) should it work?
Your plain suggestion is not ok becaue you end freeing the page two times,
one in filemap_write_page and one in kpiod so you'll also remove the page
from the page cache if you avoided MS_INVALIDED and you'll corrupt memory
with MS_INVALIDATE. So you should do something like:
error = filemap_write_page(vma, address - vma->vm_start +
vma->vm_offset, page, !(flags & MS_ASYNC));
if (!(flags & MS_ASYNC))
page_cache_free(page);
Andrea
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://humbolt.geo.uu.nl/Linux-MM/
prev parent reply other threads:[~1999-09-10 17:35 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
1999-09-09 16:46 Steven Hand
1999-09-10 17:35 ` Andrea Arcangeli [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Pine.LNX.4.10.9909101924330.16780-100000@laser.random \
--to=andrea@suse.de \
--cc=Steven.Hand@cl.cam.ac.uk \
--cc=linux-MM@kvack.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox