From: Andrea Arcangeli <andrea@suse.de>
To: Linus Torvalds <torvalds@transmeta.com>
Cc: linux-kernel@vger.rutgers.edu, linux-mm@kvack.org
Subject: [patch] rw_swap_page_nocache dead
Date: Wed, 18 Aug 1999 19:23:16 +0200 (CEST) [thread overview]
Message-ID: <Pine.LNX.4.10.9908181921520.16546-100000@laser.random> (raw)
rw_swap_page_nocache seems dead code to me. I can compile shm/swapfile.o
fine even without it.
diff -ur 2.3.14-pre1/include/linux/swap.h 2.3.14-pre1-page_io/include/linux/swap.h
--- 2.3.14-pre1/include/linux/swap.h Wed Aug 18 17:44:42 1999
+++ 2.3.14-pre1-page_io/include/linux/swap.h Wed Aug 18 19:13:07 1999
@@ -85,7 +85,6 @@
/* linux/mm/page_io.c */
extern void rw_swap_page(int, struct page *, int);
-extern void rw_swap_page_nocache(int, unsigned long, char *);
extern void rw_swap_page_nolock(int, unsigned long, char *, int);
extern void swap_after_unlock_page (unsigned long entry);
diff -ur 2.3.14-pre1/mm/page_io.c 2.3.14-pre1-page_io/mm/page_io.c
--- 2.3.14-pre1/mm/page_io.c Thu Aug 12 02:53:25 1999
+++ 2.3.14-pre1-page_io/mm/page_io.c Wed Aug 18 19:12:52 1999
@@ -170,24 +170,6 @@
}
/*
- * Setting up a new swap file needs a simple wrapper just to read the
- * swap signature. SysV shared memory also needs a simple wrapper.
- */
-void rw_swap_page_nocache(int rw, unsigned long entry, char *buf)
-{
- struct page *page = mem_map + MAP_NR(buf);
-
- if (TryLockPage(page))
- PAGE_BUG(page);
- if (PageSwapCache(page))
- PAGE_BUG(page);
- if (page->inode)
- PAGE_BUG(page);
- page->offset = entry;
- rw_swap_page_base(rw, entry, page, 1, 1);
-}
-
-/*
* shmfs needs a version that doesn't put the page in the page cache!
* The swap lock map insists that pages be in the page cache!
* Therefore we can't use it. Later when we can remove the need for the
Andrea
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://humbolt.geo.uu.nl/Linux-MM/
reply other threads:[~1999-08-18 17:23 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Pine.LNX.4.10.9908181921520.16546-100000@laser.random \
--to=andrea@suse.de \
--cc=linux-kernel@vger.rutgers.edu \
--cc=linux-mm@kvack.org \
--cc=torvalds@transmeta.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox