From: Linus Torvalds <torvalds@transmeta.com>
To: Kanoj Sarcar <kanoj@google.engr.sgi.com>
Cc: alan@lxorguk.ukuu.org.uk, linux-mm@kvack.org,
linux-kernel@vger.rutgers.edu
Subject: Re: [PATCH] Fix sys_mount not to free_page(0)
Date: Fri, 6 Aug 1999 17:00:58 -0700 (PDT) [thread overview]
Message-ID: <Pine.LNX.4.10.9908061658390.1889-100000@penguin.transmeta.com> (raw)
In-Reply-To: <199908062351.QAA42123@google.engr.sgi.com>
On Fri, 6 Aug 1999, Kanoj Sarcar wrote:
> >
> > free_page(0) is actually supposed to work. Doesn't it?
>
> Umm, it does ... I was thinking it was happenstance, and not by design.
It's by design - I am of the religion that thinks that
free(malloc());
is always legal, even when the malloc() fails.
> Is it worthwhile to clean this up, or do other places in the code rely
> on this behavior of free_page?
There might be any number of places who just free a page, it doesn't even
slow down free_page(), because the 0 case just falls out quite naturally
from having to test for out-of-range and reserved pages anyway.
Linus
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://humbolt.geo.uu.nl/Linux-MM/
prev parent reply other threads:[~1999-08-07 0:00 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
1999-08-06 23:12 Kanoj Sarcar
1999-08-06 23:18 ` Linus Torvalds
1999-08-06 23:51 ` Kanoj Sarcar
1999-08-07 0:00 ` Linus Torvalds [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Pine.LNX.4.10.9908061658390.1889-100000@penguin.transmeta.com \
--to=torvalds@transmeta.com \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=kanoj@google.engr.sgi.com \
--cc=linux-kernel@vger.rutgers.edu \
--cc=linux-mm@kvack.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox