From mboxrd@z Thu Jan 1 00:00:00 1970 Date: Thu, 8 Jul 1999 10:00:30 -0700 (PDT) From: Linus Torvalds Subject: Re: [RFT][PATCH] 2.3.10 pre5 SMP/vm fixes In-Reply-To: <199907080719.AAA00822@google.engr.sgi.com> Message-ID: MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: owner-linux-mm@kvack.org Return-Path: To: Kanoj Sarcar Cc: linux-mm@kvack.org, linux-kernel@vger.rutgers.edu List-ID: On Thu, 8 Jul 1999, Kanoj Sarcar wrote: > > ***************************************************************** > 3. In mm/memory.c, a new comment claims: > "The adding of pages is protected by the MM semaphore" > which is not quite correct, since swapoff does not hold this semaphore. The fix is to fix swapoff, not to change the comment. page_table_lock is _not_ going to be added to this path - I refuse to add locks to common cases just to protect against things that never run in practice. Linus -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://humbolt.geo.uu.nl/Linux-MM/