From: Mark Hahn <hahn@coffee.psychology.mcmaster.ca>
To: Rasmus Andersen <rasmus@jaquet.dk>
Cc: linux-mm@kvack.org
Subject: Re: [PATCH] guard mm->rss with page_table_lock (241p11)
Date: Tue, 30 Jan 2001 09:32:11 -0500 (EST) [thread overview]
Message-ID: <Pine.LNX.4.10.10101300929380.29461-100000@coffee.psychology.mcmaster.ca> (raw)
In-Reply-To: <20010130093159.A3298@jaquet.dk>
> > > + spin_lock(&mm->page_table_lock);
> > > mm->rss++;
> > > + spin_unlock(&mm->page_table_lock);
> > >...
> >
> > Would it not be better to use some sort of atomic add/subtract/clear operation
> > rather than a spinlock? (Which would also give you fewer atomic memory access
> > cycles).
>
> This will unfortunately not do for all platforms. Please read
> http://marc.theaimsgroup.com/?t=97630768100003&w=2&r=1 for the
> last discussion of this.
which can be summarized as "yet another way sparc support screws Linux,
and DMiller didn't want to fix his mess close to 2.4.0". it's ridiculous
for an inconsequential arch like sparc32 to cause fairly noticable problems
for all other arches.
if noone beats me, I'll be submitting a patch to fix this silliness in 2.5.
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux.eu.org/Linux-MM/
next prev parent reply other threads:[~2001-01-30 14:32 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2001-01-29 21:23 Rasmus Andersen
2001-01-29 21:30 ` Rik van Riel
2001-01-29 21:43 ` Rasmus Andersen
2001-01-29 21:47 ` Rik van Riel
2001-01-30 8:18 ` David Howells
2001-01-30 8:31 ` Rasmus Andersen
2001-01-30 14:32 ` Mark Hahn [this message]
2001-01-30 15:30 ` Eric W. Biederman
2001-01-30 8:39 ` David S. Miller
2001-01-30 11:17 ` Chris Wedgwood
2001-01-30 11:23 ` Rik van Riel
2001-01-30 11:38 ` Rasmus Andersen
2001-02-13 3:15 ` george anzinger
2001-02-13 2:05 ` Marcelo Tosatti
2001-02-13 10:08 ` Stephen C. Tweedie
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Pine.LNX.4.10.10101300929380.29461-100000@coffee.psychology.mcmaster.ca \
--to=hahn@coffee.psychology.mcmaster.ca \
--cc=linux-mm@kvack.org \
--cc=rasmus@jaquet.dk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox