From mboxrd@z Thu Jan 1 00:00:00 1970 Date: Mon, 8 Jan 2001 16:28:14 -0800 (PST) From: Linus Torvalds Subject: Re: Subtle MM bug In-Reply-To: Message-ID: MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: owner-linux-mm@kvack.org Return-Path: To: Marcelo Tosatti Cc: "Stephen C. Tweedie" , "David S. Miller" , Rik van Riel , linux-mm@kvack.org List-ID: On Mon, 8 Jan 2001, Marcelo Tosatti wrote: > > I've removed the free_shortage() of refill_inactive() in the patch. > > Comments are welcome. One comment: why does refill_inactive() do the shrink_dcache_memory() at all? Why not just remove that? do_try_to_free_pages() will do that, and that's where it makes more sense (shrinking the dcache/icache has absolutely nothing to do with the inactive list). Historical code? Also, we should probably remove the "made_progress" and "count--" from the swap_out() case, as swap_out() hasn't actually caused pages to be free'd in a long time.. Linus -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux.eu.org/Linux-MM/