From: Linus Torvalds <torvalds@transmeta.com>
To: "David S. Miller" <davem@redhat.com>
Cc: saw@saw.sw.com.sg, davej@suse.de, linux-kernel@vger.kernel.org,
linux-mm@kvack.org, tytso@mit.edu
Subject: Re: Updated Linux 2.4 Status/TODO List (from the ALS show)
Date: Thu, 12 Oct 2000 22:05:19 -0700 (PDT) [thread overview]
Message-ID: <Pine.LNX.4.10.10010122203410.14174-100000@penguin.transmeta.com> (raw)
In-Reply-To: <200010130425.VAA11538@pizda.ninka.net>
On Thu, 12 Oct 2000, David S. Miller wrote:
>
> page_table_lock is supposed to protect normal page table activity (like
> what's done in page fault handler) from swapping out.
> However, grabbing this lock in swap-out code is completely missing!
>
> Audrey, vmlist_access_{un,}lock == unlocking/locking page_table_lock.
Yeah, it's an easy mistake to make.
I've made it myself - grepping for page_table_lock and coming up empty in
places where I expected it to be.
In fact, if somebody sends me patches to remove the "vmlist_access_lock()"
stuff completely, and replace them with explicit page_table_lock things,
I'll apply it pretty much immediately. I don't like information hiding,
and right now that's the only thing that the vmlist_access_lock() stuff is
doing.
Linus
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux.eu.org/Linux-MM/
next prev parent reply other threads:[~2000-10-13 5:05 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2000-10-13 0:20 davej
2000-10-13 0:29 ` David S. Miller
2000-10-13 5:02 ` Linus Torvalds
2000-10-13 11:45 ` Alan Cox
2000-10-13 21:17 ` Richard Henderson
2000-10-13 21:19 ` Jakub Jelinek
2000-10-13 21:25 ` Linus Torvalds
2000-10-13 22:56 ` Richard Henderson
2000-10-13 22:47 ` Alan Cox
2000-10-13 22:57 ` Richard Henderson
2000-10-14 0:20 ` David S. Miller
2000-10-14 12:36 ` Roman Zippel
2000-10-13 21:29 ` David S. Miller
2000-10-13 4:34 ` Andrey Savochkin
2000-10-13 4:25 ` David S. Miller
2000-10-13 4:50 ` Andrey Savochkin
2000-10-13 5:05 ` Linus Torvalds [this message]
2000-10-13 18:11 ` Rasmus Andersen
2000-10-13 18:19 ` Kanoj Sarcar
2000-11-03 11:39 ` BUG FIX?: mm->rss is modified in some places without holding the page_table_lock tytso
2000-11-03 11:33 ` David S. Miller
2000-11-03 14:56 ` Theodore Y. Ts'o
2000-11-03 14:51 ` David S. Miller
2000-11-04 23:37 ` Rasmus Andersen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Pine.LNX.4.10.10010122203410.14174-100000@penguin.transmeta.com \
--to=torvalds@transmeta.com \
--cc=davej@suse.de \
--cc=davem@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=saw@saw.sw.com.sg \
--cc=tytso@mit.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox