From: Linus Torvalds <torvalds@transmeta.com>
To: "Juan J. Quintela" <quintela@fi.udc.es>
Cc: linux-mm@kvack.org, linux-kernel@vger.rutgers.edu
Subject: Re: PATCH: rewrite of invalidate_inode_pages
Date: Thu, 11 May 2000 15:22:15 -0700 (PDT) [thread overview]
Message-ID: <Pine.LNX.4.10.10005111519590.819-100000@penguin.transmeta.com> (raw)
In-Reply-To: <yttya5ghhtr.fsf@vexeta.dc.fi.udc.es>
On 11 May 2000, Juan J. Quintela wrote:
>
> Linus, I agree with you here, but we do a get_page 5 lines before, I
> think that if I do a get_page I should do a put_page to liberate it.
No, "get_page()" really means "increment the usage count by one", and the
problem is that it is obviously completely neutral wrt the actual size of
the page.
What we _could_ do is to just for clarity have
#define page_cache_get() get_page()
and then pair up every "page_cache_get()" with "page_cache_release()".
Which makes sense to me. So if you feel strongly about this issue..
Linus
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux.eu.org/Linux-MM/
next prev parent reply other threads:[~2000-05-11 22:22 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2000-05-11 21:40 Juan J. Quintela
2000-05-11 21:47 ` Linus Torvalds
2000-05-11 21:56 ` Juan J. Quintela
2000-05-11 22:22 ` Linus Torvalds [this message]
2000-05-12 1:01 ` Juan J. Quintela
2000-05-12 2:02 ` PATCH: new page_cache_get() (try 2) Juan J. Quintela
2000-05-11 22:22 ` PATCH: rewrite of invalidate_inode_pages Ingo Molnar
2000-05-11 22:34 ` Trond Myklebust
2000-05-11 22:54 ` Juan J. Quintela
2000-05-11 23:17 ` Trond Myklebust
2000-05-11 23:28 ` Juan J. Quintela
2000-05-11 23:55 ` Trond Myklebust
2000-05-12 11:28 ` John Cavan
2000-05-12 11:37 ` Juan J. Quintela
2000-05-12 12:51 ` Trond Myklebust
2000-05-12 13:21 ` Arjan van de Ven
2000-05-12 13:35 ` Trond Myklebust
2000-05-12 17:57 ` Juan J. Quintela
2000-05-12 13:30 ` Juan J. Quintela
2000-05-11 22:05 ` Jeff V. Merkey
2000-05-11 22:28 ` Trond Myklebust
2000-05-11 22:43 ` Juan J. Quintela
2000-05-11 22:56 ` Trond Myklebust
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Pine.LNX.4.10.10005111519590.819-100000@penguin.transmeta.com \
--to=torvalds@transmeta.com \
--cc=linux-kernel@vger.rutgers.edu \
--cc=linux-mm@kvack.org \
--cc=quintela@fi.udc.es \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox