From: Linus Torvalds <torvalds@transmeta.com>
To: "Juan J. Quintela" <quintela@fi.udc.es>
Cc: linux-mm@kvack.org, linux-kernel@vger.rutgers.edu
Subject: Re: PATCH: Bug in invalidate_inode_pages()?
Date: Mon, 8 May 2000 16:51:44 -0700 (PDT) [thread overview]
Message-ID: <Pine.LNX.4.10.10005081648230.5411-100000@penguin.transmeta.com> (raw)
In-Reply-To: <yttk8h4vcgp.fsf@vexeta.dc.fi.udc.es>
On 9 May 2000, Juan J. Quintela wrote:
> I think that I have found a bug in invalidate_inode_pages.
> It results that we don't remove the pages from the
> &inode->i_mapping->pages list, then when we return te do the next loop
> through all the pages, we can try to free a page that we have freed in
> the previous pass.
This is what "remove_inode_page()" does. Maybe that's not quite clear
enough, so this function may certainly need some comments or something
like that, but your patch is wrong (it will now delete the thing twice,
which can and will result in list corruption).
> Once here I have also removed the goto
Because we dropped the page cache lock, we really have to repeat, because
the lists are now no longer protected..
Linus
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux.eu.org/Linux-MM/
next prev parent reply other threads:[~2000-05-08 23:51 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2000-05-08 23:39 Juan J. Quintela
2000-05-08 23:51 ` Linus Torvalds [this message]
2000-05-08 23:55 ` Juan J. Quintela
2000-05-09 0:29 ` Trond Myklebust
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Pine.LNX.4.10.10005081648230.5411-100000@penguin.transmeta.com \
--to=torvalds@transmeta.com \
--cc=linux-kernel@vger.rutgers.edu \
--cc=linux-mm@kvack.org \
--cc=quintela@fi.udc.es \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox