From mboxrd@z Thu Jan 1 00:00:00 1970 Date: Thu, 4 May 2000 23:51:04 -0700 (PDT) From: Linus Torvalds Subject: Re: 7-4 VM killing (A solution) In-Reply-To: <39126DB2.2DD7CAB3@sgi.com> Message-ID: MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: owner-linux-mm@kvack.org Return-Path: To: Rajagopal Ananthanarayanan Cc: riel@nl.linux.org, Kanoj Sarcar , linux-mm@kvack.org, "David S. Miller" List-ID: On Thu, 4 May 2000, Rajagopal Ananthanarayanan wrote: > > On another note, noticed your change to shrink_mmap in 7-5: > > ------- > - count = nr_lru_pages >> priority; > + count = (nr_lru_pages << 1) >> priority; > ------- > > Is this to defeat aging? If so, I think its overly cautious: > if all an iteration of shrink_mmap did was to flip the referenced bit, > then that iteration shouldn't be included in count (and in the > current code it isn't). So why double the effort? It was indeed because I thought we should defeat aging. But you're right, the reference bit flip doesn't get counted. My bad, and I'll revert that one (and you found the real reason for pages not getting free'd anyway) Linus -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux.eu.org/Linux-MM/