From mboxrd@z Thu Jan 1 00:00:00 1970 Date: Wed, 3 May 2000 21:10:05 -0700 (PDT) From: Linus Torvalds Subject: Re: Oops in __free_pages_ok (pre7-1) (Long) (backtrace) In-Reply-To: <3910EB99.2B9E1980@sgi.com> Message-ID: MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: owner-linux-mm@kvack.org Return-Path: To: Rajagopal Ananthanarayanan Cc: Kanoj Sarcar , linux-mm@kvack.org, "David S. Miller" List-ID: On Wed, 3 May 2000, Rajagopal Ananthanarayanan wrote: > > One other problem with having the page locked in > try_to_swapout() is in the call to > prepare_highmem_swapout() when the incoming > page is in highmem. Look at how I handled this in pre7-4. Just unlocking the old page and returning with the new page locked is quite acceptable. The "prepare_highmem_swapout()" thing breaks the association with the pages anyway, and as such there is no race (and this is allowable only exactly because of the anonymous and non-shared nature of a private COW-mapping - which is the only thing we accept in that code-path anyway). Doing it that way means that there are no special cases in vmscan.c. Linus -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux.eu.org/Linux-MM/