From: Linus Torvalds <torvalds@transmeta.com>
To: Kanoj Sarcar <kanoj@google.engr.sgi.com>
Cc: riel@nl.linux.org, Russell King <rmk@arm.linux.org.uk>,
linux-mm@kvack.org, linux-kernel@vger.rutgers.edu
Subject: Re: [PATCH] Re: kswapd
Date: Sun, 26 Mar 2000 22:07:48 -0800 (PST) [thread overview]
Message-ID: <Pine.LNX.4.10.10003262200520.1538-100000@penguin.transmeta.com> (raw)
In-Reply-To: <200003270121.RAA88890@google.engr.sgi.com>
On Sun, 26 Mar 2000, Kanoj Sarcar wrote:
>
> What is the problem that your patch is fixing?
I agree with Rik's patch - the old behaviour kicked us out of the regular
loop whenever "need_resched" was set, and that is not necessarily a good
idea at all.
>From a conceptual standpoint, going to sleep when "need_resched" gets set
is not the right thing at all - the flag doesn't really have any bearing
on whether kswapd should sleep, it only has meaning from a scheduling
latency standpoint (ie "need_resched" does not mean "go to sleep", it
means "let somebody else run now" - different things).
On the other hand you're definitely right that this is not a new bug
introduced by you, Kanoj - this seems to be just a thinko that has been
there for a long long time. And I suspect I may have been the original
perpetrator of the crime.
The new code looks much saner: it reschedules when asked to, and it stops
looping when it makes sense (ie when there is no longer any reason to free
pages). Instead of mixing the two up.
Linus
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux.eu.org/Linux-MM/
next prev parent reply other threads:[~2000-03-27 6:07 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <200003261008.LAA16031@raistlin.arm.linux.org.uk>
2000-03-27 0:59 ` Rik van Riel
2000-03-27 1:21 ` Kanoj Sarcar
2000-03-27 2:28 ` Rik van Riel
2000-03-27 2:39 ` Kanoj Sarcar
2000-03-27 6:42 ` Russell King
2000-03-27 6:02 ` Eric W. Biederman
2000-03-27 6:07 ` Linus Torvalds [this message]
2000-03-27 8:00 ` Kanoj Sarcar
2000-03-27 14:47 ` Rik van Riel
2000-03-27 16:14 ` Linus Torvalds
2000-03-27 16:54 ` Mark Hahn
2000-03-27 17:36 ` Linus Torvalds
2000-03-27 17:54 ` Rik van Riel
2000-03-27 18:55 ` Kanoj Sarcar
2000-03-27 18:34 ` Russell King
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Pine.LNX.4.10.10003262200520.1538-100000@penguin.transmeta.com \
--to=torvalds@transmeta.com \
--cc=kanoj@google.engr.sgi.com \
--cc=linux-kernel@vger.rutgers.edu \
--cc=linux-mm@kvack.org \
--cc=riel@nl.linux.org \
--cc=rmk@arm.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox