From: Andrea Arcangeli <andrea@suse.de>
To: "Eric W. Biederman" <ebiederm+eric@ccr.net>
Cc: Linus Torvalds <torvalds@transmeta.com>,
linux-mm@kvack.org, linux-kernel@vger.rutgers.edu
Subject: Re: [PATCH] depricate ZMAGIC binaries
Date: Mon, 24 May 1999 16:55:27 +0200 (CEST) [thread overview]
Message-ID: <Pine.LNX.4.05.9905241654130.2102-100000@laser.random> (raw)
In-Reply-To: <m1btfbsk67.fsf@flinx.ccr.net>
On 23 May 1999, Eric W. Biederman wrote:
>diff -uNrX linux-ignore-files linux-2.3.3.eb1/mm/filemap.c linux-2.3.3.eb2/mm/filemap.c
>--- linux-2.3.3.eb1/mm/filemap.c Tue May 18 01:11:52 1999
>+++ linux-2.3.3.eb2/mm/filemap.c Tue May 18 01:12:47 1999
>@@ -1319,8 +1319,7 @@
> return -EINVAL;
> } else {
> ops = &file_private_mmap;
>- if (inode->i_op && inode->i_op->bmap &&
>- (vma->vm_offset & (inode->i_sb->s_blocksize - 1)))
>+ if (vma->vm_offset & (PAGE_SIZE -1))
> return -EINVAL;
Minor issue: since now there is no difference in the align check between
VM_SHARED and VM_PRIVATE you can check the alignment in a common path.
Andrea Arcangeli
--
To unsubscribe, send a message with 'unsubscribe linux-mm my@address'
in the body to majordomo@kvack.org. For more info on Linux MM,
see: http://humbolt.geo.uu.nl/Linux-MM/
prev parent reply other threads:[~1999-05-24 15:46 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
1999-05-23 18:41 Eric W. Biederman
1999-05-24 14:55 ` Andrea Arcangeli [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Pine.LNX.4.05.9905241654130.2102-100000@laser.random \
--to=andrea@suse.de \
--cc=ebiederm+eric@ccr.net \
--cc=linux-kernel@vger.rutgers.edu \
--cc=linux-mm@kvack.org \
--cc=torvalds@transmeta.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox