From: Andrea Arcangeli <andrea@e-mind.com>
To: "Eric W. Biederman" <ebiederm+eric@ccr.net>
Cc: linux-mm@kvack.org
Subject: Re: 2.2.0-final
Date: Sun, 24 Jan 1999 13:49:28 +0100 (CET) [thread overview]
Message-ID: <Pine.LNX.3.96.990124134751.404A-100000@laser.bogus> (raw)
In-Reply-To: <m1pv85fke1.fsf@flinx.ccr.net>
On 23 Jan 1999, Eric W. Biederman wrote:
> AA> extern inline void buffer_get(struct buffer_head *bh)
> AA> {
> AA> struct page * page = mem_map + MAP_NR(bh->b_data);
>
> AA> switch (atomic_read(&page->count))
> AA> {
> AA> case 1:
> AA> atomic_inc(&page->count);
> AA> nr_freeable_pages--;
>
> This is bogus. Consider the case when you have 4 buffers per page (common with ext2fs)
> You will way underestimate the number of freeable pages.
I will not only understimate: the kernel will not boot at all ;). It's a
last minute wrong hack I did (I replaced some if with the switch statement
and I did a mistake). See my following post. Thanks.
Andrea Arcangeli
--
To unsubscribe, send a message with 'unsubscribe linux-mm my@address'
in the body to majordomo@kvack.org. For more info on Linux MM,
see: http://humbolt.geo.uu.nl/Linux-MM/
next prev parent reply other threads:[~1999-01-24 12:49 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <Pine.LNX.3.95.990120224340.23558G-100000@penguin.transmeta.com>
1999-01-23 20:56 ` 2.2.0-final Andrea Arcangeli
1999-01-24 1:51 ` 2.2.0-final Andrea Arcangeli
1999-01-24 2:57 ` 2.2.0-final Eric W. Biederman
1999-01-24 12:49 ` Andrea Arcangeli [this message]
1999-01-24 13:16 ` 2.2.0-final Andrea Arcangeli
1999-01-24 13:28 ` 2.2.0-final Andrea Arcangeli
1999-01-24 18:41 ` 2.2.0-final Eric W. Biederman
1999-01-24 23:05 ` 2.2.0-final Andrea Arcangeli
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Pine.LNX.3.96.990124134751.404A-100000@laser.bogus \
--to=andrea@e-mind.com \
--cc=ebiederm+eric@ccr.net \
--cc=linux-mm@kvack.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox