From mboxrd@z Thu Jan 1 00:00:00 1970 Date: Tue, 26 Sep 2000 19:44:28 -0400 (EDT) From: Alexander Viro Subject: Re: [CFT][PATCH] ext2 directories in pagecache In-Reply-To: Message-ID: MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: owner-linux-mm@kvack.org Return-Path: To: Alexander Viro Cc: Andreas Dilger , Linus Torvalds , Ingo Molnar , Andrea Arcangeli , Rik van Riel , Roger Larsson , MM mailing list , linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org List-ID: On Tue, 26 Sep 2000, Alexander Viro wrote: > On Tue, 26 Sep 2000, Andreas Dilger wrote: > > > Al Viro writes: > > > Folks, give it a try - just keep decent backups. Similar code will > > > have to go into UFS in 2.4 and that (ext2) variant may be of interest for > > > 2.4./2.5. timeframe. > > > > Haven't tested it yet, but just reading over the patch - in ext2_lookup(): > > > > if (dentry->d_name.len > UFS_MAXNAMLEN) > > return ERR_PTR(-ENAMETOOLONG) > > > > should probably be changed back to: > > > > if (dentry->d_name.len > EXT2_NAME_LEN) > > return ERR_PTR(-ENAMETOOLONG) > > Grrr... It shows the ancestry - it's a ported UFS patch. Thanks for spotting, > I'll fix that. Aha. And there was that UFS_LINK_MAX thing. Fixed. OK, new version is on the same site, URL being ftp://ftp.math.psu.edu/pub/viro/ext2-patch-8.gz Changes: got rid of the remnants of UFS ancestry (EXT2 limits are used; not that it mattered much, but...), fixed the conversion in ext2_empty_dir() (cpu_to_le32() instead of le32_to_cpu()). Cheers, Al -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux.eu.org/Linux-MM/