From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id E91E4C71130 for ; Tue, 8 Jul 2025 00:04:02 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 7A9AE6B030C; Mon, 7 Jul 2025 20:04:02 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 759FF6B0311; Mon, 7 Jul 2025 20:04:02 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 4E94D6B030C; Mon, 7 Jul 2025 20:04:02 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 24BDD6B0305 for ; Mon, 7 Jul 2025 20:04:02 -0400 (EDT) Received: from smtpin21.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id 9176C58E6B for ; Tue, 8 Jul 2025 00:04:01 +0000 (UTC) X-FDA: 83639149482.21.DFC585C Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.15]) by imf12.hostedemail.com (Postfix) with ESMTP id D17BB40008 for ; Tue, 8 Jul 2025 00:03:57 +0000 (UTC) Authentication-Results: imf12.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=SeSgFOh5; spf=pass (imf12.hostedemail.com: domain of kanchana.p.sridhar@intel.com designates 192.198.163.15 as permitted sender) smtp.mailfrom=kanchana.p.sridhar@intel.com; dmarc=pass (policy=none) header.from=intel.com; arc=pass ("microsoft.com:s=arcselector10001:i=1") ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1751933038; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=nEfG7pwrGqcOtmEb623MhrpVTmR/PXp0YXTcKGOJgBQ=; b=haJ+gwMk0TBakOxu2R42iFCsrXn6rkcfkeBdSPy9TpPoQQi7VDQK/FHz8CJDtjMKXcQP/J IjnZUCoG/fSrp3RrDVMxQk1R8exxO8UB3ROgWO3xaHr6gbHAmp5N9gtK2/b678raQ/MZwJ xhL9CgxMTgx4PAjCfnnffPv+E1ED13E= ARC-Authentication-Results: i=2; imf12.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=SeSgFOh5; spf=pass (imf12.hostedemail.com: domain of kanchana.p.sridhar@intel.com designates 192.198.163.15 as permitted sender) smtp.mailfrom=kanchana.p.sridhar@intel.com; dmarc=pass (policy=none) header.from=intel.com; arc=pass ("microsoft.com:s=arcselector10001:i=1") ARC-Seal: i=2; s=arc-20220608; d=hostedemail.com; t=1751933038; a=rsa-sha256; cv=pass; b=kvdSuZA9qNkjhjbQUKSmPMZ5cO7Y6KYI/M6oSGiQk8CQshlVwF1GhGXS/DZdjFOCrenPVi yHlzC0xLBtORY8i79tS2D9JoBKESilt1h+aXBWKzJvcn1cex4VobdAq8YxHF7ioHgtAUlR QDWDB89yT5Bh9vaA7Ri7dciRtqgBGr8= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1751933038; x=1783469038; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=Wj9E/vw9+eTVyOcISwLN1l14zKuThs1xrs3CravZyxg=; b=SeSgFOh5DeHURWMnkBocfFk1mmicgeIavAoe8tlyI32GRv6ynTdS3xW8 lgPimoxCW+jPhpvI7qEMeM4LhowuPwZfJ83ETPpyRGGluSJb9jM0iiPJF 5SqWvGA62Hxs/CQ6LhmZ0N14HCTT9yegVd2ZWTEN4MMwXqdAGe3d+7GMD W8FKylaHafajTStR5PzhhYfn/G8HUJ88di4ohsehAyKuHqjTHLGl9CbGD Kf50TzBvrrjwYJiFlFfGhc+YXJMEJxY8VGE3WlMarfEDUi67NnQhQZquD jxXOd0SyPYWQl+tfonQHQtmWwZMtzkgGnt/9mQmY6uHzNo+GdbnxZZpEz g==; X-CSE-ConnectionGUID: 4RLI3yTBSESC+Xo4/i/+dA== X-CSE-MsgGUID: +fJHGkxSTUa5y5Qm3OWTTg== X-IronPort-AV: E=McAfee;i="6800,10657,11487"; a="54304511" X-IronPort-AV: E=Sophos;i="6.16,295,1744095600"; d="scan'208";a="54304511" Received: from fmviesa007.fm.intel.com ([10.60.135.147]) by fmvoesa109.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 07 Jul 2025 17:03:56 -0700 X-CSE-ConnectionGUID: VFxVXy/SS/2cYYgVwCJ8AQ== X-CSE-MsgGUID: FKhDL6uJSxu1yIp9xMV1QA== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.16,295,1744095600"; d="scan'208";a="154976752" Received: from orsmsx902.amr.corp.intel.com ([10.22.229.24]) by fmviesa007.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 07 Jul 2025 17:03:55 -0700 Received: from ORSMSX901.amr.corp.intel.com (10.22.229.23) by ORSMSX902.amr.corp.intel.com (10.22.229.24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.25; Mon, 7 Jul 2025 17:03:55 -0700 Received: from ORSEDG901.ED.cps.intel.com (10.7.248.11) by ORSMSX901.amr.corp.intel.com (10.22.229.23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.25 via Frontend Transport; Mon, 7 Jul 2025 17:03:55 -0700 Received: from NAM12-DM6-obe.outbound.protection.outlook.com (40.107.243.47) by edgegateway.intel.com (134.134.137.111) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.25; Mon, 7 Jul 2025 17:03:54 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=LtINQlZNDXZ0/FSCFXOFaUgsJLN+/EZvoXgvmFJRsOvLAKTf9e5IL6jgZUPT4KBVw+diNW69/lwda8WuPBM55oiv1dZyHY7gXEnl4s+ACwVfit8S+Ei+rIcR0wBljJ26BSO8HSDu54KE7IimIDRvi0FVEYe/fXhNjGeO/R1nYZSrvZso4d4755qVmw/2syotlVoy/2fZ360qj3ZBIrTnzddSUoS0wemMTcdIUKA+DSTmIij9pGP/3seoZNe3W/Lpu65y2cPpoyQqeLd+GNGr2c8GwVwJV9fcG6yMXFggFFClisZ7BL07GsNOAQkDU9skWlcyU2r8rJjCYgmWxBsAxw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=nEfG7pwrGqcOtmEb623MhrpVTmR/PXp0YXTcKGOJgBQ=; b=OhWBDJ2Uj5Xczqm242oPvnSUtPR+h5C2y7r83dk7fH7ZkAsWlnljQwJ/gcMVAF0XcqoheY6qdmSH/9czGoR5n4UeVpvEad2gZbcd6GC1k4QYcfZKTfSiCL4fy4zUcoEXfl39W51QtvQM+RZYTjXzlHSNsDTZHVqWoMDGczpjLk2Uf5TDzv6C1jVxlygNep1Zkf8zb+GCCVSckOmxXOnEgqX09zpdJDYqbi2b4JNpbRjG+sdUhigZgFxJLvdEMpXsfpCNemuV+He36bvX8zZM+Wspiyo/SiUlWU0RltyXIGy+k9OXiWLSRmtI6jP3l3UTspVarNwU+xxFGmzoMjBrVg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from PH7PR11MB8121.namprd11.prod.outlook.com (2603:10b6:510:234::14) by SJ0PR11MB5940.namprd11.prod.outlook.com (2603:10b6:a03:42f::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8901.25; Tue, 8 Jul 2025 00:03:11 +0000 Received: from PH7PR11MB8121.namprd11.prod.outlook.com ([fe80::ec4e:64cf:cf1f:daab]) by PH7PR11MB8121.namprd11.prod.outlook.com ([fe80::ec4e:64cf:cf1f:daab%4]) with mapi id 15.20.8901.023; Tue, 8 Jul 2025 00:03:11 +0000 From: "Sridhar, Kanchana P" To: Al Viro CC: "linux-kernel@vger.kernel.org" , "linux-mm@kvack.org" , "hannes@cmpxchg.org" , "yosry.ahmed@linux.dev" , "nphamcs@gmail.com" , "chengming.zhou@linux.dev" , "usamaarif642@gmail.com" , "ryan.roberts@arm.com" , "21cnbao@gmail.com" <21cnbao@gmail.com>, "ying.huang@linux.alibaba.com" , "akpm@linux-foundation.org" , "senozhatsky@chromium.org" , "Feghali, Wajdi K" , "Gopal, Vinodh" , "Sridhar, Kanchana P" Subject: RE: [PATCH v1 1/2] mm: zswap: Per-CPU acomp_ctx resources exist from pool creation to deletion. Thread-Topic: [PATCH v1 1/2] mm: zswap: Per-CPU acomp_ctx resources exist from pool creation to deletion. Thread-Index: AQHb73ue+1h45F4SL06LS2CbuB2vR7QnN8AAgAAf0jA= Date: Tue, 8 Jul 2025 00:03:11 +0000 Message-ID: References: <20250707201315.9497-1-kanchana.p.sridhar@intel.com> <20250707201315.9497-2-kanchana.p.sridhar@intel.com> <20250707220616.GN1880847@ZenIV> In-Reply-To: <20250707220616.GN1880847@ZenIV> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-publictraffictype: Email x-ms-traffictypediagnostic: PH7PR11MB8121:EE_|SJ0PR11MB5940:EE_ x-ms-office365-filtering-correlation-id: fdadfb71-7dce-4ef9-68c3-08ddbdb2d3b9 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0;ARA:13230040|366016|1800799024|376014|7416014|38070700018; x-microsoft-antispam-message-info: =?us-ascii?Q?xD2iSkNfSmP2gIbYZeupng5T0YfetnXC7yzhL8TL5hfeq9UjK5f81RBT5WCA?= =?us-ascii?Q?HsldYEyH8ANx70NBU2e+Hv77eg7w+fLFrRIioZom+6Ay6Gp/iGdxCpyxL+an?= =?us-ascii?Q?zZcuU1OeFveXRu1WQGUUET+AJES2z+7K2Y5AW8qVOCSv/0O8H5ajHRV74ii1?= =?us-ascii?Q?eJod47ndwlkg6hGYNd2Z4aPWO5031ax//2fPyqVMhhiBejASjWgKgNjjtwmm?= =?us-ascii?Q?EIBNZDLTuNCF8FGyLKiwXrb5/FBGhN3MIqce7JhK6PocaCkZOh0fLZa0p4fo?= =?us-ascii?Q?7hmj6PIVnZOtBJafuTBktQpGZzIDTtVHXAxmGf3R2G50tQkvrVgvpZXDLqqw?= =?us-ascii?Q?Tu5n7WGMI4dC4ONJ39noeabWCSzSHDRnM++zcV7tCerBLnAC1InSb0RN3iFM?= =?us-ascii?Q?SoNc6/kiECTynuDTUXzc+f/v/wOhkOut4FFYzgEOBzT4VbvtFJldaHU1Pux7?= =?us-ascii?Q?dZiPHfIujMwRRjHUJqphLKxHTXFTtO7aW0PYJPiQXYt4yCZT1QmiL3uaGxwW?= =?us-ascii?Q?TcaV3Zi4/xa7OWYjW9mszA4YLn7wiMaz14v/v38Ui0yLlpVhxWarW9O/1h3s?= =?us-ascii?Q?nb7xOtadNPkFPqzA2zS1WIX5L5yOpIzB+ObTl4Hk3MxGdrV1E5QkRCogeAVS?= =?us-ascii?Q?PZwF1IPSwgcXwSjTAVIH1HVWy5/kSkLlOhSt1Es8XHWjo4CmpcFIlyUYB4hC?= =?us-ascii?Q?3SldLgfmeQX6IRjWLKA+Y/ckfiUFK9WbZaeS5PGjeZx/vxa+msPccBet2KEC?= =?us-ascii?Q?+BhBg1zU48KvjopSbk30Q50l/R+pO0jhr3syiXF3CEOhiPpUni+9iy42UJ1w?= =?us-ascii?Q?/I7/zOlHdUYxqJSgUYCjD7Ne+wfKw7apWVN7r1jd6pJ18jMU6tsMxylcqHe3?= =?us-ascii?Q?yW9IHxTyT9XwQBSvoY8z9Ob0/QIxIWtFZP/0af+h0v14Lwks3FJXPNRGskvX?= =?us-ascii?Q?z73CIuFngR8oAtgeFAL6LVohCCN2GH6B3C1nUHAhLKhuAus4RhyizuVdyxvW?= =?us-ascii?Q?hox6FqGhfqoh5DlGGtF8+mlrnI17oAqMzlMK/6Pv23G0JIqNip0fJf0XuJeJ?= =?us-ascii?Q?S4BQhGYi3ACVbcbxAp4c9iKma4iJPj0RBVm/4VrZsMHw5wHpeqLopZMY29yj?= =?us-ascii?Q?1uLWr5/wSH87zFccrMgiSydjbiIuJ7uLkInjXavJjPMlAuCHntHmlCij4hPd?= =?us-ascii?Q?fjXwl0CeWjJWEvhXRNaRdRkbeaKSXvZMyR2GAyDz0Mkbw4RQJJguoysVG+r2?= =?us-ascii?Q?TPwwub1dIIliayJukhyx2Nxm7i83xjJLNksxMMhQ7+hDNVx8puGNQyaiv5QL?= =?us-ascii?Q?n/KL13451SFZKuaaMYSlfGM+u5WsPA38zTDEldHl4m+iRnrQbRAeW1DoCN9/?= =?us-ascii?Q?nV5f+qyBpeebhhBMmraQavNDb0kG7VySjn8k63ZB7VHhoxAZpYjQ8WH224w+?= =?us-ascii?Q?/uH7nvFoCdZgyRCZiV7HUttpletHQDfrKPwiJG3dfddFzBGLpMgA2w=3D=3D?= x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PH7PR11MB8121.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(366016)(1800799024)(376014)(7416014)(38070700018);DIR:OUT;SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?nTAR9Kspws5K08WUZDfb2LnY6Eh8+35LX4ovmEl2qmYqZazq6VZaLzJcdtyr?= =?us-ascii?Q?Np5bcYzwMEVV7wK9TXlng32/SpjpuAD3NWZfiGx3fkogroF8ElVui0umbl4n?= =?us-ascii?Q?GPnlyDpcAEYe2YGYWPQCFkZ3SGxqEt132OvMmtNXjuXpxZMftRnkoD1Dusl2?= =?us-ascii?Q?yibpn8XMSJXoQo7XyFtwttB2FdAlW1PthL1CwmQdHTTEqSPK46NaiZOO+hBA?= =?us-ascii?Q?8ZHHKdUjtAqRUdNakNfzTYHgjAlskem6RxexTznFl6WPjYCSK9frrAQRTS8n?= =?us-ascii?Q?UA2Ji+CwwLM+CxvDARVsTbLMMgHKYIabVGhDyJ4rVJfghJBsVbQVHV8oJ4zg?= =?us-ascii?Q?ai1xjQRrdfnGksL/X70J9FTU+9qH3LqPIghJa18myZEptLSXyB90rhH9YnjG?= =?us-ascii?Q?LYL+kSmIFkY9blcFtPn1CmGT8kGOCHqIhuWgXaUf3yUfpBhCAa3PxvfRewUG?= =?us-ascii?Q?tS/q1RJKlGC/J1fdNq8i6Sk4mr1kuzKvZc0RfYcZ28glgWm6R9idKuMxjdq9?= =?us-ascii?Q?9uoh2tpUC4rxJ14Gycf2mjcGvY+eIfFKNOquotFvfDsmuQ+BSBMP8bFebOob?= =?us-ascii?Q?1qoGolRxTryyE47OkzrgPxOXRHSpjdWUqHqMViErLWd7irMPAaFmvZEUlAtc?= =?us-ascii?Q?oKT0t7gquckIyd857EbxFk1WzpLldA7dqG4fZUwOfA/DiDQNUjxFMFolEkBr?= =?us-ascii?Q?CSc8Y5xpxVER0dUvj0ZtyWIfrcSwb7SscY80LBZtjxLa6vadAagFiWjNKkYS?= =?us-ascii?Q?rOlanqa4j5GsTmeSeTUjWZyHObg92rxmET8a3Ug3wjIp5WsDyZeN5Tvvmjf3?= =?us-ascii?Q?EMaEvEnvrEpXmEpualX+UMRBummQr/fZVk3EUepNy/MOoql0TrOQ4B+j4ePY?= =?us-ascii?Q?Le/C+hEt77I6OQB5MbRNaKKTvZYJ1z/Gwk7xqxtAuKVrG9QOmA2Z8l9KjTQT?= =?us-ascii?Q?HYHknQcmXwIt1QnGO5JTvF0czHPchRUEGWq9SXEOTbFAxU/qEhkg+hStwZQ8?= =?us-ascii?Q?hsAoIa1aOrpkF5QVfLWbY6ZBw+8sZXgMmibACWzkATDObH16U0LEtFRtfJVX?= =?us-ascii?Q?ptpEykaBgQU0Sp1HuTstpdr4Yh4NPljq054rAnUDpwS6RfWVoRxXr98Ekr90?= =?us-ascii?Q?of2f4klB7FOIN5qIo+Ylgy6TDAPiM/nsp640kJ0cKiuR66CSdRK2C4wduTex?= =?us-ascii?Q?Sjn6LZVFZeWsad5n8PqJ7Z7Vl+3tOCCVMJD+VeLustDCgcAZ3x3i4L5f/fHm?= =?us-ascii?Q?yASlfaFbBXp8c5ssFvBuvRmNJEu2x25/RCNSnjPw33hYJbeQ3vgOdUTnLKqE?= =?us-ascii?Q?Vz8io9YDps1Hs93bbw7zDHU9Hfey0w7rg+ywgA92hTg48/cKZbexL/T/HAZ/?= =?us-ascii?Q?DxLMVkBARCkfCPOifxGTVLgADc/eWaESTbdJNDW1PB3nymYpUN5N0mDQNHz2?= =?us-ascii?Q?FHjTPEQyqAnux/RliE/rlIp/jePsGiEPBGfArxYZrHnqF2Lh8qjWzpnE1dQN?= =?us-ascii?Q?Amn0r1a4T0SxGegIr4njjmjW4IkfsdGL93MgDuKiTLxblRw/2yxEf2i3SgjT?= =?us-ascii?Q?B7QfWs6Jiwaz7qBniNrNZG9zPMLVVqimPJHSnSE0Y++zPjfPbuLbWVRJE+Bg?= =?us-ascii?Q?aw=3D=3D?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: PH7PR11MB8121.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: fdadfb71-7dce-4ef9-68c3-08ddbdb2d3b9 X-MS-Exchange-CrossTenant-originalarrivaltime: 08 Jul 2025 00:03:11.0327 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: 3Sxn1agppLsLPoZ1xOxXQPhCivb/jW0LfktkIqclLEVbJ38MEnYZgnoj4O4/iidgWDM0+9ZHBcncL7MGL4a7EQffsrPDsfAckrp35Cfn6ZU= X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ0PR11MB5940 X-OriginatorOrg: intel.com X-Rspamd-Queue-Id: D17BB40008 X-Stat-Signature: fybtfimd4psz9otqyres6dsnz1o4za4w X-Rspam-User: X-Rspamd-Server: rspam05 X-HE-Tag: 1751933037-345009 X-HE-Meta: U2FsdGVkX18gbqjOS7W5/99DPtI9qfCi5TArrm7oaBw4kj21uox7H41NcHlJtsjFfN8/ofZkVmRgKZQfYeCb4OBJ4XQmXk6dOkZpT7XqJBbZpfAZ0y5dI27Jow8MBZS73wjOVPpS7cvrzOWGfuEDnRnm0UQJWPCyduPveOtSBCwRNN/u8aaTkUkoJq/NXrMTvw78Vtedx/a2IaVsQ6rwnojGgIeIhe90qIBS0U2Hn/KHzqLa3GtWug8iGqJIkegZr2T1stvYVyRivPCSB/hiBHXKmLIzmake68ImScjxLlT4sqmtXpWocauAjla4P7ngqJ2JtF9rVnVZjR0GBGor52qaVsJLCeLkPwP5x6OC5FTkz8w7J2UpF2VBZnsEDP8eLpCxiEe2g+pYDJxirVY17Wy94JNVCnIBcLszcuXzbFEIiNRQwvgoK0ImyicK18U7J7d94+tvdGo8Z0TEPKsTmCotGVfdlB/j3xRLF8Ek66U3K3Xd9ZQ2icV9igOW/mJzp+8GeUn2W64baQRUU/7igZpGlcXWEE03HPelY7PvpRJOted6hkAUUxAD6YoUxhPyd+oVumvR7LlpMhz4p2D+mYVc9vYc98DugfEBXh/ldEKmrLNmLS14WQF+FKtp/1rCyH9hDna/m9OK2wyZfPksiJYY0Ndy9hfclTEzQXsDrmGHm+G1O1e5bNd32JueOZrJZU5CbbHFyiS2TKcjzGKmpSK2yg5nCD+J+rG1h9xFlnkDkBfFoERY77A8IE9VbK/3geTwXgteSWCuVOBffR1Bm6XBfo9dAp+Ni3qh3sfh0vCIutR9af/vVoItm+XM0/03m/oCLcQAuyri54JLvjJCYhQZWtrhBNRYjAtQvsaErcNEX0ypBDJYQy1h3aOrx9zdDtSDLW+VepBVKcSVpFyFcJHYUWLJ3adHRww+huFr8KBLAelRvGuhACyDfrEiXaWpyU0ZfcUzP9T7Asr2iUk irfjhmy2 c5pwZwM+wrWvO0ZAVGgmyNrhotAmXImt4w8LylNF/6HOg3EdyEp8J6XN1euz7C86Oxie2oPR1AyVy3ALD8nIm9pDBrAgkwCtTetcL+PdxNa8IszdhJVINb142UfW/03a4iKF6yqOgJa0LmqKYsf9SIOK03nHzwg3PTcD6cN/qMNGSjxReQx5r2dJtnaPo3wAHQVuAdTk1Xj62RcfrYYnF+ZRtJ7pQUlJY1g0CX639PUJpYeBZrFx1p2GKOkQN1eFfWYp5rfFajoelASxyg445QObssu98QyWiOuib3+wK1EDgmR4Hd+61nfXHZ303dX0f8RXpip0siPOk4dI3aE6e9RSpG38o0jwM34IEoStYp9KSb2Qi3KAzI6RN4cfjKBvm0KURcWqRFVrN1n2Sb9xBoYtoak/ahlV9pUcaHFYPiwckKs+yPwymsNMD8cLDqPJ/89Vv8ezViZlyBe8XgHDX4Iqq53d8hyitNchpvvHDKc9INN16hWl/6QFxmo4zhrxXGs+sD2Llh54AF5aKVKY+hfa2tFAtmA5UMURaI5PDkpGpOtLZmBYKR8duegSkFHSe50yDpZiajI02FkEImTsHyl8+6zKvUo63ICfnwb65cjP4Vrhh1yC/c9OKWUxk8RSPzSWjxmGHgZclEjEkNydWu/P4nprRMBw9Fm//GioavASUGLWt6Z2pdE2UZAcS8Ik+sUpEPuRX1S74BWO5f0YgfUrERcU0Ng6rdC6bWgibwPJDNRLWE0TcIDibZfkvJVsu3P5k0OTLJMCJ4XEbSUZ8rGQFXWrlpZmnW/zAW79t5oREzzvbaCVtXd2/YrFccPk72wY1fa3xfqRV06nBLLHk1mqGbhh9ptqLmImV6StLn7ATKCy5y2cOo7EJ3WAVcvfyZ0/TD1z4j/wVkadzqDeQtqo3sIqF+OaIOMLyUR5maN6tBWP1SLkIVcvyrG1LBBG/iyD5iKNupy6sl7pcvwKKrf4C5fGZ ZBL8/xVe Wxg6CwZwCak= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: > -----Original Message----- > From: Al Viro On Behalf Of Al Viro > Sent: Monday, July 7, 2025 3:06 PM > To: Sridhar, Kanchana P > Cc: linux-kernel@vger.kernel.org; linux-mm@kvack.org; > hannes@cmpxchg.org; yosry.ahmed@linux.dev; nphamcs@gmail.com; > chengming.zhou@linux.dev; usamaarif642@gmail.com; > ryan.roberts@arm.com; 21cnbao@gmail.com; > ying.huang@linux.alibaba.com; akpm@linux-foundation.org; > senozhatsky@chromium.org; Feghali, Wajdi K ; > Gopal, Vinodh > Subject: Re: [PATCH v1 1/2] mm: zswap: Per-CPU acomp_ctx resources exist > from pool creation to deletion. >=20 > On Mon, Jul 07, 2025 at 01:13:14PM -0700, Kanchana P Sridhar wrote: >=20 > > +static void acomp_ctx_dealloc(struct crypto_acomp_ctx *acomp_ctx) > > +{ > > + if (IS_ERR_OR_NULL(acomp_ctx)) >=20 > Ugh. >=20 > > + return; > > + > > + if (!IS_ERR_OR_NULL(acomp_ctx->req)) >=20 > Ugh. >=20 > > + acomp_request_free(acomp_ctx->req); > > + > > + if (!IS_ERR_OR_NULL(acomp_ctx->acomp)) >=20 > Ugh. >=20 > > + crypto_free_acomp(acomp_ctx->acomp); > > + > > + kfree(acomp_ctx->buffer); >=20 > Just what are those IS_ERR_OR_NULL about? Is it IS_ERR() or is it NULL? > Either has valid uses, but mixing them is not something you do without a > good reason; there are valid calling conventions that allow all three of > "address of an object", NULL and ERR_PTR(-E...), but that's not something > you do just in case - there should be an explanation of what's going on. I hope my reply to Nhat clarifies and provides some more context. In summary, the IS_ERR_OR_NULL() is preserving existing mainline code in zswap_cpu_comp_dead() in the new acomp_ctx_dealloc(). There is no teardown callback, i.e., zswap_cpu_comp_dead() with this patch series. Thanks, Kanchana