From: "Song, Xiongwei" <Xiongwei.Song@windriver.com>
To: "sxwjean@me.com" <sxwjean@me.com>,
"vbabka@suse.cz" <vbabka@suse.cz>,
"42.hyeyoo@gmail.com" <42.hyeyoo@gmail.com>,
"cl@linux.com" <cl@linux.com>,
"linux-mm@kvack.org" <linux-mm@kvack.org>
Cc: "penberg@kernel.org" <penberg@kernel.org>,
"rientjes@google.com" <rientjes@google.com>,
"iamjoonsoo.kim@lge.com" <iamjoonsoo.kim@lge.com>,
"roman.gushchin@linux.dev" <roman.gushchin@linux.dev>,
"corbet@lwn.net" <corbet@lwn.net>,
"keescook@chromium.org" <keescook@chromium.org>,
"arnd@arndb.de" <arnd@arndb.de>,
"akpm@linux-foundation.org" <akpm@linux-foundation.org>,
"gregkh@linuxfoundation.org" <gregkh@linuxfoundation.org>,
"linux-doc@vger.kernel.org" <linux-doc@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: RE: [PATCH v3 4/4] mm/slub: correct the default value of slub_min_objects in doc
Date: Sat, 9 Dec 2023 13:59:47 +0000 [thread overview]
Message-ID: <PH0PR11MB51928F0D78863B3E76457622EC89A@PH0PR11MB5192.namprd11.prod.outlook.com> (raw)
In-Reply-To: <20231209135203.303508-5-sxwjean@me.com>
Hi Vlastimil,
I didn't change description as you mentioned because slab_min_objects doesn't
save the calculated value based on the number of processors, but the local
variables min_objects doesn't.
Regards,
Xiongwei
> -----Original Message-----
> From: owner-linux-mm@kvack.org <owner-linux-mm@kvack.org> On Behalf Of
> sxwjean@me.com
> Sent: Saturday, December 9, 2023 9:52 PM
> To: vbabka@suse.cz; 42.hyeyoo@gmail.com; cl@linux.com; linux-mm@kvack.org
> Cc: penberg@kernel.org; rientjes@google.com; iamjoonsoo.kim@lge.com;
> roman.gushchin@linux.dev; corbet@lwn.net; keescook@chromium.org; arnd@arndb.de;
> akpm@linux-foundation.org; gregkh@linuxfoundation.org; linux-doc@vger.kernel.org; linux-
> kernel@vger.kernel.org; Song, Xiongwei <Xiongwei.Song@windriver.com>
> Subject: [PATCH v3 4/4] mm/slub: correct the default value of slub_min_objects in doc
>
> From: Xiongwei Song <xiongwei.song@windriver.com>
>
> There is no a value assigned to slub_min_objects by default, it always
> is 0 that is initialized by compiler if no assigned value by command line.
> min_objects is calculated based on processor numbers in calculate_order().
> For more details, see commit 9b2cd506e5f2 ("slub: Calculate min_objects
> based on number of processors.")
>
> Signed-off-by: Xiongwei Song <xiongwei.song@windriver.com>
> ---
> Documentation/mm/slub.rst | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/Documentation/mm/slub.rst b/Documentation/mm/slub.rst
> index 6579a55b7852..56b27f493ba7 100644
> --- a/Documentation/mm/slub.rst
> +++ b/Documentation/mm/slub.rst
> @@ -150,7 +150,7 @@ list_lock once in a while to deal with partial slabs. That overhead is
> governed by the order of the allocation for each slab. The allocations
> can be influenced by kernel parameters:
>
> -.. slab_min_objects=x (default 4)
> +.. slab_min_objects=x (default 0)
> .. slab_min_order=x (default 0)
> .. slab_max_order=x (default 3 (PAGE_ALLOC_COSTLY_ORDER))
>
> --
> 2.34.1
>
next prev parent reply other threads:[~2023-12-09 14:00 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-09 13:51 [PATCH v3 0/4] supplement of slab allocator removal sxwjean
2023-12-09 13:52 ` [PATCH v3 1/4] Documentation: kernel-parameters: remove noaliencache sxwjean
2023-12-11 17:47 ` Jeff Johnson
2023-12-12 13:57 ` Song, Xiongwei
2023-12-09 13:52 ` [PATCH v3 2/4] mm/slub: unify all sl[au]b parameters with "slab_$param" sxwjean
2023-12-09 13:52 ` [PATCH v3 3/4] mm/slub: replace slub_$params with slab_$params in slub.rst sxwjean
2023-12-09 13:52 ` [PATCH v3 4/4] mm/slub: correct the default value of slub_min_objects in doc sxwjean
2023-12-09 13:59 ` Song, Xiongwei [this message]
2023-12-13 11:23 ` Vlastimil Babka
2023-12-14 14:11 ` Song, Xiongwei
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=PH0PR11MB51928F0D78863B3E76457622EC89A@PH0PR11MB5192.namprd11.prod.outlook.com \
--to=xiongwei.song@windriver.com \
--cc=42.hyeyoo@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=arnd@arndb.de \
--cc=cl@linux.com \
--cc=corbet@lwn.net \
--cc=gregkh@linuxfoundation.org \
--cc=iamjoonsoo.kim@lge.com \
--cc=keescook@chromium.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=penberg@kernel.org \
--cc=rientjes@google.com \
--cc=roman.gushchin@linux.dev \
--cc=sxwjean@me.com \
--cc=vbabka@suse.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox