From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6CAF0C4345F for ; Tue, 30 Apr 2024 02:23:15 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 050536B0098; Mon, 29 Apr 2024 22:23:15 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id F1BC06B0099; Mon, 29 Apr 2024 22:23:14 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id D6EF26B009A; Mon, 29 Apr 2024 22:23:14 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id B4F886B0098 for ; Mon, 29 Apr 2024 22:23:14 -0400 (EDT) Received: from smtpin13.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id 701EE4045E for ; Tue, 30 Apr 2024 02:23:13 +0000 (UTC) X-FDA: 82064601066.13.908DEF5 Received: from CO1PR03CU002.outbound.protection.outlook.com (mail-westus2azon11024031.outbound.protection.outlook.com [52.101.46.31]) by imf07.hostedemail.com (Postfix) with ESMTP id AA7EA40023 for ; Tue, 30 Apr 2024 02:23:08 +0000 (UTC) Authentication-Results: imf07.hostedemail.com; dkim=pass header.d=microsoft.com header.s=selector2 header.b=AiylHusS; spf=pass (imf07.hostedemail.com: domain of Steven.French@microsoft.com designates 52.101.46.31 as permitted sender) smtp.mailfrom=Steven.French@microsoft.com; dmarc=pass (policy=reject) header.from=microsoft.com; arc=pass ("microsoft.com:s=arcselector9901:i=1") ARC-Seal: i=2; s=arc-20220608; d=hostedemail.com; t=1714443789; a=rsa-sha256; cv=pass; b=jPgfdUM6sO25eqjZa+gIkviCmEQIl1vg4WxBgOLhE4WYDv9+jJ1H9FwmyndHB9Nr4vNd0l YmswtbcgmUUu6RkR2+bJ+vzaYSBx0SfUidKsFvKVkPCTJ0MEWqT6E3EykIh1aQqlTkTlnZ QVrF1zP7lWZAeA7hkWTwJe8gFvk6SS0= ARC-Authentication-Results: i=2; imf07.hostedemail.com; dkim=pass header.d=microsoft.com header.s=selector2 header.b=AiylHusS; spf=pass (imf07.hostedemail.com: domain of Steven.French@microsoft.com designates 52.101.46.31 as permitted sender) smtp.mailfrom=Steven.French@microsoft.com; dmarc=pass (policy=reject) header.from=microsoft.com; arc=pass ("microsoft.com:s=arcselector9901:i=1") ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1714443789; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=dX06X+SP/gmseQA4JOgOM0Q/NHpN04siQKOreRS9FpY=; b=lFmrLNHiZ9Otp9IJLEorrbWUskPed5HS9+9w2tP5VBOjaMxM3TmZpYN+jruNz52e10Y9kB rru5jHCVAxnf/hPCIasQ0eaC3fJiixLaM3Kzki2lFMwbzfPKoFI+YQRnl13u3x4aA3xHAS DIEPddsf++x+YGcangwOgq0Ep+qpsGs= ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=bMZXNEjca1p82x1ZfNh1oCAXPM5LpSKJordldtkZWvVp0gIrI7qJfM58OoSzOYx0DBjpASjA3sYmdrPPMoIfs7gwM0mvMyT0s0FdrduBiY5SlHeUJBuUwkkVpeHW23+n9KN7Ci6WklcwNyyhyKCMYVpc3eZ+k9e84LN3qQSC6Yo/XaF5lPK5I2u2AodV++ap3Y+bFDwNqRPwWpa7nsHxxzYjF7rJjRs+kwA8B+/X7BwzSCwjHHhkR4BNJKrZXI+Cbfqmi1q6PYPVXGqPTzlMcBXBX8ATJWQzkfKg/Q0Mgx/vl7eKwf+1aWK34P702opi51oRbwLzNBEJo5IpGmS5mg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=dX06X+SP/gmseQA4JOgOM0Q/NHpN04siQKOreRS9FpY=; b=Ab8G8Pzbci9EheEVNzwzsSrDNYnQCdNhEll7rBNXRnINGeWjnCnc2hBsQUXefrGh/bw2zgCteWtMq0h8tHmTJmWihpBPSlvXizbnKwJekuYkWIfTZT9OKOoYT3/q7vxstSMsC+Ycj4qxLwwn1++6ddN1HQxyIB4nxUcazfZwVKOSithuzDvGOygKdYI7/p/BrKnANfaU4jzUhC7BKis9nsKnu+Yy49X9OfuqlaVX0NI4DobcBvzSNr5srfciHFcieFGtc2Dkyumr5bDyBPMhB82uWj82Jq3XuPKxiJ1ZOifbggPb/ASA9BAZyeDDOm7I/9GinlWlIFswMtTJttKDUQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=microsoft.com; dmarc=pass action=none header.from=microsoft.com; dkim=pass header.d=microsoft.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=dX06X+SP/gmseQA4JOgOM0Q/NHpN04siQKOreRS9FpY=; b=AiylHusS2epdjW58OuIEDz+/PC9q9yKADEKzzkWqLJ6m2vTn2vGe8Ao0HQTaqEbDuvtsR8NO4GfhETk9nJx3n47I1QIzQ55hm1j02h5ZDbEoHI807pJuOmYzZsSx1zb01rMtVDhQ634r2gGLzDXWMIbEJ35Kd3W50o6wPEgHEYo= Received: from MW4PR21MB1890.namprd21.prod.outlook.com (2603:10b6:303:64::10) by DM6PR21MB1433.namprd21.prod.outlook.com (2603:10b6:5:251::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7544.23; Tue, 30 Apr 2024 02:23:04 +0000 Received: from MW4PR21MB1890.namprd21.prod.outlook.com ([fe80::25ce:8539:f7de:dee3]) by MW4PR21MB1890.namprd21.prod.outlook.com ([fe80::25ce:8539:f7de:dee3%4]) with mapi id 15.20.7544.019; Tue, 30 Apr 2024 02:23:04 +0000 From: Steven French To: Matthew Wilcox CC: Kairui Song , "linux-mm@kvack.org" , Andrew Morton , "Huang, Ying" , Chris Li , Barry Song , Ryan Roberts , Neil Brown , Minchan Kim , Hugh Dickins , David Hildenbrand , Yosry Ahmed , "linux-fsdevel@vger.kernel.org" , "linux-kernel@vger.kernel.org" , Namjae Jeon , "Paulo Alcantara (SUSE)" , Shyam Prasad , Bharath S M Subject: RE: [EXTERNAL] [PATCH v3 05/12] cifs: drop usage of page_file_offset Thread-Topic: [EXTERNAL] [PATCH v3 05/12] cifs: drop usage of page_file_offset Thread-Index: AQHammhzJrsE0Xg8qUSGz+RQruipXLF/r7BQgAACgwCAAGNMwA== Date: Tue, 30 Apr 2024 02:23:03 +0000 Message-ID: References: <20240429190500.30979-1-ryncsn@gmail.com> <20240429190500.30979-6-ryncsn@gmail.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: msip_labels: MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_ActionId=ba2b31bb-3b66-4722-9850-cee5dbb9d317;MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_ContentBits=0;MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_Enabled=true;MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_Method=Standard;MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_Name=Internal;MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_SetDate=2024-04-30T02:21:49Z;MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_SiteId=72f988bf-86f1-41af-91ab-2d7cd011db47; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: MW4PR21MB1890:EE_|DM6PR21MB1433:EE_ x-ms-office365-filtering-correlation-id: a24f0d80-af0d-4dd0-85f9-08dc68bc770c x-ld-processed: 72f988bf-86f1-41af-91ab-2d7cd011db47,ExtAddr x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0;ARA:13230031|1800799015|376005|366007|7416005|38070700009; x-microsoft-antispam-message-info: =?us-ascii?Q?9sbvfxydr4pA3H/VFwvrCeD5zU57D/01fe1qfCVGgazl+BeCrmq0K+ovefDh?= =?us-ascii?Q?5qIe/WmA48HxgDJv3WUuH4oq0yYgDyD19/BUKJosY8hjK5no6/JxKLTODlYo?= =?us-ascii?Q?uMuH8gkb2PsEkAtxo0zXYBJQWLL+7iGoNvhpgwN1auzyFaNWnzxDkns09wjU?= =?us-ascii?Q?wWOy7qH5jX8J1SQvDt4K1r65hceTlxZ2LyrL1JqzssneLuVfeRg0/nK2Y9LZ?= =?us-ascii?Q?SM724ySx9U6rKdLHL40Rqllb93BnE46ShJGkdILH6x5McAWQDWgeKdOiK1uO?= =?us-ascii?Q?PUAfj0sXf9MiAikHY//Cr04W8d0yxjre/U90P7SuH0i/NAwe4qknoCRT6nIo?= =?us-ascii?Q?6BTJJFW8Ex9io9VG3jQJRuM5wEswlFDC5iovdM21NPrnwbPHBBN8yhNk838I?= =?us-ascii?Q?3jXi58ITm23+QvrLwNryibzK+/DrpIH0BqiU1InSISWvzsZmZZpkBNB1eKpQ?= =?us-ascii?Q?6uBR3LKO+lgbqzS2qB44dxT1DXzYQ0dNTqrotLrS5y+cRnbhr4xm2jsgJ0Jl?= =?us-ascii?Q?iGbINYN85w+Ps6vL3tw2egIS4TuMQWonF9yn+aLet33PMRQYX1idKfJ1t368?= =?us-ascii?Q?O4W8KZEbJ0JWzuC0El+WtOJGbWSXMASmQFHnRyxacd8oq+lIFUnWPw9Mmmkr?= =?us-ascii?Q?rzChPo3vEcWK+z0SwvFn+IWc8eP7GpagEgoxzg6ReEQlElZrz9iio0lkA5Vo?= =?us-ascii?Q?3zdy9GH/S7P8BlcuPq4oYamA+Xj0vjsrAAyeBK4zD6YwS9viak57avtVWGpc?= =?us-ascii?Q?m+MaSnXCoVglG7LZSARcmqa8BTtJL6Fiq8oGeIL5/OFleE/27ymcQIfMj6fb?= =?us-ascii?Q?309HUrsjN70Hc1JaL+EsAjRPYM/BDv79Teyaa4M2tXYnPsCHwOJyTh6Pb5jU?= =?us-ascii?Q?sK7ieDgLydWRx0wSHkeLe3BnjzqB7+tIi07psVNV21FzXUByn/NZK9FbXnmu?= =?us-ascii?Q?5cYB3QX3u/AoKFRxWlgRB3VZvUKuHr5LLtqYgM5cgb8XD0KLuZGqnRNDEd1h?= =?us-ascii?Q?MBWHFS7TKD5dA/XBTFy58MstXblMiqC317j76fpMl2o5C7DVQ/eq8qCpSkQG?= =?us-ascii?Q?mNRb8vewBVO/Ntl3ifEK0bDRaJUvuStsEzQgNIHFg3SX+C2NBbsJGhrKu0q5?= =?us-ascii?Q?q7ocYsBc/9m7veY1EJ22ziw+RHvtO5GLpRQvwiQn7UIzLwxchU8IncoXPXuN?= =?us-ascii?Q?ug/Mc+T42YZ2VA6frH8JEe9KP8LgY3qoz0BiKYgtz4UAxL4haNnm3EW1sG19?= =?us-ascii?Q?wVn3WNujUAk9sPmve37tMYb7kGkxf8XQ1A+zxK8D+wRzz5r5enOHZFErm1+3?= =?us-ascii?Q?sSctM1ZYvPp3Fhs02T3noGB1BRcbOvfHb0iBn7ILqjjZYw=3D=3D?= x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:MW4PR21MB1890.namprd21.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230031)(1800799015)(376005)(366007)(7416005)(38070700009);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?yEP4ejmgeBzbLeIiQ1DN53JhrREPScNe4D7Gq73BOrhjeW/RWmggN+K+6ogq?= =?us-ascii?Q?XTEYo2K2y7fd8FLOpcdvzM/07+JHDxWU77QbYMMbUFt49nQvCkp9FfNw3AvK?= =?us-ascii?Q?JcflHgBvXLRoE9qxOE3PFKjzhBZHwCzK17cccYfodz1kREHNVAySu8OmqZ1u?= =?us-ascii?Q?A2TQA0rJfrS4x6ZIAnT5X5p/QgbzqnyyoJiKPleyfsf9kXtbf9yBxNMCn9Tv?= =?us-ascii?Q?5GHpSQ8V/Tf40pMjnyiyhaZCJAjUCoTlMB32uqYDJNVVUWu5w3pXsUh72pIb?= =?us-ascii?Q?snipvHmfu3QnBwFCFMaQ+Ului8N0tCdDt5mQuhVGDqkkCMIrREYdIvUVrwj6?= =?us-ascii?Q?Ybqz19765JeF8tALmvsm6p6a6Zn3dfdpJX7OfBD2lOlPnXL51yzlfhLe4lmS?= =?us-ascii?Q?gK8CcMF3p4lRH/HOIu4hNI593vPcw/RFYmZ38umcpjI9umFvtEDw0u08mJ/q?= =?us-ascii?Q?Hm9KT80+csQuVI5aKAN8N9nt00C9wqrNeWVElMGVujVXVyi7K7ZEH8PCze2E?= =?us-ascii?Q?4uX4UCsPK8jtotpRKWRAKf8J9Z796mV/8264yPIjRgRVdg4m+3p2SZIEiFbV?= =?us-ascii?Q?cinOM8xzQY4RjXlRJYGzrZpaGwfUeB8Bzem0i+Xsbjk075cSAFC1BroDiKRV?= =?us-ascii?Q?kylTs1kdZZSKg9ejMQAxqfByXMPp2FuyL4JoSo+ElTko69LVjpkPerVO34kq?= =?us-ascii?Q?CQQ3A3NNTt9aB9NPjk42jYl6BGussIucEX24GSg9i29wfrjdoo93zHadHsK8?= =?us-ascii?Q?ZW3XqOgHweombGa+HlrrlmflA70PPQuTMyUfLeegKcTxoG7+MvmNBK3dpibC?= =?us-ascii?Q?RE7S8qS0VVFzq4JoRLEx8ctRSCbPWzL2vxPiEGdt2bU0i2wh7hk8/4fhpO7n?= =?us-ascii?Q?IT/o1QNkgRL9YGgy6bAY39roVqwSPd0NmMO27GBzLQMpsQmgw8g2+cv59HHY?= =?us-ascii?Q?jwZSeG5Szcjyr6BhQvcVd+CUn0GvnrAisJ85j22Rsy4MEzJR5EX3uVSSr7Ax?= =?us-ascii?Q?Zq1uofXv1KnDj6zm71vJQF1tClUeI7iAv20qhg/loE+3RBQ0qMLrk5OGkWQy?= =?us-ascii?Q?tv7BGyJfRnb72rSYkBcu9cpCjMMBE5wZQ3I/gz5wJjwSzftz3VmLs78dhexu?= =?us-ascii?Q?4VfF/T4qkdur8IF88+1vbC3NZj4bAFpe3vWg5lING+cNdZGSYq3FUWDnDL50?= =?us-ascii?Q?lvpxIe1Tq1ql94t17P5gV1GJy9Ze96yU63YA4snrEZKWjDGqsUgkzcllUipi?= =?us-ascii?Q?tfGgESZfRQKqaipd16Jef6kORW8JqiUgruIZjEjPjKRzbb0vQn7ZGrDlQaz8?= =?us-ascii?Q?YUPMysp2boXFxhAr9fnVCjwv9TZ6kBcgF/LG4bKVg4DL5HVUJzliPgpVQuiW?= =?us-ascii?Q?2KETRDvY0phG4ZZ6XEdRF+BCVMUG01Pf99RlACZxqrEGX6dX+bsnUqqIfsf6?= =?us-ascii?Q?9SnJZQbqLJ3ynmcATuJck2nmJ8vDE14jOJiZflFyIeHPJ66FMxyqWGKY3fpz?= =?us-ascii?Q?qAPOuSsfuHxZnfxkxS/lhu3EiNEKAb8cmEMEQ5jbB75qu37DvE1nsCHccN8V?= =?us-ascii?Q?+ZISyuYlbQejuT7oi53Z95Wchrfq6gZJpSPs/+rtqk1B98sfx2bmcRT9uW/3?= =?us-ascii?Q?oU7h/Vc7xgPMMAU5BFvf9J27QiQ2boVqFoKWsm5SFWRA?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: microsoft.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: MW4PR21MB1890.namprd21.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: a24f0d80-af0d-4dd0-85f9-08dc68bc770c X-MS-Exchange-CrossTenant-originalarrivaltime: 30 Apr 2024 02:23:03.9703 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 72f988bf-86f1-41af-91ab-2d7cd011db47 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: PN42rXfZ0r4TGA1gs67yqlbbPq++q59McFZaOQUzpY/5lcszQIA87/KkBSiLNkulgfbvUFJNMf9cnhlt5fWXVw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR21MB1433 X-Stat-Signature: b3oppnt9ynioe6qrm85zuwt6gebr3mhu X-Rspam-User: X-Rspamd-Server: rspam02 X-Rspamd-Queue-Id: AA7EA40023 X-HE-Tag: 1714443788-68814 X-HE-Meta: U2FsdGVkX1++ITQDNvaUOTZMy36erMG2Ig2K3tmB6/XrvV+3AcycSyvoZu0e2CdUnVldp5vPobrMT79e99V1kJdczW5d9M9HhHbuADabVCurTe0+LmnOEzHA3B4lqsLbubH5X6nFr52nTnMObRmtD9u1Ll1//8PiDF53CaIlQpE7DPw19tEETzBw3D5xLZ20sjF4ubb1GMgjymp64rUReXsbXRwu5UldOGUNZHRq488hc428WZmv9KHuR1NzKoonDg/q8uN0vaxFnLfpDReCGwIJfJ+ea6ULErvi75jBnnEHbi28rO4YwKEXtN0EOLNV0vQyT9gCgDZC4i2S1s94l3dlrRM3rCRGMBksj/NYXYFlnhqIVZHKVPojZ4JmZ5QIfNqGeQsnq0rqN9LX+5n5qq2cLZvnC4hmGTY9nJvrqQi6x2QaWrehEwJ9dS+RJGYMPk8JVqRYt2NWlR8ihAAkvf3BgrQStJljtaRa7A3whU8/qseUe+msFYGTQI7dQBD5e50xdK6VXjElnbw/QSsuUXERS6yCkn+TTeEbWZ600XDzCylQDCex+/bjLPjoTvG2H0q4Mkp6fzFIUEDVxmlPXMldA4V6gxMGV/KgZFJnp8fcjWgg+w9ongg6Xzr2YwwzIkNIt1dfxGnAnyUo0BsZEsM/9PMr+9kep+qWHYXBCzwlvt6JXr8EveBj3vUhjGzNwjqBJidsI8pb4ZZqYG2PPejbXIPUvicixNzdZnWQRS9xy8eRc33fQTC5UaHKrFwASthfz8e4OsvdHnYb58O6GnbPO/Vcem3wVoOpF/fuq9KHkWqz7h5qAR8Yc1cpqEbBEPeWYE3gDmldF47W1BXi40kzs+rGPAYUQ9Buc9Py0bT+Z5U/0127/LE8LalIwqL2m/k4iStYqwUQXFCuiBuhJUWkBvBcCHEboiEFybGxaytTv3Pu2BTafnPVx09aZiPKgbFeWVxfHT+ltdyGwWR kd61J1mS F1BVzTLgvdAYYx/n7OHLsBbMS5vHl6c+wSR8YgwkQa4PzRCwKy3ZM1U/+dysJuCfB7ZKx+taclb+3v0nnO1tgHDta0y8ry4wwWjQ3O7w5W2bB2zYzU8Kp6nro22GHteEIlyv6VMdibesjgGl5Nn4dj5K0kkAFy+YQf84CzaFA7+/QrX4f3s2J3rBZj0EqPduIwjGB3Sl3hJEDnOYLo8lX20RuD1FHmGZ9aYoZ+/82xtbwulwG0CqGRVEGFQ+FRi+tUigtgT7SQEwIjkjsr6ZSYkziNezH9mZA0JwU+l4pMTF/5NhgAE5FvlifueHGpKP3/4HTNtuXSlFhl4HDCRUXTzWfsor705Gi1AqHbXqemewBD2Jl8J7MPRi6Cuc2swBX6rahF5QYylvkIaVZxf/HhEvCxUDiIXu4AaAhcfHEkCHCZutIxZryljT+hqnLEDepbjmds7t4tSfPm5yIS0MU4qVRL/vH3EaFrsPBQOlZ6R6T4e0xM8KCEH1kMk/hWCJtT7KNOtvPEM2PPYDDM+sfCojvb0H98P9ZhubSkKdKN4UB7AqLKUDCkMJ0v87tQIO8nd+gVLtPTvafKuDkkJps9n4+VO8MSZQHBa3jIr10OP31oM/bI96fjPzgWfW2Sf6gbHvLpNwlH89nNIWEvLhCQyXYt8xrh7BowsKu3SABQ3Nbr+7Qb5Zgwziz4d5ypxB0JV9CCfOh4X02uhSLqZm2BQM1AmsrE38scDxQzkGIgbWkmnYunyv2RM8ebBurIY3tk3SvbXvLSN6e42gTdGu3IPpIoTpESFzW6gx/l7MUXHqD8XFDgXiKC59Dlv6NsQkoNuI6pqF0h6z7llj9P0hWgrd/B1UEqyxza28Hcq3TGyVdO3geL/Iv4VYsyiWrIe0mz9gwog5g4rPfdi5my9rETuORdZ6ravZo1nSiDh1yxEAVmtk= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Makes sense - I will try to look at this fixing the swapon and reading from= swap over smb3.1.1 mounts in the next few weeks, but if you have a good ex= ample of sample code (from one of the other FS that does this well) that wo= uld help. -----Original Message----- From: Matthew Wilcox =20 Sent: Monday, April 29, 2024 3:26 PM To: Steven French Cc: Kairui Song ; linux-mm@kvack.org; Andrew Morton ; Huang, Ying ; Chris Li ; Barry Song ; Ryan Roberts ; Neil Brown ; Minchan Kim = ; Hugh Dickins ; David Hildenbrand ; Yo= sry Ahmed ; linux-fsdevel@vger.kernel.org; linux-ker= nel@vger.kernel.org; Namjae Jeon ; Paulo Alcantara (= SUSE) ; Shyam Prasad ; Bharat= h S M Subject: Re: [EXTERNAL] [PATCH v3 05/12] cifs: drop usage of page_file_offs= et On Mon, Apr 29, 2024 at 08:19:31PM +0000, Steven French wrote: > Wouldn't this make it harder to fix the regression when swap file support= was temporarily removed from cifs.ko (due to the folio migration)? I was= hoping to come back to fixing swapfile support for cifs.ko in 6.10-rc (whi= ch used to pass the various xfstests for this but code got removed with fol= ios/netfs changes). It was neither the folio conversion nor the netfs conversion which removed = the claim of swap support from cifs, but NeilBrown's introduction of ->swap= _rw. In commit e1209d3a7a67 he claims that Only two filesystems set SWP_FS_OPS: - cifs sets the flag, but ->direct_IO always fails so swap cannot work. - nfs sets the flag, but ->direct_IO calls generic_write_checks() which has failed on swap files for several releases. As I recall the xfstests only checked that swapon/swapoff works; they don't= actually test that writing to swap and reading back from it work.