From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2C0B0C432C3 for ; Thu, 28 Nov 2019 08:02:24 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id D7E6521771 for ; Thu, 28 Nov 2019 08:02:23 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=vmware.com header.i=@vmware.com header.b="W+KaMDK7" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org D7E6521771 Authentication-Results: mail.kernel.org; dmarc=fail (p=quarantine dis=none) header.from=vmware.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 530A46B0507; Thu, 28 Nov 2019 03:02:23 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 4BAD86B0508; Thu, 28 Nov 2019 03:02:23 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 35B7A6B0509; Thu, 28 Nov 2019 03:02:23 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0158.hostedemail.com [216.40.44.158]) by kanga.kvack.org (Postfix) with ESMTP id 1C6CA6B0507 for ; Thu, 28 Nov 2019 03:02:23 -0500 (EST) Received: from smtpin06.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay03.hostedemail.com (Postfix) with SMTP id C56E282499A8 for ; Thu, 28 Nov 2019 08:02:22 +0000 (UTC) X-FDA: 76204943724.06.prose55_14a9b70381035 X-HE-Tag: prose55_14a9b70381035 X-Filterd-Recvd-Size: 7034 Received: from NAM04-CO1-obe.outbound.protection.outlook.com (mail-eopbgr690085.outbound.protection.outlook.com [40.107.69.85]) by imf19.hostedemail.com (Postfix) with ESMTP for ; Thu, 28 Nov 2019 08:02:21 +0000 (UTC) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=M/6X1GJBEeC7+whfQEowb+v72Pmaiby9+ca0BWinNtNK4Zzrzp4zYKHBXOv49FqxTXSnpgZurMfzedlzlV8guNMwOwe7YNrKO8lTlfglHSn0ZHD9ATL/lkAYyHRn3fcjeDZsDECOhViVmO087KcsxNjgw2r3m9BriHGxbu8JdaDtDpcsVuqEeI0kDLuxY9+s577FrWebLcVhaqQ13NdCYMGEeZdFgDko3n84+x5VFEJ71wQoox9sMjzN40saj+2bNmE8gO3EfBzcStMC91uz9PVR0i7gvpPFM2aRBrh5DsgkVmerSH8TUIidoun2fSuIayd7c2quHXZhSNpSpO+zvA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=7UfAHjMeBYFMwiwe/nLzFwJqwu0w5BD61k6bcS6y3GY=; b=UDQfxf8kohpweUBIPjEVXhJVOro6UeJmZFPa1ZCALEc4WLWtRw7XMGBvJi/ioI/4KaFyOZZ4MPjuLfTxw2KlC3h0Mt8VmO/K8c6NNyVdP/ysOaFVXahPAHrPgvQREU0oHjJMDTS081LXm0rUS0Rfc9fD77snVhAwbgvPMaZ09jfAAz4MQRCzC9eBIMnemyVCrMGKBvXEgrSZYwAb7jNyE6DU0V4vOZvVFsk8gvxz/8yRGWtrND4x09NK2EpDm2LXOXc4Qt+sotQinCgCCrIWHDSzXytIywiVpQYvi7NwtJvKEo0bH7jCM+UjvERl7DWUsnuKGKaD+qOUJhqx/70Esg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=vmware.com; dmarc=pass action=none header.from=vmware.com; dkim=pass header.d=vmware.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=vmware.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=7UfAHjMeBYFMwiwe/nLzFwJqwu0w5BD61k6bcS6y3GY=; b=W+KaMDK7qloT9i4YXpyGf7TGdwpJctUxzocMN8mBV1FOD80NeYfb5sFkYi3w16uAXwUs2yv20cHAICwM+gp+wQUcVIYdrsH8W4Yp8vVvKSbrGrtgJ1uWaPuHZMLNrGjy/K39L68hysLy2diK5oQ9Ayag0YFnK4CSr+r+U5RPqAQ= Received: from MN2PR05MB6141.namprd05.prod.outlook.com (20.178.241.217) by MN2PR05MB6125.namprd05.prod.outlook.com (20.178.242.152) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2495.13; Thu, 28 Nov 2019 08:02:16 +0000 Received: from MN2PR05MB6141.namprd05.prod.outlook.com ([fe80::611e:6a6b:9109:5aa8]) by MN2PR05MB6141.namprd05.prod.outlook.com ([fe80::611e:6a6b:9109:5aa8%7]) with mapi id 15.20.2495.014; Thu, 28 Nov 2019 08:02:16 +0000 From: Thomas Hellstrom To: "hch@lst.de" CC: "thomas.lendacky@amd.com" , "linux-kernel@vger.kernel.org" , "christian.koenig@amd.com" , "linux-mm@kvack.org" , "iommu@lists.linux-foundation.org" , Konrad Rzeszutek Wilk Subject: Re: [PATCH 2/2] dma-mapping: force unencryped devices are always addressing limited Thread-Topic: [PATCH 2/2] dma-mapping: force unencryped devices are always addressing limited Thread-Index: AQHVpTCUSCVjXh+W+0SSCl6TSmyYRg== Date: Thu, 28 Nov 2019 08:02:16 +0000 Message-ID: References: <20191127144006.25998-1-hch@lst.de> <20191127144006.25998-3-hch@lst.de> <20191128075153.GD20659@lst.de> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=thellstrom@vmware.com; x-originating-ip: [155.4.205.35] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: b3653bef-8f4f-40f5-577d-08d773d94934 x-ms-traffictypediagnostic: MN2PR05MB6125: x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:6790; x-forefront-prvs: 0235CBE7D0 x-forefront-antispam-report: SFV:NSPM;SFS:(10009020)(4636009)(396003)(346002)(376002)(136003)(366004)(39860400002)(189003)(199004)(81156014)(66946007)(256004)(54906003)(6436002)(186003)(9686003)(55016002)(6916009)(14454004)(99286004)(305945005)(8936002)(8676002)(1730700003)(2906002)(14444005)(81166006)(86362001)(7736002)(76176011)(6246003)(52536014)(2351001)(7696005)(478600001)(74316002)(5640700003)(25786009)(4326008)(5660300002)(66476007)(33656002)(3846002)(316002)(66556008)(91956017)(76116006)(66066001)(71200400001)(102836004)(6116002)(64756008)(66446008)(71190400001)(26005)(229853002)(4744005)(53546011)(6506007)(446003)(2501003);DIR:OUT;SFP:1101;SCL:1;SRVR:MN2PR05MB6125;H:MN2PR05MB6141.namprd05.prod.outlook.com;FPR:;SPF:None;LANG:en;PTR:InfoNoRecords;MX:1;A:1; received-spf: None (protection.outlook.com: vmware.com does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: ymrhfljteewxg0TBmIjfZpbvMt2RCn2o5CxO3NYrnP71+UjYCNkCJzEyEki2awOohyBk56K7D45O0qHOyKqT7DZkd4ebMJeVRxjEjwGIWvK6SPLAoemFRUrdBSxZMt/uqxZIoSIy/BNvJE06OuCMOTMhC86oqvI0Pc+Ejsi13VULW6hf4h7bNhrdt5aiM8qeiPSfPFX5Z6JmNFhxLYsR+65/fojlk2q9LplgC2qgxpSNqfUUpqRTaNoWI00Ax2t8n1sWqEfWMQWMgnmg2z6cOh4l9ERNTECHTkgfScyfZxFl8kULetmBZsbvUNTMbust8ObvnO1TU9hRVmLKu2+bLh4aNeGxmzK1Ztp5dDGfLf4H/B5erTJtTtWGZMel9DrSiHBeaMaFBq4IaSsPslU5xvUX6RSBwJjlM4ENd0+wpO+7yz4kiZTKai7yFSf4tiOk x-ms-exchange-transport-forked: True Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: vmware.com X-MS-Exchange-CrossTenant-Network-Message-Id: b3653bef-8f4f-40f5-577d-08d773d94934 X-MS-Exchange-CrossTenant-originalarrivaltime: 28 Nov 2019 08:02:16.8369 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: b39138ca-3cee-4b4a-a4d6-cd83d9dd62f0 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: 0MmJ5kec9vsnBAnVI86Nno4Bb1VP2+Y5sxvpn1qsuJnmy8ZA1ZWq5DFS7zUqaga3UygpOGMp3DIFnEcOKAIa6w== X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR05MB6125 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 11/28/19 8:51 AM, hch@lst.de wrote:=0A= > On Wed, Nov 27, 2019 at 06:22:57PM +0000, Thomas Hellstrom wrote:=0A= >>> bool dma_addressing_limited(struct device *dev)=0A= >>> {=0A= >>> + if (force_dma_unencrypted(dev))=0A= >>> + return true;=0A= >>> return min_not_zero(dma_get_mask(dev), dev->bus_dma_limit) <=0A= >>> dma_get_required_mask(dev);=0A= >>> }=0A= >> Any chance to have the case=0A= >>=0A= >> (swiotlb_force =3D=3D SWIOTLB_FORCE)=0A= >>=0A= >> also included?=0A= > We have a hard time handling that in generic code. Do we have any=0A= > good use case for SWIOTLB_FORCE not that we have force_dma_unencrypted?= =0A= > I'd love to be able to get rid of it..=0A= >=0A= IIRC the justification for it is debugging. Drivers that don't do=0A= syncing correctly or have incorrect assumptions of initialization of DMA=0A= memory will not work properly when SWIOTLB is forced. We recently found=0A= a vmw_pvscsi device flaw that way...=0A= =0A= /Thomas=0A= =0A= =0A= =0A=