RE: udmabuf: check_memfd_seals() is racy

["Kasireddy, Vivek" <vivek.kasireddy@intel.com>]

Hi Jann, Julian,

> Subject: udmabuf: check_memfd_seals() is racy
> 
> Hi!
> 
> Julian Orth reported at
> https://bugzilla.kernel.org/show_bug.cgi?id=219106 that
Thank you for reporting this bug. 

> udmabuf_create() checks for F_SEAL_WRITE in a racy way, so a udmabuf
> can end up holding references to pages in a write-sealed memfd, which
> theoretically breaks one of the security properties of memfd sealing.
> See also the discussion starting at
> <https://lore.kernel.org/linux-
> mm/CAHijbEV6wtTQy01djSfWBJksq4AEoZ=KYUsaKEKNSXbTTSM-
> Ww@mail.gmail.com/>.
AFAICS, this problem does not adversely affect the main user of udmabuf driver
(Qemu) given that Qemu adds F_SEAL_SEAL while creating the memfd but
I can see how other users of udmabuf driver might be impacted by this issue.

> 
> I think one possible correct pattern would be something like:
> 
> mapping_map_writable() [with error bailout]
> check seals with F_GET_SEALS
> udmabuf_pin_folios()
> mapping_unmap_writable()
I believe this should probably work as mapping_map_writable() would prevent
F_SEAL_WRITE from getting added later. Do you plan to send a patch to fix
this issue in udmabuf driver?

Thanks,
Vivek