From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id AEEE3CD37BB for ; Wed, 4 Sep 2024 01:06:44 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 3F8D78D0205; Tue, 3 Sep 2024 21:06:44 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 3556D8D01E4; Tue, 3 Sep 2024 21:06:44 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 1A8DB8D0205; Tue, 3 Sep 2024 21:06:44 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id EF8DA8D01E4 for ; Tue, 3 Sep 2024 21:06:43 -0400 (EDT) Received: from smtpin25.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id 6254540ABE for ; Wed, 4 Sep 2024 01:06:43 +0000 (UTC) X-FDA: 82525265886.25.51CFC4A Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.13]) by imf26.hostedemail.com (Postfix) with ESMTP id 9F05F140007 for ; Wed, 4 Sep 2024 01:06:39 +0000 (UTC) Authentication-Results: imf26.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=Awy+MOiB; spf=pass (imf26.hostedemail.com: domain of vivek.kasireddy@intel.com designates 192.198.163.13 as permitted sender) smtp.mailfrom=vivek.kasireddy@intel.com; dmarc=pass (policy=none) header.from=intel.com; arc=pass ("microsoft.com:s=arcselector10001:i=1") ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1725411873; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=UlfH70D6UGeIh2AYQs5awKB4LKnRyPg/C5jMhoDjwco=; b=acspyZ47rN17zJI+HJB3caqV8UjV3mtMLE8+eSucLo3ZflLleJlN1fu/whTiLrjyPG6d1s bLtOQxH60dMh9rEp6ZNv2gLEa1meCaFMiJVTKmc71aMFPmag+6Ig9MiUs8hGwoHWxiSxi+ qzbLcuu3XXQHQTSHeIlkAfwPRbZIP/w= ARC-Authentication-Results: i=2; imf26.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=Awy+MOiB; spf=pass (imf26.hostedemail.com: domain of vivek.kasireddy@intel.com designates 192.198.163.13 as permitted sender) smtp.mailfrom=vivek.kasireddy@intel.com; dmarc=pass (policy=none) header.from=intel.com; arc=pass ("microsoft.com:s=arcselector10001:i=1") ARC-Seal: i=2; s=arc-20220608; d=hostedemail.com; t=1725411873; a=rsa-sha256; cv=pass; b=bEhGBzJ13EM+c5ilAx806qn+TJZNNwnDjH6An9ToD3KW3OjdShUZ7sCzVntiibCA6DKNII xmaiuwE9zvwIlJl7uTXZ9luswfeYN6Px+iNZSdLHO4NRW1UWBCWeSts7DBm08TqfuJVFiI +gWr2xGlZzculE+y+vMeL2Mo/MWiF8c= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1725411999; x=1756947999; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=CrVtjSHwc9lmva9koDuqa1iqLNocN73tzVZiEJH++Uo=; b=Awy+MOiBbpvE+mOFjVTab6Y7MSYKnA9PVfBBGgTvHlizHB1d0JdxWtk5 RjGTIDcsoceGjJZjcMLoZf8BkMtqCixDVK+ywlH9HLUo5wmWr0x25FoPt 4LT6tD4N24GNVdI0NLVmVYz9vv4g/yrw+W9tR1LMnGX60bfFa+fKLaiK8 n26OtsV9uRgXTLFUKhEeE25LYCF/mk+yTsOASKMebMQMAS69pSgg+6Olc fRgTMYg7TwvqM25HTIXBofphB3XZh8bmpNuumCc2oWCNEq6o9UYu8MT+q E+wxIpvtVpLuTLd27hX9QopmpcDwmWSvreMLN0GLDcQDcjZewOTDHrnph A==; X-CSE-ConnectionGUID: SB7uCN1PRICM6mT7xaUTiA== X-CSE-MsgGUID: 1QRqvbkLQQKHLWRbLX6ZiQ== X-IronPort-AV: E=McAfee;i="6700,10204,11184"; a="26959609" X-IronPort-AV: E=Sophos;i="6.10,200,1719903600"; d="scan'208";a="26959609" Received: from orviesa001.jf.intel.com ([10.64.159.141]) by fmvoesa107.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 03 Sep 2024 18:06:38 -0700 X-CSE-ConnectionGUID: v4K11ojtTFGXaE2O/AFtPQ== X-CSE-MsgGUID: K1Iiso8pT/28LhVXmeqmAw== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.10,200,1719903600"; d="scan'208";a="102506261" Received: from fmsmsx601.amr.corp.intel.com ([10.18.126.81]) by orviesa001.jf.intel.com with ESMTP/TLS/AES256-GCM-SHA384; 03 Sep 2024 18:06:38 -0700 Received: from fmsmsx610.amr.corp.intel.com (10.18.126.90) by fmsmsx601.amr.corp.intel.com (10.18.126.81) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.39; Tue, 3 Sep 2024 18:06:37 -0700 Received: from fmsedg601.ED.cps.intel.com (10.1.192.135) by fmsmsx610.amr.corp.intel.com (10.18.126.90) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.39 via Frontend Transport; Tue, 3 Sep 2024 18:06:37 -0700 Received: from NAM02-SN1-obe.outbound.protection.outlook.com (104.47.57.41) by edgegateway.intel.com (192.55.55.70) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.39; Tue, 3 Sep 2024 18:06:35 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=EqCwJGkjmyQd76kEqQk8ao+nxGvhluxUq+a5CLLR0jNowzrNNWSOjKpJJt05cOwCqvww6Tp20XJwdSJYCKNBaE7LbVhWzTIYz0LKR5B3BiZsLuUFDxXunTaqi/ddK/ccI4/MuU+8SDwTs9GHa8DBN/5+7/Odzzz6fdInbuf899Dw8M9EBxM2ukAm44uw54k8uGO8p6mXUkjurdBxYu0i320wLh8cjzh55D5LGpgTzhvM3j6jAKQDL0+hpBt3kJV/VvpSdK25ogBR220dwBWCYAsJ2k5y0hAEVpi33NtwsVdvDU1xU3C7MNtp9M72A8uhThW+4KSGKvQEy5NM7Qgvew== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=UlfH70D6UGeIh2AYQs5awKB4LKnRyPg/C5jMhoDjwco=; b=bXt3XKZUbv54aDdZym3zCJ5qccyR3Dhfzh/G7JmfD/HLinNEHZScCvnv88zD3YP404eR2XmrhQQ4Nx4zoK1c8uGwTJ/arso4iCDHkVrBGhLZhF9SE3VoquOvAVh47FD9fRcxw2id9tyzZw74cjdD7zJszNbRkduaJwXGg+JW8UBcES606isu2QEwu6KaQLQ7qdRlAL+EQZkJThO+72ycGUyFBQSJlZaX8WzvKjx7Y6fnrrG0vBAKfj4/W9uBCCc/Lgbid1XdF4fj+IxK5TXyFY67TXr9QG5yO1T/LI6oRfwYYQbWChRCq8HC/R/v5Bev2ampWGu4FMVSX22ox9TMaQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from IA0PR11MB7185.namprd11.prod.outlook.com (2603:10b6:208:432::20) by CH3PR11MB8548.namprd11.prod.outlook.com (2603:10b6:610:1ba::5) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7918.23; Wed, 4 Sep 2024 01:06:34 +0000 Received: from IA0PR11MB7185.namprd11.prod.outlook.com ([fe80::dd3b:ce77:841a:722b]) by IA0PR11MB7185.namprd11.prod.outlook.com ([fe80::dd3b:ce77:841a:722b%5]) with mapi id 15.20.7918.024; Wed, 4 Sep 2024 01:06:33 +0000 From: "Kasireddy, Vivek" To: Steve Sistare , "linux-mm@kvack.org" CC: Muchun Song , Andrew Morton , Matthew Wilcox , Peter Xu , David Hildenbrand , Jason Gunthorpe Subject: RE: [PATCH V1 4/5] mm/gup: fix memfd_pin_folios hugetlb page allocation Thread-Topic: [PATCH V1 4/5] mm/gup: fix memfd_pin_folios hugetlb page allocation Thread-Index: AQHa/g0uO0Ef8PENGkCSbWGxHZjhvbJGkfAQ Date: Wed, 4 Sep 2024 01:06:33 +0000 Message-ID: References: <1725373521-451395-1-git-send-email-steven.sistare@oracle.com> <1725373521-451395-5-git-send-email-steven.sistare@oracle.com> In-Reply-To: <1725373521-451395-5-git-send-email-steven.sistare@oracle.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-publictraffictype: Email x-ms-traffictypediagnostic: IA0PR11MB7185:EE_|CH3PR11MB8548:EE_ x-ms-office365-filtering-correlation-id: e1ee5ad3-9892-4047-264b-08dccc7dd1a0 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0;ARA:13230040|366016|1800799024|376014|38070700018; x-microsoft-antispam-message-info: =?us-ascii?Q?qkxK981+A/BiWe32RVdhOfDKo48cEe35k7Kg8Szipt4P86ZYCRihySv8OrSt?= =?us-ascii?Q?zrrcXdKv0rPViwBlj42vd2nytFSGcrVCxEYCsy+dTIKKoia2PTlXpobxLXU6?= =?us-ascii?Q?myATty+cpjBXEO+KSqmBQyzVwa0pBgantM3aDeaoaipxMs+mh1Wny8NGE2j2?= =?us-ascii?Q?UWDKXe003yFc059IfnLiPiVyoSykK7nu2x1elGWi3UCUveMChQ5+w3JAQtqW?= =?us-ascii?Q?heBWXrEahCXrECMfJjrRLRNXR3j5jLdi47kK5nMa8y3LY3uUaJ7tzHIOj9VF?= =?us-ascii?Q?LCyIOOrNr0i3ylDKuvsdfPqJ0KwSN54v3azTAKgm6ts85Zd2OQeCpgygkwyF?= =?us-ascii?Q?UGV3/ED8Ui/Bil1rJHZDiyYly2Nzh484JotB5NZuA7/t/AADaGdOYuWh1zJ8?= =?us-ascii?Q?a2mMFjyinxbQZSQTcp+EwLL1KJl4R+93fd0MogLGcMs/NJNxzdde/A7S8yG1?= =?us-ascii?Q?Sl55oQZ+d3PdtypgLFfMEGkclStGfuzHa57bVxzZ114BDOTrq3OHTr9JR+8W?= =?us-ascii?Q?+HVxdHLS8cYXMFK7NyxW2PLWUBBjudJyEQJ5Z2Vsy2SIc6RYHUUbrCbOH8Nq?= =?us-ascii?Q?8qd7XVMJvIm/2Ta9tsz3CKyW8RGi4abcKntssZy7fduIT01OD/qNO0aWYCJK?= =?us-ascii?Q?4EUeTbGmq5Fh4Ulq5ClUKRHslIGlzTVy9CPXkzXy8AGFO8d27QI/WaQpS+60?= =?us-ascii?Q?sLBNbZap/3umIynLO9DWSAP9u76oVb9XuukqGy/zxMcLbstXXNxXDzcVblWS?= =?us-ascii?Q?G0QWqvVLVKqOfAKZEWvAbFtoYpW7ks3y0ORHnPUY0E6DhZzimqNyXEksPM3i?= =?us-ascii?Q?s+/cLVw96tFTKx7212LosHSAMTN/1rR1tjkSgyx/Omm22wTZuN8DxqgavZEG?= =?us-ascii?Q?GNxeYtYLqLurGglri+dHgRALP4fkW1/nFmuY+mE1FtNYU8FFeTNwfLUMqCjt?= =?us-ascii?Q?CfwYPJKinzdkcJxEGRqXjAoKGdMJSxi+r0m5G8mGYnC4AzQHlVoA7fJ19AYC?= =?us-ascii?Q?bnFb491/CCJ3vbQ1ipD1RmJQzGlg3Q4GBIVKd+LBrXJLsvAImxW8jK3Iib0Y?= =?us-ascii?Q?Jcu4ZrFVdB3vif2hPQpgHjMPiAYmJC4UxUcU0+T6bzsfdLnmAsnoZrlwcfnv?= =?us-ascii?Q?DbKTZCqruzZqm+Q0MXpqnfb+FloUmDyIOTa6alhwA65lNBU7sYUfgt+rkHh/?= =?us-ascii?Q?1/cBRpgkzAMwcmhWaEtmoFDii2B8TgdMzjctl3x/8rMcSctgisqc9rUeF+ge?= =?us-ascii?Q?HtXC9JlNMwCkKU9FyJK6jv98GLpU+OM9lTHTpf3HPS6KAJQosDA5KccddiIR?= =?us-ascii?Q?4E4iDIjIggYPbyc65Cs72sbzfCgQ03EYzHmlOp1kRxlsfCaUH0i4JQVYQUNu?= =?us-ascii?Q?GGeL6pfZb6oScTjCDlcwxPpK8Yb1umLW6b48AbrXaUO9rWqcmA=3D=3D?= x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:IA0PR11MB7185.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(366016)(1800799024)(376014)(38070700018);DIR:OUT;SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?xmbnS8x0RERvANxreiFy/61pnpvA0V+bQpRpYmuLrZebUyCjTdvhItIUgJBP?= =?us-ascii?Q?tSelm4dyNYMXAaTy0I3ka/kyS9S5PkeLywqko9akHWpip7FNTn0ew40bImuN?= =?us-ascii?Q?lI9kJFpatyZuyM/QP4/QBO5/lKvgpXYHswAtbG0oT+dWMqvFgkpz5zCEaWmr?= =?us-ascii?Q?/Ga4/pDjpPefgjN0cnatOOR/90jkkgls/LTfSr1nMDXlvpyeFGovAZPea8Oh?= =?us-ascii?Q?lIlzuwkwLQ7si0daeghvdDUm3POJ9WihAtDjFxY31edCnmeBaT+yVoMyKEGL?= =?us-ascii?Q?gr/k9jtDLAnZ4O1Jv/4g/XNL8GFfBko8uDz/IIMfns3VK8CWfQpXEGyZ8+A/?= =?us-ascii?Q?jamYpOVfWan+jdIFetp0EPOn3/syndyQleOEafahSWu1LlbSdabbssH7lhUU?= =?us-ascii?Q?G002Ee5MlgyaI87RBTsBKEiDb5bj3a+0fm7mNCh88gb7HhzfUF/B+4E6Ze6E?= =?us-ascii?Q?DcroC+Mj76s5/mZwsw/9aHQdu9yKKf4XIKvIFv6gsgjOWyv9/ZwVwt6HAG+d?= =?us-ascii?Q?Np8ZiW+mkXrn2RRglnmfPs3/rjDNHIbBzQ8V0lJxlRhH5whVXPc7N1IlrSNr?= =?us-ascii?Q?k4hTasYbCAiifzJXwAGqJgAoSm2NIXsApRRUV5IlMvVfVvS0eyyZ9bZy1kC6?= =?us-ascii?Q?M/My54nXgyCM2J6F21vKbIZRLnGX3FG6oywrericjzy79a+MjSAUR4u5Rqbt?= =?us-ascii?Q?x6gZM7GTness7AY0WgP3falJjJE1zj5qJjFwZ+ZwZ6jy4gTIO7TORFHo81RO?= =?us-ascii?Q?Iwn+VPR1tYE8toaDGg8EUZuEyW8V/SxMcWXcjz6T8YygkgxtRM0U3QYoooSQ?= =?us-ascii?Q?0AxKk5rLpDHrlipMVuabzUg6zCnDKYVV0AS9yG7NM1++HzUrqnx1IREz7adb?= =?us-ascii?Q?+22/P933rHodhuDXqbLMjE4Wg/s/n4NRGqyOHmTTLySySOGNbp9yX1DGz1Wg?= =?us-ascii?Q?IxHxEtBfGV/UXkLWjQAKHcebc7fboPYD46fr7D1X1Z/4o/ekVQV5ECs6u3Rt?= =?us-ascii?Q?dPUwpJGYzb/BA33vFdZZGWcqryCJYs0oIZfWUbzrN2m5ROUZ7ZY9lKUC/M7v?= =?us-ascii?Q?4gOD8vwzURrLmRFJFN6Puhcc7SMSKSWLWgih9rQvWYhqYWPWHPknQ61HRfTr?= =?us-ascii?Q?xHxN6ZK+1Aa5zxuHb4iB1wGOvSqEImNPkd8fm7r/ZlseYwlJrhcOPKvTF+4V?= =?us-ascii?Q?L/4ypudMLPx3dXQl6b5k3dOMuQG40AjviOwhVRc1wRWfAF2MfryCRZmo8PEU?= =?us-ascii?Q?O3HjqwtJI0VZlshdahCYw5ZSU7W1+LjEGbvQoX5rE+CJLqIc3JInbP7q0UyI?= =?us-ascii?Q?iAhFLBSdU4YQgP7PJPYIgWvYeDn6BO0B0lNmQyHzyYekGkb2ZFc2YQUpCG+4?= =?us-ascii?Q?7dMV8qNPnCWTT7UXCgDxQDRu8KOvYrm0b23c3TxkpiysEGLTweFHqfJBAxqK?= =?us-ascii?Q?MJBeOTP3by0MRS3bbVow0egZBEl/lfp7L6Vhk/kA7yGgzRQ1jt/uuEq32OMj?= =?us-ascii?Q?CrLkN+tLDX5m12tLpPxkoZf2hsPB0hf5z6t30R03u894OSDsf8GEnnsfaYeJ?= =?us-ascii?Q?rMErkrUg/JRCx3BhVjbNNvpGJErBeu64uNigUvgh?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: IA0PR11MB7185.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: e1ee5ad3-9892-4047-264b-08dccc7dd1a0 X-MS-Exchange-CrossTenant-originalarrivaltime: 04 Sep 2024 01:06:33.9148 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: IbCCmlBumGTaTTd8UIsMQOF9hSNIcu+d6rJA67Zgz/gUnyAPG3oPY8yvEzWNoHFkTCUV1CfG3v1/vNHkHTlv3IDSVAvW8ehFNk5LjT021LM= X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH3PR11MB8548 X-OriginatorOrg: intel.com X-Rspamd-Server: rspam06 X-Rspamd-Queue-Id: 9F05F140007 X-Stat-Signature: 6y7figietaqpo78n4ewij53zxcoye5ki X-Rspam-User: X-HE-Tag: 1725411999-264199 X-HE-Meta: U2FsdGVkX1/T2r91LUgbs050q14WfquP6leWXDXhkFr+QE/51MrK87JZ/jBans5KiOMwEnoYMrmlV4ctB2/h6mxJ5c5bJ8i+6CKz7NhQyZPxJtoj8XsJTNxFKB77yz0bOw6dPJKcxHF/WmaU6f4pOkI7u/UqC+2W0fnLAGfGBjUWH6L+kV0zWbj1uEmYgHrC+y4I1vw61S2xoye9PMleeUr45puvOl/gRBtBz4Dep4avIy2H5K4uiBfX7yNnQSFQOMyfwfRaop+0lgm0sF0YdMI7na1ZC+tpPRs+h9BZiw8esksn+jPfWty6qxEir/cZMLEXk0oHQUjAREMpxsgwpiwV6H5cTTs3CaiUw2oxTqJT512f61gsNPn8XSZiJ0Ynfd26UVeZ3ZzuFo8lyKwD/jOPOTs2e/yZwl7VQNrV9DjNByLNkil/HzO1F41lt7ppOLD/GtQBGR02jvMfT8R5zase9whXu8XpQSY7+umNiRqAr0ptencgdFwZCBy/JbuO+Ww3PLPN+ksG0PYrQLI2AH94umVhlZiUFKOIv/wPFPY6mIPNGFxcc6IvtVmnuzhUuYjNmCzM7CK5kdCs//wrKIl0NFgEN/77fLwhlqC+nziQVWmXL8rHJ+PGHjfypZHPh1iBSiA2sl6jv5CVzHQLdKpboYWoutRFsPi/ERvtRYQm7nPPSLgHBaxspeinKAOuqQwfqe9TaYQXKG4gMi8onE82IIf5naA0G/SL0W/ny5W1LwYVXWoFde9MvhQ8YqplBVlwxCMBIrTykYSuAs7Fr8GQYvkwnPFYL90Pxj0U/W9zm9iZzqMKwej6J3XnQKsC6IS/e7Pi5bfsCs+NW5AuK+WvHYuMDkzjPx9SXJhAJxXzocLJPJeJLz4H+rTYAJq4uWn8uE4SF45Ois7j9KxBSsgS81rAd2GfqXlnaEIRJ3UlO8EknEE9G5es3NSvPdZWjaVBdoR82aNpftVxxbD FIItEMqy 2a0ACp2OQUcrMR5kqZH4F6rMrB0f1C6NBAQfWzOiwCQCuBFo5sDeeR/Bn+C86gajYCdIBbXyu1a5QmYy1M3g+RZCzCBggw0wVOcfSzdiR6V+DzwGdvsjkO95ctmbEv6vg3Wx/k6BVU03b5qHP6SlFFvXC2CP9FS7j8pPRoyFsvr5REpRdw4fXVlsl/pBGaSISFD5lmA2aY7UJiwLdDIX6wfcrCDUQNiIDcEL+RTahvHZ7QHHmEju9mhKfaxiZ5JyQEGc68xAHceangqDIA0HOsvkfkNIpS9Gw/Wvswydp3o8jjwjt7CLn7viIGHZus1Rox3HeQtwURftn6Fo5AYF6TTRqppr6qPeS43Yv9ZBpGD7bKh1y88BF+1kRPeQ4a9YRttsJjgyqc4+b2oAh9tIpjDJSg3UpIRTqP8SEisTlz5u9wv9tJ0plMLz1hNyb1U8uPjl4R27Kki6X0B8rpf/9jACBxw== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Hi Steve, > Subject: [PATCH V1 4/5] mm/gup: fix memfd_pin_folios hugetlb page > allocation >=20 > When memfd_pin_folios -> memfd_alloc_folio creates a hugetlb page, the > index is wrong. The subsequent call to filemap_get_folios_contig thus > cannot find it, and fails, and memfd_pin_folios loops forever. > To fix, adjust the index for the huge_page_order. >=20 > memfd_alloc_folio also forgets to unlock the folio, so the next touch > of the page calls hugetlb_fault which blocks forever trying to take > the lock. Unlock it. Where exactly is the lock taken from? I did a quick search but couldn't immediately figure out in which function is the lock taken, while allocatin= g the folio. >=20 > Fixes: 89c1905d9c14 ("mm/gup: introduce memfd_pin_folios() for pinning > memfd folios") >=20 > Signed-off-by: Steve Sistare > --- > mm/memfd.c | 8 ++++++-- > 1 file changed, 6 insertions(+), 2 deletions(-) >=20 > diff --git a/mm/memfd.c b/mm/memfd.c > index bfe0e71..bcb131d 100644 > --- a/mm/memfd.c > +++ b/mm/memfd.c > @@ -79,10 +79,13 @@ struct folio *memfd_alloc_folio(struct file *memfd, > pgoff_t idx) > * alloc from. Also, the folio will be pinned for an indefinite > * amount of time, so it is not expected to be migrated away. > */ > - gfp_mask =3D htlb_alloc_mask(hstate_file(memfd)); > + struct hstate *h =3D hstate_file(memfd); > + > + gfp_mask =3D htlb_alloc_mask(h); > gfp_mask &=3D ~(__GFP_HIGHMEM | __GFP_MOVABLE); > + idx >>=3D huge_page_order(h); >=20 > - folio =3D alloc_hugetlb_folio_reserve(hstate_file(memfd), > + folio =3D alloc_hugetlb_folio_reserve(h, > numa_node_id(), > NULL, > gfp_mask); > @@ -95,6 +98,7 @@ struct folio *memfd_alloc_folio(struct file *memfd, > pgoff_t idx) > free_huge_folio(folio); > return ERR_PTR(err); > } > + folio_unlock(folio); Acked-by: Vivek Kasireddy Thanks, Vivek > return folio; > } > return ERR_PTR(-ENOMEM); > -- > 1.8.3.1