From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id B199AC433EF for ; Wed, 13 Jul 2022 07:34:55 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id ADA9D940107; Wed, 13 Jul 2022 03:34:54 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id A8BAA9400E5; Wed, 13 Jul 2022 03:34:54 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 92D60940107; Wed, 13 Jul 2022 03:34:54 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 8735C9400E5 for ; Wed, 13 Jul 2022 03:34:54 -0400 (EDT) Received: from smtpin11.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 552E460DB7 for ; Wed, 13 Jul 2022 07:34:54 +0000 (UTC) X-FDA: 79681264908.11.BC2E9FA Received: from APC01-PSA-obe.outbound.protection.outlook.com (mail-psaapc01on2049.outbound.protection.outlook.com [40.107.255.49]) by imf07.hostedemail.com (Postfix) with ESMTP id DB78040038 for ; Wed, 13 Jul 2022 07:34:52 +0000 (UTC) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=VGvp5RiqMGgJlmsdm42sw+KMl/9G5a1IckOrKJojH65AWHAtczw8vY6L4Wr5xQCgNyalc5bV3oG5FEWjoApMHEWNTlfoKt6alvRm8/TI3QG0FjHuuq9YenF0slMYrNHWHtlChcvYl4owCqoVi9k9Bg/xk8fcf2MJL7NwqVeRtLS736xUcXo9x396PXvi/w+Mmbu29ps1tgJ38ZtFzSCQIL7Zbv+hoMpqlNShM42Srupk9EpSJ7A8Aa/ic5CxArA4FmS5i3yk1zYLa+Bq6yk4DewyNIGX9u/lhsw+Ok/amAcRZ9DIPrLmDYcgDTVy2jKtKaUMc02d7MhZxFmxAGH8CQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=srhli17rtO9KqdFPZEs8Z1DP4lAfShwDMHuNiLaqQEw=; b=P86f7tP+Xj/guAS7/DZ/XLSoiERVswpuzzR9kEr9wLXFifasTv+O91Mfq5vsYCSiviS5ezRQKj0eSdwoiIMBgYfOKRZKVchfahTYoTi9X6tQuVFlk90qNU4SIbXm6pnuKrQV8gMaRM0rd3oEqU8mNK/oNa4XNz1J9dQcpkSd65NP1s15fAzedVODvCvkYYYOJukXl+xdSppW//OlqeoKIDvod4q9uSJFRzTx59cX1WxDHcXWM0kZXTRF3R/9HBZN3gD9vIYF5KlQ8EA51wm8Tt7lPaOj8szRObneC84vhq7Owuz2SLAVpXSyITr16MN3nNeRp+A7l/RpgnSIkhskZQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nuvoton.com; dmarc=pass action=none header.from=nuvoton.com; dkim=pass header.d=nuvoton.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nuvoton.onmicrosoft.com; s=selector2-nuvoton-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=srhli17rtO9KqdFPZEs8Z1DP4lAfShwDMHuNiLaqQEw=; b=n+ksRExiTrgrh2iPd/QVWI3CM6NrhRuUBzBvscJ9TsGU+HLjEYt4+EeYpOBYxqZJcer2YIrAOHqJHqnX9Vtq1V2TDH3qzGK2+jLTH1Ta4ug1wi1gumUSzEqZd/hzkoO2th4Rp03LHYjj/iIlJd2BtQiu6JTR4QV4qe/ydzaKcFY= Received: from HK0PR03MB4897.apcprd03.prod.outlook.com (2603:1096:203:bb::22) by HK0PR03MB3412.apcprd03.prod.outlook.com (2603:1096:203:5c::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5438.10; Wed, 13 Jul 2022 07:34:48 +0000 Received: from HK0PR03MB4897.apcprd03.prod.outlook.com ([fe80::202e:925d:eae0:44a6]) by HK0PR03MB4897.apcprd03.prod.outlook.com ([fe80::202e:925d:eae0:44a6%7]) with mapi id 15.20.5438.011; Wed, 13 Jul 2022 07:34:48 +0000 From: "KFTING@nuvoton.com" To: Dan Carpenter , "kbuild@lists.01.org" CC: "lkp@intel.com" , "kbuild-all@lists.01.org" , Linux Memory Management List , Wolfram Sang , Andy Shevchenko , "tali.perry@nuvoton.com" , "Avi.Fishman@nuvoton.com" , "tomer.maimon@nuvoton.com" Subject: RE: [linux-next:master 1342/8914] drivers/i2c/busses/i2c-npcm7xx.c:639 npcm_i2c_slave_enable() error: buffer overflow 'npcm_i2caddr' 2 <= 9 Thread-Topic: [linux-next:master 1342/8914] drivers/i2c/busses/i2c-npcm7xx.c:639 npcm_i2c_slave_enable() error: buffer overflow 'npcm_i2caddr' 2 <= 9 Thread-Index: AQHYll0E78mOMuPUk0yWM5WcQvwKd6176QMg Date: Wed, 13 Jul 2022 07:34:48 +0000 Message-ID: References: <202207110811.lWIJpo4l-lkp@intel.com> In-Reply-To: <202207110811.lWIJpo4l-lkp@intel.com> Accept-Language: zh-TW, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 479c1d6c-69ac-4635-f15a-08da64a22a66 x-ms-traffictypediagnostic: HK0PR03MB3412:EE_ x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: ROYxPgRkxCxjxm0rQ/SNESXYrG6e4/kK6Y5OOnFAT8Tsd3/9UHM8eINRefjBFrWh4KlWGjsaB4B07jgR/ZGwt5IBRI/U2ACuWx1gMbOSLGOnmqPFaFpT6vdTVhdG//Pg3Rj+3AnVpzv2XdLVsycM78RuAhJwWpV9swIxcWh8fcLOZXwqW1JphX391LT4oMdrrcAX39ORWOBgsTkntJ9XLCM/s0PGK/aauhMmom5A2jeiOWGsInYNrM+tt6ISyrnSwMH/eUS0idqno5wxDh4fb+xrP/A16qETSaZOFhsAdxbe70kChYaQCDKpTOKhKCdLc0y/sfdvx3jT6md4jFvr+dYILUA4NZeZzDzn0fzT4xPn7FdjxlEhim3oaou0YQzx4Oa8lj4zuserYgs+D4S9CWM7USAIp/75DBnlE1wlO1YMNUUMDFOg1PzHwosd697Yft1AeUzkvLCnqZFXp8VmKo3a9BndTiYV3AbFR/820cruYhYLcrYAaobppzM9NjZcf4M7rKdIcAwwy8BsHIo77oupihWMe4j77b6XC1xLKNz1RTnAcO3XAuFIAbmEPFbDqZ02mOLYQT56Nt4fvSkNOPnY14hxZYF+mN3bvnshnI1Mf9HjCkCJBf0LcTzOYyP15ET/Eq7WE8ogp7xruojkiQwNR01/blYrSXiWTZfAZBmF2aRjQWmwBp6htRHa+EIjjOdEsgq5ujXkQoikh+DzMbW9xpBmA51Wkgi/eX4kwBVhN7Jcg5xoAXySRVQNVbGSH5gPlbygzstp8l1BlJr8BuIZkgiPls6R8PvN7tMKJS1+lj6guZWQ/HusVQrY7K8h0jAF3vPQ8FcLRwYl7qgaPfCSHr4+2Q2iTFGiOVeGl19Md2nXeSOgMSIdEv1yGlUz x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:HK0PR03MB4897.apcprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(4636009)(136003)(346002)(396003)(376002)(366004)(39860400002)(83380400001)(122000001)(107886003)(38100700002)(38070700005)(5660300002)(9686003)(8936002)(186003)(52536014)(8676002)(55016003)(2906002)(478600001)(71200400001)(7696005)(966005)(53546011)(41300700001)(6506007)(26005)(4326008)(64756008)(66946007)(66476007)(66556008)(76116006)(66446008)(110136005)(316002)(86362001)(33656002)(45080400002)(54906003)(70780200001);DIR:OUT;SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?TG0XBdT5H36nYk9+rAC3+mPzV3EZc50IK0N5AKTkQcM3t7w0/9kCkk5rsqXA?= =?us-ascii?Q?C8NDAMHJUtxGgSWpsYlRT3Jv0yJF6ERJHVJBgRvT2xycKWUaTb7GRXxQY24P?= =?us-ascii?Q?pysLvyu2Xz8jALUAPRBPrJ9AzOvyjCcm3hvq3R8+urbkvJKZ7oIk8jobIBck?= =?us-ascii?Q?5xLFUoWUwojhrqPEE3ABGqX7Lyt0AHq4HN43ob5MNcQz3tSI6Jy1238rb6rx?= =?us-ascii?Q?cE3+mT6GOz1AHJdxJetmiATH2QnZLDrIhoT5Yd41GHDYUt8ElQSiT1AigG2h?= =?us-ascii?Q?MRhitW1Q0Baz4U00xaF2fNtpNSK0WYHxd3j57bgZha4sdQ0tDcGZb4xsWnA6?= =?us-ascii?Q?PNFL1z/ngQxkLQyjfVAQ6HlcrV9AzM3GPuc5gw3TWwJMS2ivz8FAUZ7mxb2z?= =?us-ascii?Q?kZhYgqUB0la0ztdUQZPmfXlHM31/yCeXDqg/KRpdmLRFtXWPVb3NJYt/UsT5?= =?us-ascii?Q?oh9hhrP0ollCW8GRipJKuqarlduE+g9vq9V7WTobC00LjAym9VN80HY7zpSH?= =?us-ascii?Q?c//CMOPBXntX2WzXqGNAjTnqvjRLoNGZpwYHXSzdGwLYqpWlmTtLAyK4idQ9?= =?us-ascii?Q?KTqtiyvMnq8akdeZ2ZGKtfFETUPMoC9tsz+atjGzhSORBJXSTuKyiNMGin7v?= =?us-ascii?Q?R21TRdjohsmXB054jES7YBRdXzyEjPE7m54BFXHnbdXxoryFOYeN393xXHFH?= =?us-ascii?Q?EAZC3PdQ3TKT9arAavx4S6aAbAldVvdnmH2QG37yAAy5J8PEjyznfiS6n5/r?= =?us-ascii?Q?BZrJUAo3rOQsH5xDPLr6DuizZ9fS/AuteXLpS6dLtHrL1Nau/RUXtA4AwcT6?= =?us-ascii?Q?B6zBLsB59m0UkMZa5jBrzeOfYwmmtrjjIvWms6ef5wVbZhY3cTh6zKzw8JE8?= =?us-ascii?Q?3Pvph4FvZZoYlmOA9WEulDVrJ4r++ZxUMw6zQqLubGS6Gw94tA/lB+CMZFsZ?= =?us-ascii?Q?+bxPAmezhR8pYQ1Em1SmxHN5gvwfaMi9g1kgusv9q2jhS5w38dqQAfXZn9SO?= =?us-ascii?Q?L596olvQ8DVkSdaa/cp/Tolt69Cq3pYMTcaYjseDAMgXgoVUH4ivSPi4Rt/6?= =?us-ascii?Q?YDpB8qOd5Q1EmaoztCN8q1RFb7/fJOLF6XLxVe6Tixz9kcPnwtvyHFLh3Rgo?= =?us-ascii?Q?qLi5aAWvA7Vgham1Eh4k4GisCKsAf2yPJLIj6YjmWJWNUzMpMNhREpkBSIGy?= =?us-ascii?Q?AQ6NwTYUGW0VCA+M9g+5SGZp++wwiDYhuBW9b0W+Men7jSkgunuebIOfryRj?= =?us-ascii?Q?Dxl51C1C65Q98uin3Q061OWEghsqScgxn5mpo2l1majD1NwoEON/45gcoigv?= =?us-ascii?Q?oN2zieyXDT/ZRFGqKzn2+MZCw4zfs6aTHZzPmLLt8kNhprfPZyDUIB3KH7MM?= =?us-ascii?Q?wGigZow6MD7IXEn/Hn8c1gLzu56uGfVCYWtOHQ0yygj1niFrbPnLMlpx4LNg?= =?us-ascii?Q?hO6KZ3C3MnmPf0Iv9YstV9y5PnHABGYOkoA+suQcQljTzha2LoPicb5Mk4Ky?= =?us-ascii?Q?rbN+enI1wZocsqWtUPIJdFrPIj9tbiT2hnz8Xhk+LLExhleutZosKBiatdoe?= =?us-ascii?Q?H3uvY2jMzsR06/JZqDXUm9KZ+VBFQf0otedSl/iN?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: nuvoton.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: HK0PR03MB4897.apcprd03.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 479c1d6c-69ac-4635-f15a-08da64a22a66 X-MS-Exchange-CrossTenant-originalarrivaltime: 13 Jul 2022 07:34:48.5059 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: a3f24931-d403-4b4a-94f1-7d83ac638e07 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: N8Sc3Q39qsK291dqtjnEn4Zll8TxeCU0s6DCJ3eSt25EpCfHVwE9n6zY6rCrXHu5X0THR0ZRN3VQhLEzmxD8KA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: HK0PR03MB3412 ARC-Seal: i=2; s=arc-20220608; d=hostedemail.com; t=1657697693; a=rsa-sha256; cv=pass; b=4aO7UsD0Ep43MjuxEH67+L/+O4pmxB+4f0CRuh7gDbX8zEqFlpVpYAbbc0LvNNCPuDPu7Q kTwgcaFF+4+jJ3017bPtur8AqtwPvdn0SLLQiwCuUMfydQzUS+ydyLcWJTwaX9nVg7c1bn c86z0uQlg/09XcY1n/QOSz07k+R05sg= ARC-Authentication-Results: i=2; imf07.hostedemail.com; dkim=pass header.d=nuvoton.onmicrosoft.com header.s=selector2-nuvoton-onmicrosoft-com header.b=n+ksRExi; dmarc=none; spf=pass (imf07.hostedemail.com: domain of KFTING@nuvoton.com designates 40.107.255.49 as permitted sender) smtp.mailfrom=KFTING@nuvoton.com; arc=pass ("microsoft.com:s=arcselector9901:i=1") ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1657697693; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=srhli17rtO9KqdFPZEs8Z1DP4lAfShwDMHuNiLaqQEw=; b=7AQq4TAOj1R4txPhfyTBlh1gUZWGcKCfFGAmqV5uqPV0CwCGiPyN4iZRltZJR0OX0ngsfK bfz35eKjE0sGupcYfYMyb25hYfHr/Ed8zpWU5BUllTDCTyDjRtp4z0DtZRTqlKWpgcwpaR nUWCtr1Fale8Ns1MeQ4vW0qRkpb/r+I= X-Rspam-User: X-Stat-Signature: ocj5hba4axzqz6cftxtx4ujcr9jkkt5p X-Rspamd-Queue-Id: DB78040038 Authentication-Results: imf07.hostedemail.com; dkim=pass header.d=nuvoton.onmicrosoft.com header.s=selector2-nuvoton-onmicrosoft-com header.b=n+ksRExi; dmarc=none; spf=pass (imf07.hostedemail.com: domain of KFTING@nuvoton.com designates 40.107.255.49 as permitted sender) smtp.mailfrom=KFTING@nuvoton.com; arc=pass ("microsoft.com:s=arcselector9901:i=1") X-Rspamd-Server: rspam03 X-HE-Tag: 1657697692-462564 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Hi Dan: Thank you for your findings. It's under discussion. Thank you. Regards, Tyrone -----Original Message----- From: Dan Carpenter Sent: Tuesday, July 12, 2022 10:01 PM To: kbuild@lists.01.org; CS20 KFTing Cc: lkp@intel.com; kbuild-all@lists.01.org; Linux Memory Management List ; Wolfram Sang ; Andy Shevc= henko Subject: [linux-next:master 1342/8914] drivers/i2c/busses/i2c-npcm7xx.c:639= npcm_i2c_slave_enable() error: buffer overflow 'npcm_i2caddr' 2 <=3D 9 Hi Tyrone, First bad commit (maybe !=3D root cause): tree: https://apc01.safelinks.protection.outlook.com/?url=3Dhttps%3A%2F%2= Fgit.kernel.org%2Fpub%2Fscm%2Flinux%2Fkernel%2Fgit%2Fnext%2Flinux-next.git&= amp;data=3D05%7C01%7Ckfting%40nuvoton.com%7Cdba8ad969d8b45249e8508da640f0f1= 2%7Ca3f24931d4034b4a94f17d83ac638e07%7C0%7C0%7C637932747253333274%7CUnknown= %7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6= Mn0%3D%7C3000%7C%7C%7C&sdata=3DnoT2aCRrctRlLER1OEP40Q%2FGKYBjArSfJ9JsSo= dCmmo%3D&reserved=3D0 master head: f2528c29385819a84480cacef4886b049761e2c5 commit: bbc38ed53a02a759d8e5c01e834eca49304a2315 [1342/8914] i2c: npcm: Sup= port NPCM845 config: microblaze-randconfig-m031-20220706 (https://apc01.safelinks.protec= tion.outlook.com/?url=3Dhttps%3A%2F%2Fdownload.01.org%2F0day-ci%2Farchive%2= F20220711%2F202207110811.lWIJpo4l-lkp%40intel.com%2Fconfig&data=3D05%7C= 01%7Ckfting%40nuvoton.com%7Cdba8ad969d8b45249e8508da640f0f12%7Ca3f24931d403= 4b4a94f17d83ac638e07%7C0%7C0%7C637932747253333274%7CUnknown%7CTWFpbGZsb3d8e= yJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C= %7C%7C&sdata=3DRvg3gcFwhuBYfnbBb5%2Fq04ohZH66pIv5cLq6KKE%2BfPg%3D&r= eserved=3D0) compiler: microblaze-linux-gcc (GCC) 11.3.0 If you fix the issue, kindly add following tag where applicable Reported-by: kernel test robot Reported-by: Dan Carpenter smatch warnings: drivers/i2c/busses/i2c-npcm7xx.c:639 npcm_i2c_slave_enable() error: buffer = overflow 'npcm_i2caddr' 2 <=3D 9 vim +/npcm_i2caddr +639 drivers/i2c/busses/i2c-npcm7xx.c f54736925a4f83 Tali Perry 2020-05-27 607 static int npcm_i2c_slave_enable= (struct npcm_i2c *bus, enum i2c_addr addr_type, f54736925a4f83 Tali Perry 2020-05-27 608 u8= addr, bool enable) f54736925a4f83 Tali Perry 2020-05-27 609 { f54736925a4f83 Tali Perry 2020-05-27 610 u8 i2cctl1; f54736925a4f83 Tali Perry 2020-05-27 611 u8 i2cctl3; f54736925a4f83 Tali Perry 2020-05-27 612 u8 sa_reg; f54736925a4f83 Tali Perry 2020-05-27 613 f54736925a4f83 Tali Perry 2020-05-27 614 sa_reg =3D (addr & 0x7F) | = FIELD_PREP(NPCM_I2CADDR_SAEN, enable); f54736925a4f83 Tali Perry 2020-05-27 615 if (addr_type =3D=3D I2C_GC= _ADDR) { f54736925a4f83 Tali Perry 2020-05-27 616 i2cctl1 =3D ioread8= (bus->reg + NPCM_I2CCTL1); f54736925a4f83 Tali Perry 2020-05-27 617 if (enable) f54736925a4f83 Tali Perry 2020-05-27 618 i2cctl1 |= =3D NPCM_I2CCTL1_GCMEN; f54736925a4f83 Tali Perry 2020-05-27 619 else f54736925a4f83 Tali Perry 2020-05-27 620 i2cctl1 &= =3D ~NPCM_I2CCTL1_GCMEN; f54736925a4f83 Tali Perry 2020-05-27 621 iowrite8(i2cctl1, b= us->reg + NPCM_I2CCTL1); f54736925a4f83 Tali Perry 2020-05-27 622 return 0; 47d506d1a28fd1 Tali Perry 2022-05-25 623 } else if (addr_type =3D=3D= I2C_ARP_ADDR) { f54736925a4f83 Tali Perry 2020-05-27 624 i2cctl3 =3D ioread8= (bus->reg + NPCM_I2CCTL3); f54736925a4f83 Tali Perry 2020-05-27 625 if (enable) f54736925a4f83 Tali Perry 2020-05-27 626 i2cctl3 |= =3D I2CCTL3_ARPMEN; f54736925a4f83 Tali Perry 2020-05-27 627 else f54736925a4f83 Tali Perry 2020-05-27 628 i2cctl3 &= =3D ~I2CCTL3_ARPMEN; f54736925a4f83 Tali Perry 2020-05-27 629 iowrite8(i2cctl3, b= us->reg + NPCM_I2CCTL3); f54736925a4f83 Tali Perry 2020-05-27 630 return 0; f54736925a4f83 Tali Perry 2020-05-27 631 } 47d506d1a28fd1 Tali Perry 2022-05-25 632 if (addr_type > I2C_SLAVE_A= DDR2 && addr_type <=3D I2C_SLAVE_ADDR10) 47d506d1a28fd1 Tali Perry 2022-05-25 633 dev_err(bus->dev, "= try to enable more than 2 SA not supported\n"); This prints an error message for values 2-10, but allows 0-1,11,12. Maybe the intention here was to return -EINVAL? It seldom makes sense to p= rint an error and then go forward with an out of bounds access. 47d506d1a28fd1 Tali Perry 2022-05-25 634 f54736925a4f83 Tali Perry 2020-05-27 635 if (addr_type >=3D I2C_ARP_= ADDR) ^^^^^^^^^^= ^^ This is addr_type >=3D 11 so Smatch complains that npcm_i2caddr[] only h= as two elements. My personal Smatch run with the cross function DB says th= at addr_type is always 0 so it doesn't complain. However, one rule of kernel style is that we do not allow stub code and als= o to a human reader this code really does look buggy... :/ f54736925a4f83 Tali Perry 2020-05-27 636 return -EFAULT; 47d506d1a28fd1 Tali Perry 2022-05-25 637 f54736925a4f83 Tali Perry 2020-05-27 638 /* Set and enable the addre= ss */ f54736925a4f83 Tali Perry 2020-05-27 @639 iowrite8(sa_reg, bus->reg += npcm_i2caddr[addr_type]); f54736925a4f83 Tali Perry 2020-05-27 640 npcm_i2c_slave_int_enable(b= us, enable); 47d506d1a28fd1 Tali Perry 2022-05-25 641 f54736925a4f83 Tali Perry 2020-05-27 642 return 0; f54736925a4f83 Tali Perry 2020-05-27 643 } -- 0-DAY CI Kernel Test Service https://apc01.safelinks.protection.outlook.com/?url=3Dhttps%3A%2F%2F01.org%= 2Flkp&data=3D05%7C01%7Ckfting%40nuvoton.com%7Cdba8ad969d8b45249e8508da6= 40f0f12%7Ca3f24931d4034b4a94f17d83ac638e07%7C0%7C0%7C637932747253333274%7CU= nknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLC= JXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=3DrWK79iKTAeZDNJjfoymuDF7zrvRB0TcnaB= F%2FOwX4xFw%3D&reserved=3D0 ________________________________ ________________________________ The privileged confidential information contained in this email is intende= d for use only by the addressees as indicated by the original sender of thi= s email. If you are not the addressee indicated in this email or are not re= sponsible for delivery of the email to such a person, please kindly reply t= o the sender indicating this fact and delete all copies of it from your com= puter and network server immediately. Your cooperation is highly appreciate= d. It is advised that any unauthorized use of confidential information of N= uvoton is strictly prohibited; and any information in this email irrelevant= to the official business of Nuvoton shall be deemed as neither given nor e= ndorsed by Nuvoton.