From: Sanjay Embedded_SE <sanjayembeddedse@gmail.com>
To: Matthew Wilcox <willy@infradead.org>
Cc: Vlastimil Babka <vbabka@suse.cz>,
Andrew Morton <akpm@linux-foundation.org>,
Christoph Lameter <cl@gentwo.org>,
David Rientjes <rientjes@google.com>,
Roman Gushchin <roman.gushchin@linux.dev>,
Harry Yoo <harry.yoo@oracle.com>,
"linux-mm@kvack.org" <linux-mm@kvack.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] mm/slub: drop duplicate kernel-doc for ksize()
Date: Tue, 24 Feb 2026 03:10:21 +0000 [thread overview]
Message-ID: <GV2PR04MB12295091C5D832887CBC4C17EAA74A@GV2PR04MB12295.eurprd04.prod.outlook.com> (raw)
In-Reply-To: <aZxvWlsrueUgWuOX@casper.infradead.org>
[-- Attachment #1: Type: text/plain, Size: 577 bytes --]
> Usually we keep the kernel-doc comment with the > implementation, not with
> the prototype.
I agree with you, Kernel-doc comment should be present with implementation.
I have observed that multiple kernel-doc comments are there in slab.h with prototype, would you suggest to replace all possible at once ?
Or with reference to reported warning; we can keep kernel-doc with implementation and remove from prototype and rectify commit message to highlight ideal kernel-doc practice along with existing commit details so context would be better clear and relavent.
[-- Attachment #2: Type: text/html, Size: 1879 bytes --]
next prev parent reply other threads:[~2026-02-24 3:10 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-02-20 12:42 Sanjay Chitroda
2026-02-22 3:47 ` David Rientjes
2026-02-23 13:21 ` Sanjay Chitroda
2026-02-23 15:16 ` Matthew Wilcox
2026-02-24 3:10 ` Sanjay Embedded_SE [this message]
2026-02-24 3:44 ` Sanjay Chitroda
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=GV2PR04MB12295091C5D832887CBC4C17EAA74A@GV2PR04MB12295.eurprd04.prod.outlook.com \
--to=sanjayembeddedse@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=cl@gentwo.org \
--cc=harry.yoo@oracle.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=rientjes@google.com \
--cc=roman.gushchin@linux.dev \
--cc=vbabka@suse.cz \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox