linux-mm.kvack.org archive mirror
 help / color / mirror / Atom feed
From: "schuster.simon@siemens-energy.com" <schuster.simon@siemens-energy.com>
To: David Hildenbrand <david@redhat.com>
Cc: "linux-mm@kvack.org" <linux-mm@kvack.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	Dinh Nguyen <dinguyen@kernel.org>,
	Christian Brauner <brauner@kernel.org>,
	Arnd Bergmann <arnd@arndb.de>,
	Andrew Morton <akpm@linux-foundation.org>,
	Lorenzo Stoakes <lorenzo.stoakes@oracle.com>,
	"Liam R. Howlett" <Liam.Howlett@oracle.com>,
	Vlastimil Babka <vbabka@suse.cz>, Mike Rapoport <rppt@kernel.org>,
	Suren Baghdasaryan <surenb@google.com>,
	Michal Hocko <mhocko@suse.com>, Ingo Molnar <mingo@redhat.com>,
	Peter Zijlstra <peterz@infradead.org>,
	Juri Lelli <juri.lelli@redhat.com>,
	Vincent Guittot <vincent.guittot@linaro.org>,
	Dietmar Eggemann <dietmar.eggemann@arm.com>,
	Steven Rostedt <rostedt@goodmis.org>,
	Ben Segall <bsegall@google.com>, Mel Gorman <mgorman@suse.de>,
	Valentin Schneider <vschneid@redhat.com>,
	Kees Cook <kees@kernel.org>
Subject: Re: [PATCH 1/2] copy_process: Handle architectures where sizeof(unsigned long) < sizeof(u64)
Date: Fri, 22 Aug 2025 08:52:30 +0000	[thread overview]
Message-ID: <FR2P281MB15445D806CF865A0E1CD8FFCB53DA@FR2P281MB1544.DEUP281.PROD.OUTLOOK.COM> (raw)
In-Reply-To: <8c6239a9-8414-469c-9b94-a43735b4e882@redhat.com>

On Thu, Aug 21, 2025 at 11:14:00PM +0200, David Hildenbrand wrote:
> Sounds reasonable.
>
> But is this actually something that is already exposed before patch#2
> on other architectures?

I'm not sure, but I would assume so, as e.g., arch/arm seems to have
support for clone3, but also seems to use 32bit unsigned longs as far as
I can tell and, thus, should also be affected:

$ cat /tmp/printulsize.c
#include <stdio.h>

int main(void) {
	printf("sizeof(unsigned long): %zu\n", sizeof(unsigned long));
}
$ arm-linux-gnueabi-gcc-12 /tmp/printulsize.c -o printulsize
$ qemu-arm -L /usr/arm-linux-gnueabi ./printulsize
sizeof(unsigned long): 4

Is the above test enough to warrant a "Fixes: ", or do we need a
reproduced kselftest failure on some arch for that?

> (I assume above output is with patch #2 but without patch #1)

Yes, sorry, that one is on me; I've naturally first implemented support
for clone3 on nios2 and then investigated the test failures, but somehow
deemed it wise for whatever reason to switch the commit order in the
patch submission...

Best regards,
Simon

  reply	other threads:[~2025-08-22  8:52 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-08-21 11:27 [PATCH 0/2] nios2: Add architecture support for clone3 Simon Schuster via B4 Relay
2025-08-21 11:27 ` [PATCH 1/2] copy_process: Handle architectures where sizeof(unsigned long) < sizeof(u64) Simon Schuster via B4 Relay
2025-08-21 21:14   ` David Hildenbrand
2025-08-22  8:52     ` schuster.simon [this message]
2025-08-22 10:08       ` David Hildenbrand
2025-08-22 12:01         ` schuster.simon
2025-08-22 11:03       ` Arnd Bergmann
2025-08-22 11:22   ` Lorenzo Stoakes
2025-08-21 11:27 ` [PATCH 2/2] nios2: implement architecture-specific portion of sys_clone3 Simon Schuster via B4 Relay

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=FR2P281MB15445D806CF865A0E1CD8FFCB53DA@FR2P281MB1544.DEUP281.PROD.OUTLOOK.COM \
    --to=schuster.simon@siemens-energy.com \
    --cc=Liam.Howlett@oracle.com \
    --cc=akpm@linux-foundation.org \
    --cc=arnd@arndb.de \
    --cc=brauner@kernel.org \
    --cc=bsegall@google.com \
    --cc=david@redhat.com \
    --cc=dietmar.eggemann@arm.com \
    --cc=dinguyen@kernel.org \
    --cc=juri.lelli@redhat.com \
    --cc=kees@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=lorenzo.stoakes@oracle.com \
    --cc=mgorman@suse.de \
    --cc=mhocko@suse.com \
    --cc=mingo@redhat.com \
    --cc=peterz@infradead.org \
    --cc=rostedt@goodmis.org \
    --cc=rppt@kernel.org \
    --cc=surenb@google.com \
    --cc=vbabka@suse.cz \
    --cc=vincent.guittot@linaro.org \
    --cc=vschneid@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox