From: "Prakhya, Sai Praneeth" <sai.praneeth.prakhya@intel.com>
To: Vlastimil Babka <vbabka@suse.cz>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-mm@kvack.org" <linux-mm@kvack.org>
Cc: "Hansen, Dave" <dave.hansen@intel.com>,
Ingo Molnar <mingo@kernel.org>,
Peter Zijlstra <peterz@infradead.org>,
Andrew Morton <akpm@linux-foundation.org>,
Anshuman Khandual <anshuman.khandual@arm.com>
Subject: RE: [PATCH V2] fork: Improve error message for corrupted page tables
Date: Tue, 6 Aug 2019 16:10:16 +0000 [thread overview]
Message-ID: <FFF73D592F13FD46B8700F0A279B802F4FA16EF9@ORSMSX114.amr.corp.intel.com> (raw)
In-Reply-To: <5ba88460-cf01-3d53-6d13-45e650b4eacd@suse.cz>
> > With patch:
> > -----------
> > [ 69.815453] mm/pgtable-generic.c:29: bad p4d
> 0000000084653642(800000025ca37467)
> > [ 69.815872] BUG: Bad rss-counter state mm:00000000014a6c03
> type:MM_FILEPAGES val:2
> > [ 69.815962] BUG: Bad rss-counter state mm:00000000014a6c03
> type:MM_ANONPAGES val:5
> > [ 69.816050] BUG: non-zero pgtables_bytes on freeing mm: 20480
> >
> > Also, change print function (from printk(KERN_ALERT, ..) to
> > pr_alert()) so that it matches the other print statement.
> >
> > Cc: Ingo Molnar <mingo@kernel.org>
> > Cc: Vlastimil Babka <vbabka@suse.cz>
> > Cc: Peter Zijlstra <peterz@infradead.org>
> > Cc: Andrew Morton <akpm@linux-foundation.org>
> > Cc: Anshuman Khandual <anshuman.khandual@arm.com>
> > Acked-by: Dave Hansen <dave.hansen@intel.com>
> > Suggested-by: Dave Hansen <dave.hansen@intel.com>
> > Signed-off-by: Sai Praneeth Prakhya <sai.praneeth.prakhya@intel.com>
>
> Acked-by: Vlastimil Babka <vbabka@suse.cz>
>
> I would also add something like this to reduce risk of breaking it in the
> future:
Sure! Sounds good to me. Will add it to V3.
Regards,
Sai
next prev parent reply other threads:[~2019-08-06 16:10 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-06 3:05 Sai Praneeth Prakhya
2019-08-06 7:53 ` Vlastimil Babka
2019-08-06 8:32 ` Anshuman Khandual
2019-08-06 16:11 ` Prakhya, Sai Praneeth
2019-08-06 16:10 ` Prakhya, Sai Praneeth [this message]
2019-08-06 8:36 ` Michal Hocko
2019-08-06 21:21 ` Sai Praneeth Prakhya
2019-08-06 16:30 ` Dave Hansen
2019-08-06 18:30 ` Sai Praneeth Prakhya
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=FFF73D592F13FD46B8700F0A279B802F4FA16EF9@ORSMSX114.amr.corp.intel.com \
--to=sai.praneeth.prakhya@intel.com \
--cc=akpm@linux-foundation.org \
--cc=anshuman.khandual@arm.com \
--cc=dave.hansen@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mingo@kernel.org \
--cc=peterz@infradead.org \
--cc=vbabka@suse.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox