From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.9 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 135D0C55179 for ; Wed, 21 Oct 2020 17:30:45 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 512B22225F for ; Wed, 21 Oct 2020 17:30:44 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="T1k+ZcQ2" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 512B22225F Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 7C6056B005C; Wed, 21 Oct 2020 13:30:43 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 74F0F6B005D; Wed, 21 Oct 2020 13:30:43 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 5EFE06B0062; Wed, 21 Oct 2020 13:30:43 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0035.hostedemail.com [216.40.44.35]) by kanga.kvack.org (Postfix) with ESMTP id 2F7E76B005C for ; Wed, 21 Oct 2020 13:30:43 -0400 (EDT) Received: from smtpin06.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay03.hostedemail.com (Postfix) with ESMTP id C221D8945730 for ; Wed, 21 Oct 2020 17:30:42 +0000 (UTC) X-FDA: 77396622324.06.title82_49128ca2724a Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin06.hostedemail.com (Postfix) with ESMTP id 01C73103120EC for ; Wed, 21 Oct 2020 17:30:31 +0000 (UTC) X-HE-Tag: title82_49128ca2724a X-Filterd-Recvd-Size: 6130 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [63.128.21.124]) by imf18.hostedemail.com (Postfix) with ESMTP for ; Wed, 21 Oct 2020 17:30:31 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1603301430; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=I1DqumwrHGc6fSk9zZBuFMAirt+Ltz2xHOovX2+UPKY=; b=T1k+ZcQ2uGXA49lIc8EAVYpeB8xhsG8pz271nBvowXseJK5P6EBiL19A0urxQACixFd8A1 fqf9gANeCpfQhn3zkSvebr3MPhGuMArEIBoguagraQzhldZAfTSjzkwe9Lihy+FCMNKxGN I6Ulc8zOuILhwSfnZg06j9BUZomNzFo= Received: from mail-ed1-f72.google.com (mail-ed1-f72.google.com [209.85.208.72]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-564-S4e-VW7FOHyVPFIy-wd36g-1; Wed, 21 Oct 2020 13:30:29 -0400 X-MC-Unique: S4e-VW7FOHyVPFIy-wd36g-1 Received: by mail-ed1-f72.google.com with SMTP id y8so1760657edj.5 for ; Wed, 21 Oct 2020 10:30:28 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:content-transfer-encoding:mime-version:subject :from:in-reply-to:cc:date:message-id:references:to; bh=xK14QpL3GKUFjkKdFe713G5PD83aAbMCe1sf9+K+cAY=; b=LrwkCbmqjrN7PIoOJHECqF9BxYD9xUQoz1uDTc50SsInGS785lCOEQR6CHkoeYTPOC hm482MVCZkVWffGKcNXt85KnbW4NjHkn6H0062me+GU2Vl3/2/Hg82LOCwC3p18J/WQK qhQ8xKJ79+od7PyvRl7TGgwck2p0xGgcB7K4d4JCBTK92cUMxsqYz7Orfjb9X/+F1mWG HhmLl9BdepXpmPNDdp/MWpxtOxHDwjjBm56nzqnP6yJlYsTM/KVaq7UTZyMRNF7ZYK0t oAM7LWGLswUi8AcyWj2JfpJf2LVp6hrNZEN8RltU0SiyDs/oXmLWokxa2DCLEdEMj8PY rbOQ== X-Gm-Message-State: AOAM532o8kdXTDUsFK6f4KUnpGRcyKQNuIq+m6yHUwfee30USSSxeT2C ihv4WJV2rj6V9WsE8pCxbpcfYCdrbkuTMk+NkbyaelU8jyNSN40vRz9/4i6JLl0ULLa3W3batmb 1S31ReiYA9Ok= X-Received: by 2002:a17:907:2677:: with SMTP id ci23mr4533775ejc.270.1603301426590; Wed, 21 Oct 2020 10:30:26 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyobCl+n+APRhXGQt2eHe0a4Q2vF6QNKErLZWR3alp3ZaOvMbaPB4TyHk35mQfTA2Ucqh8G6g== X-Received: by 2002:a17:907:2677:: with SMTP id ci23mr4533750ejc.270.1603301426337; Wed, 21 Oct 2020 10:30:26 -0700 (PDT) Received: from [192.168.3.114] (p5b0c6a39.dip0.t-ipconnect.de. [91.12.106.57]) by smtp.gmail.com with ESMTPSA id f26sm2604346ejx.23.2020.10.21.10.30.25 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 21 Oct 2020 10:30:25 -0700 (PDT) Mime-Version: 1.0 (1.0) Subject: Re: cgroup and FALLOC_FL_PUNCH_HOLE: WARNING: CPU: 13 PID: 2438 at mm/page_counter.c:57 page_counter_uncharge+0x4b/0x5 From: David Hildenbrand In-Reply-To: Cc: David Hildenbrand , Michal Privoznik , Mina Almasry , linux-kernel@vger.kernel.org, linux-mm@kvack.org, "Michael S. Tsirkin" , Michal Hocko , Muchun Song , "Aneesh Kumar K.V" , Tejun Heo Date: Wed, 21 Oct 2020 19:30:23 +0200 Message-Id: References: To: Mike Kravetz X-Mailer: iPhone Mail (18A393) Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=david@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: > Am 21.10.2020 um 18:58 schrieb Mike Kravetz : > =EF=BB=BF >>=20 >>> On 21.10.20 15:11, David Hildenbrand wrote: >>> On 21.10.20 14:57, Michal Privoznik wrote: >>>> On 10/21/20 5:35 AM, Mike Kravetz wrote: >>>>> On 10/20/20 6:38 AM, David Hildenbrand wrote: >>>>> It would be good if Mina (at least) would look these over. Would als= o >>>>> be interesting to know if these fixes address the bug seen with the q= emu >>>>> use case. >>>>> I'm still doing more testing and code inspection to look for other is= sues. > ... > ... >>>> I've applied, rebuilt and tested, but unfortunately I still hit the pr= oblem: >>>> [ 6472.719047] ------------[ cut here ]------------ >>>> [ 6472.719052] WARNING: CPU: 6 PID: 11773 at mm/page_counter.c:57 > ... > ... >>> Agreed, same over here. :( >>=20 >> I *think* the following on top makes it fly >>=20 >> diff --git a/mm/hugetlb.c b/mm/hugetlb.c >> index 67fc6383995b..5cf7f6a6c1a6 100644 >> --- a/mm/hugetlb.c >> +++ b/mm/hugetlb.c >> @@ -656,6 +656,9 @@ static long region_del(struct resv_map *resv, long >> f, long t) >>=20 >> del +=3D t - f; >>=20 >> + hugetlb_cgroup_uncharge_file_region( >> + resv, rg, t - f); >> + >> /* New entry for end of split region */ >> nrg->from =3D t; >> nrg->to =3D rg->to; >> @@ -667,9 +670,6 @@ static long region_del(struct resv_map *resv, long >> f, long t) >> /* Original entry is trimmed */ >> rg->to =3D f; >>=20 >> - hugetlb_cgroup_uncharge_file_region( >> - resv, rg, nrg->to - nrg->from); >> - >> list_add(&nrg->link, &rg->link); >> nrg =3D NULL; >> break; >=20 > Thanks, yes that certainly does look like a bug in that code. >=20 > Does that resolve the issue with quemu? I was not able to reproduce, so I guess we found all issues! Thanks! >=20 > I want to do a little more testing/research before sending a patch later > today. > --=20 > Mike Kravetz