From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 29EC4C2D0CD for ; Sun, 18 May 2025 00:20:14 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id C9D106B0082; Sat, 17 May 2025 20:20:11 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id C4D676B0083; Sat, 17 May 2025 20:20:11 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id AC5506B0085; Sat, 17 May 2025 20:20:11 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 904DD6B0082 for ; Sat, 17 May 2025 20:20:11 -0400 (EDT) Received: from smtpin16.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 0B61BBF30F for ; Sun, 18 May 2025 00:20:13 +0000 (UTC) X-FDA: 83454121506.16.34E6E46 Received: from NAM11-BN8-obe.outbound.protection.outlook.com (mail-bn8nam11on2074.outbound.protection.outlook.com [40.107.236.74]) by imf28.hostedemail.com (Postfix) with ESMTP id 437AEC0003 for ; Sun, 18 May 2025 00:20:10 +0000 (UTC) Authentication-Results: imf28.hostedemail.com; dkim=pass header.d=Nvidia.com header.s=selector2 header.b=OOZJnjl5; dmarc=pass (policy=reject) header.from=nvidia.com; arc=pass ("microsoft.com:s=arcselector10001:i=1"); spf=pass (imf28.hostedemail.com: domain of ziy@nvidia.com designates 40.107.236.74 as permitted sender) smtp.mailfrom=ziy@nvidia.com ARC-Seal: i=2; s=arc-20220608; d=hostedemail.com; t=1747527610; a=rsa-sha256; cv=pass; b=5WOmHudBJ3pk0NW8X57H7Z28NsJkqSN8+QxTXE7JMMKPaHfi23kvv/7dK5bAtyA5LupBh8 siTx9BAzlWRNTo9WNKJtirSqEtRlgwOdiQh+0jOZakEvRTE5dcQjHBO2KGgxTU9GQiBsoC 5DNUl6YlsL2ojxTOuiiB3m0GkBuPRlc= ARC-Authentication-Results: i=2; imf28.hostedemail.com; dkim=pass header.d=Nvidia.com header.s=selector2 header.b=OOZJnjl5; dmarc=pass (policy=reject) header.from=nvidia.com; arc=pass ("microsoft.com:s=arcselector10001:i=1"); spf=pass (imf28.hostedemail.com: domain of ziy@nvidia.com designates 40.107.236.74 as permitted sender) smtp.mailfrom=ziy@nvidia.com ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1747527610; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=FQ7IFYOE/N0zOW/pHvg+Y7HhI600eKtZ1NJ94dTxBws=; b=5/T8ZkUnPFh/Rw79a/1e21NtO2zuOyZ8LNgi/3D6ME3ZJqEJgR/JLWlTc3FDaT3kaaHGJT srnQ0ncZCsulJgtXJJRfkreKBzJ/F7DbFJWoC0wf9d0OwIxxJPNiRi6yaelF8arGHS0DBt AqQJfn0PjVoGZAOk1GtSRHP+hgTJDkk= ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=Jqim8weP9/xTgWIT+MbavKZXoVMgcBCZvu8GXIPtfjJ+6/+t1iLLtCR8GxIzGaxf+6SAn3uNvnL8/r6fdyYLcnNIf/BmptNBSHwbEg1nbaVWIo6AuQMtr24QntWAd2mofpNTZRAxAV96Ai0yRfAgc4zGgLW7IdHV0En3/T8v2TJJ09vCcxKeWmQ0Vd9aRQvfOuv79dcm72mt7c6YfeUWHUbo6ZNO1hrCCW82Ou21jb3Gkw1NQyWrOljzpL8wpZu23q1rELdX6X+6B0ch4TbLzcx3VdFVSnM5N97VaTKNi1YIOTDwV7fkj9MrYadLOCJ5TUMNXxBSuD5oLxhFdGSFZQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=FQ7IFYOE/N0zOW/pHvg+Y7HhI600eKtZ1NJ94dTxBws=; b=vCkALnPAVnHDCHWdZvLcuANb7Ap48mJT+R1q0mAn97DI6mAk3fgKJT3WtXhL+ck26Ul9ZRtVu9fgXoSMZ4c17IxuI+NCsaUc4Cqd0Ic9+fnDBFLo1utfgFmiPcUPl4zrkI0YK07GY09kNWeQlgfQob/hjFzdor0H7ukHFMmqp7SxiQkYA55341xEpBQ0VEikrZ//XUfHhJHlf0poMZZRunUxS0vVLUhfU0E8nxesG8UPD4frrW4aQX9L3JlNv1AU4mlhI5e6al5QpZlrVAzicwNXfkYZlMUKhY7COgPWVQwZAd0e7EhmBBr3QWFzT+2hCVYAe+2Umnosw/CccEPPQA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nvidia.com; dmarc=pass action=none header.from=nvidia.com; dkim=pass header.d=nvidia.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=FQ7IFYOE/N0zOW/pHvg+Y7HhI600eKtZ1NJ94dTxBws=; b=OOZJnjl5IPs8Y0YfYPpNgYD+lfElO3/3ibWeqPvf+jfaPdxD5kOjQVLf4ugUYIOq5mjwefviKIwHKLFfRqODdkkvn6HlHxTP61SNjFMvFI1uf10KIxBald3YMf358aToGb7F3/vuQpwhSYt0P7l6NPt6JB0cto6pykrsF0auhllPvdJXvXYVFpRz1y2sdT8H6Kl6xqSULssnMrV4Gc5v6QbhDiunuetOTbsegdsqep4T3Po6QpoUILrQH+N/CTOUhR210x/4dA2dImncF2tTIz/vmWp4Q1+2UfoHNtwUuZwfg+eJT9Gd1bHJKxzjAG0BrJP8bsJVgrNMp2w8W6G9VQ== Received: from DS7PR12MB9473.namprd12.prod.outlook.com (2603:10b6:8:252::5) by MW6PR12MB8915.namprd12.prod.outlook.com (2603:10b6:303:23e::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8722.33; Sun, 18 May 2025 00:20:05 +0000 Received: from DS7PR12MB9473.namprd12.prod.outlook.com ([fe80::5189:ecec:d84a:133a]) by DS7PR12MB9473.namprd12.prod.outlook.com ([fe80::5189:ecec:d84a:133a%5]) with mapi id 15.20.8722.031; Sun, 18 May 2025 00:20:05 +0000 From: Zi Yan To: Vlastimil Babka Cc: David Hildenbrand , Oscar Salvador , Johannes Weiner , linux-mm@kvack.org, Andrew Morton , Baolin Wang , "Kirill A . Shutemov" , Mel Gorman , Suren Baghdasaryan , Michal Hocko , Brendan Jackman , Richard Chang , linux-kernel@vger.kernel.org Subject: Re: [PATCH v4 0/4] Make MIGRATE_ISOLATE a standalone bit Date: Sat, 17 May 2025 20:20:03 -0400 X-Mailer: MailMate (2.0r6255) Message-ID: In-Reply-To: References: <20250509200111.3372279-1-ziy@nvidia.com> Content-Type: text/plain X-ClientProxiedBy: BN9PR03CA0323.namprd03.prod.outlook.com (2603:10b6:408:112::28) To DS7PR12MB9473.namprd12.prod.outlook.com (2603:10b6:8:252::5) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DS7PR12MB9473:EE_|MW6PR12MB8915:EE_ X-MS-Office365-Filtering-Correlation-Id: 1a51c64c-fdad-4a86-7fb4-08dd95a1bd4b X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|1800799024|366016|376014|7416014; X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?Du2g/hhxGRyup0mCx2TRbeTTa9gQA/m0i9bH5ZXnQWbMeKBvZ9WH9FgzbusZ?= =?us-ascii?Q?g8o+LSrVexWB9C0Y4Ih1jNL2/u8F9/f0kWFko0ku0Xop1ySZ/bmzHMSBxF6l?= =?us-ascii?Q?gdtnhbw6bMG3VyLudpAZCz161y2NuhZ+imtYVVHo3NJReebLuC5Pxp37LF6c?= =?us-ascii?Q?8zahrjoBWenZUaeE318DSvriAGcK+DwLippKfwM04f3pdO2AVaAi/jf6Emr9?= =?us-ascii?Q?G4skU/dP+5aR/bvXUspLt61Vsr21W3OOXKwQSJD7vNriWctjgOVr+NWsUd9y?= =?us-ascii?Q?CvYtPf3pfpUwemJUXsCctwCFbGiEs0uTjq3+zeEYxexsC+usBY9aP/Ta/cte?= =?us-ascii?Q?2A2sKCeji7Db9SqM1YBihHo8dXKnQ7VeNasmh3tzBhWZZJzA6FWI/hHdeftT?= =?us-ascii?Q?Ya5cNLw8yZSXHpSLq4qvgA/kHb2aN9hIOk9XQ6C71QWK0C4NHMvtqdySmx5E?= =?us-ascii?Q?t58iCdXVYFQb/uO+xrLRIrMUNzO0Agg0Rc86iH/yG1rEYkf3ZcVI8nOiYsgy?= =?us-ascii?Q?NMsCxuqV4wr+01ja4jJpnmwlb95lC1AgAozUfB+zQVekhSzRCn6BFxLWDcjC?= =?us-ascii?Q?wChAZcEiudkmHhWZ9co9qfWQrgiRYSIQgi7dq+4VduURjMiLo67Stah32cZA?= =?us-ascii?Q?4Jci9ybuXaDX5D7xW2utu9z5Wpwj/y13PURiOibijovxXO7RFE5EVmUy5hec?= =?us-ascii?Q?Ebz93Ngt/L5TQGoDc9/nW8FvoIVyOn31IIp8qkKEUbtDnohdsCA+g1QFESLM?= =?us-ascii?Q?jAC6QcQFwTG5n4WfgW+uXU8XwqFWCBWsuFT+kB/2Mkr79LjQerHblht9Px0w?= =?us-ascii?Q?sY89KxuAxbrJLALXFxYSybtWLInruQ9XM1S8+s/0xax1DoKgKgM+8W2RniIF?= =?us-ascii?Q?IO1PCEiiH2pqFkewcLIQalXuzG2/AGyFBriPYas3ZYMOcCSmwLZese+zeBwD?= =?us-ascii?Q?And9SRlgJjrSVlDCSCqM5hK5iw6MwgZ1j97N0JOV0ScO7MCRAMCI72o5vR9s?= =?us-ascii?Q?ftyCDEYTmGBtTRAhXLkt5aBIilMuLIFkCgvGNeLrcHagxqrXMiyw58dodI7v?= =?us-ascii?Q?JcGBdKM3NnCTEKDPywwT7v+t4V/WqnAiUNQ4OLlbNPtXK11FTxs1rBcu7ASB?= =?us-ascii?Q?T9V9bjPxb0P++8qi2GIqOn31mmKCepK5a4HijrIdmwUNng95kCYISlLXl1cP?= =?us-ascii?Q?Pg2l5K/UWLb378kN/HDXj+Lqq8P4DtC+e6055DU7Lu/TCOZ1RYv4SgD/+7cr?= =?us-ascii?Q?gsq9GUx+TH4ZIbaDtcIM53LAmjvbDPvb2o4H0QkcNX1JI4kUWdzdjLtIRjGD?= =?us-ascii?Q?D48LmYMMSXTc60b+nUQ/X+p1RG+1qLmZCR0Ui0qotrqEiMO8Q8wE4Vm+c65N?= =?us-ascii?Q?i4Mbce3jfYZkz7WlZ/LlScHwE/UnkRVTx3f05cbk/xPsxAURYl3Gyk5xCqFk?= =?us-ascii?Q?dwAI4z+U3uY=3D?= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS7PR12MB9473.namprd12.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(1800799024)(366016)(376014)(7416014);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?7ZiZ7oIFOQA8byhhXIGFQl/G5516WLSQIRS77I1ArWJOohMhHz31ko8lJB6M?= =?us-ascii?Q?PlQSV40PFQCBVlTkylAKoTB7hKcduwtNzIT1VOuvNu6eTyjL4Gr0Dd7vPfF7?= =?us-ascii?Q?h0n3YFh1QgJDDpaBpiR5vwtQozAXKdwyIXALuQb+u8SopV6Nf3rAXZf2afkU?= =?us-ascii?Q?Pnfg7LpVroerFySYly7Gn9O6qxgFtrRpcXzgKYLMbqLDY3O7L7tKftqtdGTh?= =?us-ascii?Q?dNZ2WOpZ9UIlXNINw2Q9DbEKruOtAlNI7Iemv/euEh3N36V1bXotBt2IJNv5?= =?us-ascii?Q?46H7wkhn+xI8I0eRrF+Vkol20XiZiROHQPCQQtiB8BeOZxkAIwawPfHCJhKf?= =?us-ascii?Q?PYrH5t8WGfi5IwTpWOgF2btvNzDrdBFJilLYbz5sKclLn3ZLGgmMlDCrV/BH?= =?us-ascii?Q?1PEOH+vVBWYviVvvAoIeubwrwUICYf1tvlx3bektl8jGRGNbj8QAJwuPkjI1?= =?us-ascii?Q?aaEtH5oU7himz3MeIH+ABx0hMrGCROemzLASzE/aSzaEunQABfQWrl8NzzWD?= =?us-ascii?Q?iVdimrx7cDogX3G4cFr8sEyT7MdjCsyIUelZ7xi9QQL8xTH1zkjk3SneVjVI?= =?us-ascii?Q?bjomNegZhUkfaUD3YFgbC6SK4eFhMb2TLexKM9O4JYZBuwW/ZbqghyYCrTWB?= =?us-ascii?Q?xkneDrJp7dRJYU0hCTnLBsmRocjO0FpbGh3zIs02UhHJQt+rmzet6WCgUnB9?= =?us-ascii?Q?JWIem8W9KEmFJnYQ2qFnj8HT+0SV6XHiOlSkWPgRjxugvZh3XlgYP98BKzor?= =?us-ascii?Q?prxYDlsWKvYCrOjxzeIXAnCvcIWIRo3DQInOlvJcTVJnDray51O74vmWQorp?= =?us-ascii?Q?mJza7v8Orwlup9oRN+8UQDXDZpOkp51mrPpLK6sD9pguAOkJeeCjiY+P73xu?= =?us-ascii?Q?zFSwgHUvW6Yamfh8O9y8p7AbUH4BhdGy7DRnV6OVsUxkVGUjMJq2KiozA5eI?= =?us-ascii?Q?Sc8Ki0A8n90CzFSFK8bbQknbgSjmHqFlRtuH0jqJ0wUs335ZZmN7hgZVopFz?= =?us-ascii?Q?ietplcJ0tiJK2QC8qEm+95Mhoc5V+Ie4Tre010esW2tH2NRNTrfYcqB5nC2F?= =?us-ascii?Q?mFsTex0qtOHDZiCYqQlAYlwiPzM1QeV1jwvjFXkIUVZ1ed2tHyCx68TOLf0B?= =?us-ascii?Q?tkcRe9jK8rH+erXOqSfDST6GZjqben1aISJt5C8H41J/MgUu/coTUahx1sKF?= =?us-ascii?Q?sGjawApO4xtXWRpZWTMDRFq0xHrQLSxUxhW+ASijJLFCQPkg2AWvKNpPtz5+?= =?us-ascii?Q?YfQylDbIjDCxQcmKxjPimfUzAH9uLpe1chdDp0Y4c4ewqjF5Jaryr9FBiyhk?= =?us-ascii?Q?ywguvmSJhEjZFdKQ9w8QY6pfZk2xfEbNFHEQNM7QNF57bGXxub1hEnPBQMFm?= =?us-ascii?Q?A24ECf8daUP9BVEOLcRXW34xWFgO2G+pXKf6bf/A0DxpoMnLF7x8IT0hSwqa?= =?us-ascii?Q?9Vv8URJu6sIiPyNkatLPB5mjuWm9lG1zdKgQT5sdhKwkBmLqdJjtnCqaHmko?= =?us-ascii?Q?rw+VChUOIbHxN7CjRLpL2zFeqCBO0ay35MUK3iUQwXCC/6OlzChu6ipiZcSy?= =?us-ascii?Q?b/gQ/E3UBRCScIlVvtYdNqgBHp95PhfeZOG0GeQG?= X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-Network-Message-Id: 1a51c64c-fdad-4a86-7fb4-08dd95a1bd4b X-MS-Exchange-CrossTenant-AuthSource: DS7PR12MB9473.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 18 May 2025 00:20:05.6110 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: o0cBrcVbx8K6L/SS1NDI94orKLM7v/ptVCNZmB11Y1Iahs/y6gyIFsVb47kvoPf5 X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW6PR12MB8915 X-Rspam-User: X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: 437AEC0003 X-Stat-Signature: zcsmopxe9knf7wd7hd4k9iuzsc7eibxa X-HE-Tag: 1747527610-653419 X-HE-Meta: U2FsdGVkX1+JSOfbIS8xMkeHtTVGbpTyE9e17ars1GT/wASLwx4dSxYDBRlWGHwQla6nUx3K5Z0JgnKM1VGSQGUFTKQ0oFWINuTfBZ11N4aOUXC0CHzJ0KOMwv+nBUMFf2vKn25QneJjxcQCUWNaHdHptJIdZ91TqpztkuFEPqATg2SLm7OKMx6y707wBOQxDcOc+lAhMRNwqzKnGX3WALFb0qWvSespTNl+Oua95her/HjjG1eKJoMgWYdv5qT+KMFg3o2h3YX0RiMFOzhibyGUxBLiKcO3LI3qOBRHCZWYJj6c/WXeB+kLvaam/4vR8ulN4jqTwDqJt8y4L8PO1vqkdVcBtyQUuOkKN5FnGIk5fKKhrpOVEILr8gHZd5NL2Lrfoy8qE+C5jQWngbC9q7B2VVUkJHxZCIsT+27btREdNKdQMliSWDIZ1Jhc2IWETm1ynLjLu1CjLmfVE4FDHpgF/sDmWPa+fUXjZYeIqVH93Xzuhkftb6YO/qA7tNfLGvAYUDiGlekz99zhv2gk4rTirIojy/HZ2xafiUmWAgH2ZfbnKcZ+rYIU0cfCiWPQb0vcoVatAzBv8/CSxzZA95KYVZAbq8E5rDSLXsjFnNezVgJ7LakDXwF1+HCjYJcTrFEEgZS3CFkncUygc9ZwvAI+vK0W6ZR30AafZxMnoeozlEws5LiFwoWan9W0L0KmPMoLyjM5C0PoHC4b4aKFX6npasxsKOJT61BnKf4MGCvesUn66YH66iJoMq58j3SQ8URp1bt1klUXhuI9Sw39zPOlvlEJz8XCNfG05ReoThyV3pLSQkWzfwjoOh/uDnGuQq9mkMG2k4a5F/8alrVsLvf7rX0evbae6WjfcDWGZeXiEVLa8Xfhb1UqrkgwI+/pdgoBJ3rJdzpQ+4bAqz3L1ZmNppxn1/xdFGZp6jMzBh8qED3W2nCiOD4DI/5BCUYiRcUHexpqVJz502VsJex g2RVi9Yb eJjgy/h519EL2lfcVFnr3vGWCswpn7LSN4Oro+6TrDheLIq/4upQAPzghulfAfEjkv+sI+dM91sCk/NPvwG/jaYuomMYFvmcediHrc1aYhP0Lb6GFunamEqGuWtwL5bH5DSNqYVuQT1n2s06mMKjn2mQsposJf5Jk/L/N5agjoOqyw/1T0AG2kudrQmg8XjpotitSd4tVguw7aljPwWYK2nPb6uqz/t6nFSTD1cdhj7i4qE1JP4tpIiIW4TRTMAjw5DjizdNrVsO3P5l09FNbheWubHofAPKh347iSZCbAzb/6MWPt1EHYnzGsFJA0r8II4r791oCIqXnsZvKP6uhZLbTa8+2z4/1Mb5O6KrzMQoKdV09EVDxEtxKMw== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 17 May 2025, at 16:26, Vlastimil Babka wrote: > On 5/9/25 22:01, Zi Yan wrote: >> Hi David and Oscar, >> >> Can you take a look at Patch 2, which changes how online_pages() set >> online pageblock migratetypes? It used to first set all pageblocks to >> MIGRATE_ISOLATE, then let undo_isolate_page_range() move the pageblocks >> to MIGRATE_MOVABLE. After MIGRATE_ISOLATE becomes a standalone bit, all >> online pageblocks need to have a migratetype other than MIGRATE_ISOLATE. >> Let me know if there is any issue with my changes. >> >> Hi Johannes, >> >> Patch 2 now have set_pageblock_migratetype() not accepting >> MIGRATE_ISOLATE. I think it makes code better. Thank you for the great >> feedback. >> >> Hi all, >> >> This patchset moves MIGRATE_ISOLATE to a standalone bit to avoid >> being overwritten during pageblock isolation process. Currently, >> MIGRATE_ISOLATE is part of enum migratetype (in include/linux/mmzone.h), >> thus, setting a pageblock to MIGRATE_ISOLATE overwrites its original >> migratetype. This causes pageblock migratetype loss during >> alloc_contig_range() and memory offline, especially when the process >> fails due to a failed pageblock isolation and the code tries to undo the >> finished pageblock isolations. > > Seems mostly fine to me, just sent suggestion for 4/4. Thanks. > I was kinda hoping that MIGRATE_ISOLATE could stop being a migratetype. But > I also see that it's useful for it to be because then it means it has the > freelists in the buddy allocator, can work via __move_freepages_block() etc. Yeah, I wanted to remove MIGRATE_ISOLATE from migratetype too, but there is a MIGRATE_ISOLATE freelist and /proc/pagetypeinfo also shows isolated free pages. > Oh well. So it's still a migratetype, but the pageblock handling is now > different. Yep. We also have PB_migrate_skip, a bit in pageblock_bits used for memory compaction and not part of migratetype. -- Best Regards, Yan, Zi