From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id B6B2FC001B0 for ; Tue, 15 Aug 2023 08:37:12 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id F30658D0003; Tue, 15 Aug 2023 04:37:11 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id EDFF38D0001; Tue, 15 Aug 2023 04:37:11 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id DA83F8D0003; Tue, 15 Aug 2023 04:37:11 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id CBA048D0001 for ; Tue, 15 Aug 2023 04:37:11 -0400 (EDT) Received: from smtpin28.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 9517D140959 for ; Tue, 15 Aug 2023 08:37:11 +0000 (UTC) X-FDA: 81125684262.28.DF63DF5 Received: from out-41.mta0.migadu.com (out-41.mta0.migadu.com [91.218.175.41]) by imf30.hostedemail.com (Postfix) with ESMTP id A81D780013 for ; Tue, 15 Aug 2023 08:37:08 +0000 (UTC) Authentication-Results: imf30.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b=vz0KHcPQ; dmarc=pass (policy=none) header.from=linux.dev; spf=pass (imf30.hostedemail.com: domain of muchun.song@linux.dev designates 91.218.175.41 as permitted sender) smtp.mailfrom=muchun.song@linux.dev ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1692088629; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=uBmn5bY96EnmwKJFlv+WltFrhGvpjIbZEKIiYirKvRY=; b=MwVaL7ELIXIZJrw1O5dxtz5zsSxAoGs2q8vOSxWdthvp7pStj+u8AjWAC04cTQ5addHdKe iGDLbTRjn5Xbe/7MAovU9X8VoFWvOe9+NQppBJFsHWZZMlAhJuyb/KRYlgf6Qf2J2CjjwR yzioytwvweuvrMyGu+XJi16XxVb8BHg= ARC-Authentication-Results: i=1; imf30.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b=vz0KHcPQ; dmarc=pass (policy=none) header.from=linux.dev; spf=pass (imf30.hostedemail.com: domain of muchun.song@linux.dev designates 91.218.175.41 as permitted sender) smtp.mailfrom=muchun.song@linux.dev ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1692088629; a=rsa-sha256; cv=none; b=D784MfBODKwo/hx/eEvvfVxuptTfRXKBjG5LD7kll3l1muwrT42lDNffbu92W1Uvpd76fP X7B5ft/PnVeMsh3pZX3xaklcewvb/sd/mv2n5vsEdjiy9VA/DXI8KrEoLF//GG0FnvjHJu rbOz8ezpenNJM3J3H2m1zFc4QuACq/0= Content-Type: text/plain; charset=us-ascii DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1692088626; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=uBmn5bY96EnmwKJFlv+WltFrhGvpjIbZEKIiYirKvRY=; b=vz0KHcPQmyiJWfmlN0KqRtShPV8OO94S7Ve+8NAyKaJzlfD3l3Gwdcs50vzwkyJwFeNk42 wWmdUe83i5yu+zc+P73iwMyGZC6f36VMufdeZyZpMS2xcjecgpOeJWBucmjek3/RmzHbqM Esg+z/IvqlGN9dYsqiRnMi0+1ICkj/k= MIME-Version: 1.0 Subject: Re: [PATCH v4 01/48] mm: move some shrinker-related function declarations to mm/internal.h X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Muchun Song In-Reply-To: <20230807110936.21819-2-zhengqi.arch@bytedance.com> Date: Tue, 15 Aug 2023 16:36:31 +0800 Cc: Andrew Morton , david@fromorbit.com, tkhai@ya.ru, Vlastimil Babka , Roman Gushchin , djwong@kernel.org, Christian Brauner , "Paul E. McKenney" , tytso@mit.edu, steven.price@arm.com, cel@kernel.org, Sergey Senozhatsky , yujie.liu@intel.com, Greg KH , simon.horman@corigine.com, dlemoal@kernel.org, LKML , Linux-MM , x86@kernel.org, kvm@vger.kernel.org, xen-devel@lists.xenproject.org, linux-erofs@lists.ozlabs.org, linux-f2fs-devel@lists.sourceforge.net, cluster-devel@redhat.com, linux-nfs@vger.kernel.org, linux-mtd@lists.infradead.org, rcu@vger.kernel.org, netdev@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-arm-msm@vger.kernel.org, dm-devel@redhat.com, linux-raid@vger.kernel.org, linux-bcache@vger.kernel.org, virtualization@lists.linux-foundation.org, linux-fsdevel@vger.kernel.org, linux-ext4@vger.kernel.org, linux-xfs@vger.kernel.org, linux-btrfs@vger.kernel.org Content-Transfer-Encoding: quoted-printable Message-Id: References: <20230807110936.21819-1-zhengqi.arch@bytedance.com> <20230807110936.21819-2-zhengqi.arch@bytedance.com> To: Qi Zheng X-Migadu-Flow: FLOW_OUT X-Rspamd-Server: rspam09 X-Rspamd-Queue-Id: A81D780013 X-Stat-Signature: q9g34t8t9r8nrhzm1ed9po9oqc4bwimb X-Rspam-User: X-HE-Tag: 1692088628-576195 X-HE-Meta: U2FsdGVkX18xBQyC1/o0mJ9Eu9NcP5K3v61kk387I7peErzYkZVMzd4TmHQdiRQQYD/SxTnkIRxkkbkjNqHItByPn8Qyp9wI5un5L3AZ4/QOtQ1y4gZYbBM4W6fZEaVIyn+GkLC5Sdl5qqinKcNty0BsGOn5a/KNr7yLDz/hIBPOgTCvrYFnYPqeY6KMib92W7TKuoq3mzmAeM1zslneD6wKStcBLLs1GIKt1uxvZpUxlCyKc9WD1rfNLvcl1uU6nJzJMk4kHvRr6MXGoZr4Ag4rR3sGbAp30pGRh2elzVzu1Q76xtPFf8w+qEcrIuNsh9oPVV/CXT6TtW7eMP64HaPLEt/q/PzCf7FryMfOsyvhvavgm/N2rNz+aq8NzbpJ6SvybwCnq9650gI6mrGcPyRhx7n64kWAWucLytESyY1C8SFDZkTj7n5pvRSDxWGMoPAV0+fnObVk3P/r019r2LzG+bYjka2g02WT+cqf9wxd85T97yBgg07h7yl+8DvI7pIOF/RJKMVEhpkg2iiqBR3g/4jGA8/U8/g+l+3VwRPHAD1MaAEqm6LA4ixk6bfaJ1xanIL51cq8A7gwy1zpISjvdTHtXvkFjsqnEnQjCisc1CDAkEJf6F6yHVrHtTNrdUf0TrUo740NYrtK70M/oBBoLmVetbucJ6FIO9Lx7ydQwcGfPFbRdr2hyaHVN73b6KkdceQRNcS+K+legwgZMIFfhJZhaXeiVt10gUWSRpangT1NK8joTwmOrmqsPsTn4ttT+Z9xx5UGSsLnfBW4dd7PsHytVQNVKcNBpk/Ut3+31KALHMwMq6oQazds9dyCsXERe7Yt5iYLkWdPjl0ddtZXK2YbbwCbsq/wJ0cb45CL7KrJv33ZhQ/jDwp1WTvhXPWUoBgeOb8onceEADl4IBbjiutcgMKvHXui0LdCYR8CEjGOCa2Tksw8QkUcgSWGDNQ65ZMZKxm7wrosisF F+A9KGOA 4BcUo7P4iGuJcoHe7HK1mifnGi2yPDQYTz4xxZkHC5J210y5hu0U7BKOS5PWulIFWAkOcrHGOJp7KEebXDEFdIroe4kotoirTfjqkJqEmgqs20grBEZNrBwoZm6RY87Bvyr2nSKIkCsdSFgN+iM1MaznIeYd1aOOX6OoyBdtVYh3eLTk0hw9Ml416CesfPDVATPjf X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: > On Aug 7, 2023, at 19:08, Qi Zheng wrote: >=20 > The following functions are only used inside the mm subsystem, so it's > better to move their declarations to the mm/internal.h file. >=20 > 1. shrinker_debugfs_add() > 2. shrinker_debugfs_detach() > 3. shrinker_debugfs_remove() >=20 > Signed-off-by: Qi Zheng Reviewed-by: Muchun Song One nit bellow. [...] > + > +/* > + * shrinker related functions > + */ This is a multi-comment format. "/* shrinker related functions. */" is the right one-line format of comment. > + > +#ifdef CONFIG_SHRINKER_DEBUG > +extern int shrinker_debugfs_add(struct shrinker *shrinker); > +extern struct dentry *shrinker_debugfs_detach(struct shrinker = *shrinker, > + int *debugfs_id); > +extern void shrinker_debugfs_remove(struct dentry *debugfs_entry, > + int debugfs_id); > +#else /* CONFIG_SHRINKER_DEBUG */ > +static inline int shrinker_debugfs_add(struct shrinker *shrinker) > +{ > + return 0; > +} > +static inline struct dentry *shrinker_debugfs_detach(struct shrinker = *shrinker, > + int *debugfs_id) > +{ > + *debugfs_id =3D -1; > + return NULL; > +} > +static inline void shrinker_debugfs_remove(struct dentry = *debugfs_entry, > + int debugfs_id) > +{ > +} > +#endif /* CONFIG_SHRINKER_DEBUG */ > + > #endif /* __MM_INTERNAL_H */ > --=20 > 2.30.2 >=20