From: William Kucharski <william.kucharski@oracle.com>
To: Peter Xu <peterx@redhat.com>
Cc: LKML <linux-kernel@vger.kernel.org>,
Andrea Arcangeli <aarcange@redhat.com>,
Andrew Morton <akpm@linux-foundation.org>,
Mike Rapoport <rppt@linux.vnet.ibm.com>,
"Kirill A . Shutemov" <kirill@shutemov.name>,
Hugh Dickins <hughd@google.com>,
Pavel Emelyanov <xemul@virtuozzo.com>,
Pravin Shedge <pravin.shedge4linux@gmail.com>,
linux-mm@kvack.org
Subject: Re: [PATCH v2] userfaultfd: clear flag if remap event not enabled
Date: Tue, 11 Dec 2018 06:46:13 -0700 [thread overview]
Message-ID: <FB9EEE4D-B2E6-44B9-9145-259E785AD3F4@oracle.com> (raw)
In-Reply-To: <20181211053409.20317-1-peterx@redhat.com>
> On Dec 10, 2018, at 10:34 PM, Peter Xu <peterx@redhat.com> wrote:
>
> ---
> fs/userfaultfd.c | 10 +++++++++-
> 1 file changed, 9 insertions(+), 1 deletion(-)
>
> diff --git a/fs/userfaultfd.c b/fs/userfaultfd.c
> index cd58939dc977..4567b5b6fd32 100644
> --- a/fs/userfaultfd.c
> +++ b/fs/userfaultfd.c
> @@ -736,10 +736,18 @@ void mremap_userfaultfd_prep(struct vm_area_struct *vma,
> struct userfaultfd_ctx *ctx;
>
> ctx = vma->vm_userfaultfd_ctx.ctx;
> - if (ctx && (ctx->features & UFFD_FEATURE_EVENT_REMAP)) {
> +
> + if (!ctx)
> + return;
> +
> + if (ctx->features & UFFD_FEATURE_EVENT_REMAP) {
> vm_ctx->ctx = ctx;
> userfaultfd_ctx_get(ctx);
> WRITE_ONCE(ctx->mmap_changing, true);
> + } else {
> + /* Drop uffd context if remap feature not enabled */
> + vma->vm_userfaultfd_ctx = NULL_VM_UFFD_CTX;
> + vma->vm_flags &= ~(VM_UFFD_WP | VM_UFFD_MISSING);
> }
> }
>
> --
> 2.17.1
>
Looks good.
Reviewed-by: William Kucharski <william.kucharski@oracle.com>
prev parent reply other threads:[~2018-12-11 13:46 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-11 5:34 Peter Xu
2018-12-11 13:46 ` William Kucharski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=FB9EEE4D-B2E6-44B9-9145-259E785AD3F4@oracle.com \
--to=william.kucharski@oracle.com \
--cc=aarcange@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=hughd@google.com \
--cc=kirill@shutemov.name \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=peterx@redhat.com \
--cc=pravin.shedge4linux@gmail.com \
--cc=rppt@linux.vnet.ibm.com \
--cc=xemul@virtuozzo.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox