From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 97FC4C001DC for ; Wed, 26 Jul 2023 07:57:17 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 17F4A6B0071; Wed, 26 Jul 2023 03:57:17 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 109A66B0074; Wed, 26 Jul 2023 03:57:17 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id EED848D0001; Wed, 26 Jul 2023 03:57:16 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id DF3766B0071 for ; Wed, 26 Jul 2023 03:57:16 -0400 (EDT) Received: from smtpin08.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id A87561C9F0B for ; Wed, 26 Jul 2023 07:57:16 +0000 (UTC) X-FDA: 81053007672.08.87714DC Received: from out-7.mta1.migadu.com (out-7.mta1.migadu.com [95.215.58.7]) by imf21.hostedemail.com (Postfix) with ESMTP id B94671C000D for ; Wed, 26 Jul 2023 07:57:14 +0000 (UTC) Authentication-Results: imf21.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b=wmb9Oc63; spf=pass (imf21.hostedemail.com: domain of muchun.song@linux.dev designates 95.215.58.7 as permitted sender) smtp.mailfrom=muchun.song@linux.dev; dmarc=pass (policy=none) header.from=linux.dev ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1690358235; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=DrTjaApThAuzzzwg/AJ38QfJI73QqK5cZWNfOYAaBzo=; b=uwPAF9LStvZrC4wxoS0xYVrh9lmlJRds4+6zJnT5tnxGnPFMogJj9z5dOePOIuBeVLIybp MaWgumnei0s+khpYLGqshPxWKiYM3NCF/JXOVBZ0tyaeDmWt6EpAoi4b/WgJS1gcpeC9em IxhmzUdExrjJmEP/FKhg4Ou+hNJgXMc= ARC-Authentication-Results: i=1; imf21.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b=wmb9Oc63; spf=pass (imf21.hostedemail.com: domain of muchun.song@linux.dev designates 95.215.58.7 as permitted sender) smtp.mailfrom=muchun.song@linux.dev; dmarc=pass (policy=none) header.from=linux.dev ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1690358235; a=rsa-sha256; cv=none; b=nRB4jrgbPrGpnk0yj7dHT7bWhCPNNtAo+IDkjxhQaepODicC6zvXV0PabAExbils4OmkaA rtuXlq5tzP/ST1bnmbJQWZnmiXL+uXtTMbcy0yF39EpDnFFuDwZxFeZb1CJYQO6pkPHYtt heZ7A9VBlrJuLqbQySOO2eiVQFNemfs= Content-Type: text/plain; charset=us-ascii DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1690358232; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=DrTjaApThAuzzzwg/AJ38QfJI73QqK5cZWNfOYAaBzo=; b=wmb9Oc63rqgJphlqbAiUGQf+QfWRu1BB5RekgtePch6TWeTBhXF8/rZbaJe3xMLy22V28n AB61q+qfNpO4zxg1WfzVWjZzQVs0/ao+ef/zXMB6L8A11iP2pUjCxTGOuptX1W/mgnuJdh cKneJyV5E4YSzAPypp2CHjNMfrcxLhY= MIME-Version: 1.0 Subject: Re: [PATCH v2 42/47] drm/ttm: introduce pool_shrink_rwsem X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Muchun Song In-Reply-To: <20230724094354.90817-43-zhengqi.arch@bytedance.com> Date: Wed, 26 Jul 2023 15:56:40 +0800 Cc: Andrew Morton , david@fromorbit.com, tkhai@ya.ru, Vlastimil Babka , Roman Gushchin , djwong@kernel.org, Christian Brauner , "Paul E. McKenney" , tytso@mit.edu, steven.price@arm.com, cel@kernel.org, Sergey Senozhatsky , yujie.liu@intel.com, gregkh@linuxfoundation.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, x86@kernel.org, kvm@vger.kernel.org, xen-devel@lists.xenproject.org, linux-erofs@lists.ozlabs.org, linux-f2fs-devel@lists.sourceforge.net, cluster-devel@redhat.com, linux-nfs@vger.kernel.org, linux-mtd@lists.infradead.org, rcu@vger.kernel.org, netdev@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-arm-msm@vger.kernel.org, dm-devel@redhat.com, linux-raid@vger.kernel.org, linux-bcache@vger.kernel.org, virtualization@lists.linux-foundation.org, linux-fsdevel@vger.kernel.org, linux-ext4@vger.kernel.org, linux-xfs@vger.kernel.org, linux-btrfs@vger.kernel.org Content-Transfer-Encoding: 7bit Message-Id: References: <20230724094354.90817-1-zhengqi.arch@bytedance.com> <20230724094354.90817-43-zhengqi.arch@bytedance.com> To: Qi Zheng X-Migadu-Flow: FLOW_OUT X-Rspamd-Queue-Id: B94671C000D X-Rspam-User: X-Stat-Signature: hheqzf5fokdrux8iruo1frmss6ps6uhp X-Rspamd-Server: rspam01 X-HE-Tag: 1690358234-4813 X-HE-Meta: U2FsdGVkX1/ghkAU9AY2rlXZxh5VeSCBzno78TjPUyQSX9hVXFagQHm07OaVjPTgwyoI5aAgNXkCFGB4SHGemaTMD2K3euxJObtc42zAhnOiCfWgWsul8L6YCHF0YqwZderNECq9co0Nr3engnsTHJJhkIF6r2ql6lJyHJk4JnPS06lscnt+1VV/sbT6ah8XzOShqdQTDWlwZWxP0u8OQkzhuqi8bhHFJI8lfvzjS8HlifLN6fcbB/mhxFrtOLBEJfSTHwn7gWL23kuYR4II9AlIapGP53Eruh5mk0/Y8rFAcOZ//lkE/68Kdn9AEFshvhPGaofoVvmVrHNUWHw1f/zzQLKr2GNeuft+CCsD7mfypDs7aBKImEnocTokCzMSFRT2eFq/oAr2bWbjux8RHaR02mWksap+tm+U0cgbI/el1I4AtgcawL0e43SnSEwRV9n6bKIYW5R7hl1x/2ZI+w8g40Rx4COf0xUNtUmnSxLd3ZOalauLuiwU3D13jJ1qp0b/LWexthi0sQp/hcVwSY8DSVEzHKp2reKRsOnlKUF1bDae0xwMY1i1eu9nb2OZGCeTDg5Mp7UZsrKLTCczhmEhwrxJ1eEkmqFbw5MpYyQye06GRmJDpKRHEXrOv0gN9kgRDyMI4iZwazdH5GdvIQT41rn6MiRH27A9LVSf2sYI48dEhUTdqGvCl+XL+OhiIzQOd77iokvYhM+eWpwIPuDorBaCJGGT14E/XGDTho+T9qbTwSBb0otHzEHYuXYPJleIJ10vWNrbswEs98HLeo4bpGQEoWQPqyuctCulOzCflrjjIsh37u1rLRaE4TGkN3AoXm8DK/dJWNJWbN3Yg6cwE7wqYhRO4rfq+KHlI4jgQ4/1d2vVb+oZYH5Q1szhwygc5INebv6QQGfV10BC6RIajRCRbccNsA2ArRIlsHUr8Wc96lX3OGkn3vNl7XsXsOHHl4yblk8uPP74Am8 3YpBIy+i e6eUkO18gDwa2P9t0IFg1tVLpYbKyWO3ypnUXZYOMDhzRTh86zsbJCNAqVshhMypszA0sJTlndh0/S1hF56KU3mk6fJ+oEAtcyG9gl7Om71Jfq6oHymw4EzNpII37ZGX1Nnm3zxbiFzz9pXidYtYG8EJ7U6Q4ZSXBMbX6sDQDlPfVbolmuOzBESFBOnpz3kJjZLHk/woQoxp5IGXE0Z0lJEmvWYUN9HUrHWp9Ak6ZdpX326I= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: > On Jul 24, 2023, at 17:43, Qi Zheng wrote: > > Currently, the synchronize_shrinkers() is only used by TTM pool. It only > requires that no shrinkers run in parallel. > > After we use RCU+refcount method to implement the lockless slab shrink, > we can not use shrinker_rwsem or synchronize_rcu() to guarantee that all > shrinker invocations have seen an update before freeing memory. > > So we introduce a new pool_shrink_rwsem to implement a private > synchronize_shrinkers(), so as to achieve the same purpose. > > Signed-off-by: Qi Zheng Reviewed-by: Muchun Song