From: Song Liu <songliubraving@fb.com>
To: "Kirill A. Shutemov" <kirill@shutemov.name>
Cc: linux-kernel <linux-kernel@vger.kernel.org>,
"linux-mm@kvack.org" <linux-mm@kvack.org>,
"namit@vmware.com" <namit@vmware.com>,
"peterz@infradead.org" <peterz@infradead.org>,
"oleg@redhat.com" <oleg@redhat.com>,
"rostedt@goodmis.org" <rostedt@goodmis.org>,
"mhiramat@kernel.org" <mhiramat@kernel.org>,
"matthew.wilcox@oracle.com" <matthew.wilcox@oracle.com>,
"kirill.shutemov@linux.intel.com"
<kirill.shutemov@linux.intel.com>,
Kernel Team <Kernel-team@fb.com>,
"william.kucharski@oracle.com" <william.kucharski@oracle.com>,
"chad.mynhier@oracle.com" <chad.mynhier@oracle.com>,
"mike.kravetz@oracle.com" <mike.kravetz@oracle.com>
Subject: Re: [PATCH uprobe, thp 2/4] uprobe: use original page when all uprobes are removed
Date: Thu, 30 May 2019 17:18:43 +0000 [thread overview]
Message-ID: <F97FB4EB-3416-4BE7-9539-E58A3AD86874@fb.com> (raw)
In-Reply-To: <20190530111739.r6b2hpzjadep4xr5@box>
> On May 30, 2019, at 4:17 AM, Kirill A. Shutemov <kirill@shutemov.name> wrote:
>
> On Wed, May 29, 2019 at 02:20:47PM -0700, Song Liu wrote:
>> @@ -501,6 +512,20 @@ int uprobe_write_opcode(struct arch_uprobe *auprobe, struct mm_struct *mm,
>> copy_highpage(new_page, old_page);
>> copy_to_page(new_page, vaddr, &opcode, UPROBE_SWBP_INSN_SIZE);
>>
>> + index = vaddr_to_offset(vma, vaddr & PAGE_MASK) >> PAGE_SHIFT;
>> + orig_page = find_get_page(vma->vm_file->f_inode->i_mapping, index);
>> + if (orig_page) {
>> + if (memcmp(page_address(orig_page),
>> + page_address(new_page), PAGE_SIZE) == 0) {
>
> Does it work for highmem?
Good catch! I will fix it in v2.
Thanks!
Song
>
>
> --
> Kirill A. Shutemov
next prev parent reply other threads:[~2019-05-30 17:19 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-29 21:20 [PATCH uprobe, thp 0/4] THP aware uprobe Song Liu
2019-05-29 21:20 ` [PATCH uprobe, thp 1/4] mm, thp: allow preallocate pgtable for split_huge_pmd_address() Song Liu
2019-05-30 11:10 ` Kirill A. Shutemov
2019-05-30 11:14 ` Kirill A. Shutemov
2019-05-30 17:23 ` Song Liu
2019-05-29 21:20 ` [PATCH uprobe, thp 2/4] uprobe: use original page when all uprobes are removed Song Liu
2019-05-30 11:17 ` Kirill A. Shutemov
2019-05-30 17:18 ` Song Liu [this message]
2019-05-29 21:20 ` [PATCH uprobe, thp 3/4] uprobe: support huge page by only splitting the pmd Song Liu
2019-05-30 11:08 ` William Kucharski
2019-05-30 17:24 ` Song Liu
2019-05-30 12:14 ` Kirill A. Shutemov
2019-05-30 17:37 ` Song Liu
2019-05-29 21:20 ` [PATCH uprobe, thp 4/4] uprobe: collapse THP pmd after removing all uprobes Song Liu
2019-05-30 12:20 ` Kirill A. Shutemov
2019-05-30 17:26 ` Song Liu
2019-05-31 7:00 ` Kirill A. Shutemov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=F97FB4EB-3416-4BE7-9539-E58A3AD86874@fb.com \
--to=songliubraving@fb.com \
--cc=Kernel-team@fb.com \
--cc=chad.mynhier@oracle.com \
--cc=kirill.shutemov@linux.intel.com \
--cc=kirill@shutemov.name \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=matthew.wilcox@oracle.com \
--cc=mhiramat@kernel.org \
--cc=mike.kravetz@oracle.com \
--cc=namit@vmware.com \
--cc=oleg@redhat.com \
--cc=peterz@infradead.org \
--cc=rostedt@goodmis.org \
--cc=william.kucharski@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox