From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.9 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E5BBEC388F7 for ; Thu, 22 Oct 2020 23:42:53 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 36792223C7 for ; Thu, 22 Oct 2020 23:42:52 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=nvidia.com header.i=@nvidia.com header.b="SZeICWpu" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 36792223C7 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=nvidia.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 44CCD6B005D; Thu, 22 Oct 2020 19:42:52 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 3FE3B6B0062; Thu, 22 Oct 2020 19:42:52 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 2EB9F6B0068; Thu, 22 Oct 2020 19:42:52 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0045.hostedemail.com [216.40.44.45]) by kanga.kvack.org (Postfix) with ESMTP id 038786B005D for ; Thu, 22 Oct 2020 19:42:51 -0400 (EDT) Received: from smtpin16.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay04.hostedemail.com (Postfix) with ESMTP id 8D03B1EE6 for ; Thu, 22 Oct 2020 23:42:51 +0000 (UTC) X-FDA: 77401188942.16.quilt91_3d109fc27255 Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin16.hostedemail.com (Postfix) with ESMTP id 6C93B1010A13C for ; Thu, 22 Oct 2020 23:42:51 +0000 (UTC) X-HE-Tag: quilt91_3d109fc27255 X-Filterd-Recvd-Size: 4490 Received: from hqnvemgate25.nvidia.com (hqnvemgate25.nvidia.com [216.228.121.64]) by imf05.hostedemail.com (Postfix) with ESMTP for ; Thu, 22 Oct 2020 23:42:50 +0000 (UTC) Received: from hqmail.nvidia.com (Not Verified[216.228.121.13]) by hqnvemgate25.nvidia.com (using TLS: TLSv1.2, AES256-SHA) id ; Thu, 22 Oct 2020 16:42:01 -0700 Received: from [10.2.173.3] (10.124.1.5) by HQMAIL107.nvidia.com (172.20.187.13) with Microsoft SMTP Server (TLS) id 15.0.1473.3; Thu, 22 Oct 2020 23:42:48 +0000 From: Zi Yan To: Roman Gushchin CC: Andrew Morton , Joonsoo Kim , Mike Kravetz , , , , Subject: Re: [PATCH v1 0/2] mm: cma: introduce a non-blocking version of cma_release() Date: Thu, 22 Oct 2020 19:42:45 -0400 X-Mailer: MailMate (1.13.2r5673) Message-ID: In-Reply-To: <20201022225308.2927890-1-guro@fb.com> References: <20201022225308.2927890-1-guro@fb.com> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=_MailMate_60AFCD9D-6CCF-4FC6-8444-6B791A110E49_="; micalg=pgp-sha512; protocol="application/pgp-signature" X-Originating-IP: [10.124.1.5] X-ClientProxiedBy: HQMAIL111.nvidia.com (172.20.187.18) To HQMAIL107.nvidia.com (172.20.187.13) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nvidia.com; s=n1; t=1603410121; bh=BQ1JtoBLX9iPDNRiHWm88Fv3CTmOF38m/ARKNeF1qhc=; h=From:To:CC:Subject:Date:X-Mailer:Message-ID:In-Reply-To: References:MIME-Version:Content-Type:X-Originating-IP: X-ClientProxiedBy; b=SZeICWpuZP8ssL95rNG0RAfL+IvAfU1lU+TXYjhwBvCkxJGXY2jLvBk+QzlAeFVpL rehN7YSvM0IUIVCtUITidllzkSMuZJeMZwo/ucDfquOGPrxKTatvCW9Tg+UYGEYMFS KqBVZPscUfQWjxifxmGA52v/EUK40sNI/uagmU2VukFY4l5jiqk4j+g2hku4yM6wAm 7dZRCeSmBv96fctLa6XXDmRhwOTf8lcacE7VWRDpFQad1R7vWtpNKEd940w7qzbGa9 p09dgH4X8E4Qj57Oup1uAu/drt9NWDic5m2VS9MqAwLgHhjDhEyIpZjULCqmw7TBW7 scRMl28O82Eug== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: --=_MailMate_60AFCD9D-6CCF-4FC6-8444-6B791A110E49_= Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On 22 Oct 2020, at 18:53, Roman Gushchin wrote: > This small patchset introduces a non-blocking version of cma_release() > and simplifies the code in hugetlbfs, where previously we had to > temporarily drop hugetlb_lock around the cma_release() call. > > It should help Zi Yan on his work on 1 GB THPs: splitting a gigantic > THP under a memory pressure requires a cma_release() call. If it's Thanks for the patch. But during 1GB THP split, we only clear the bitmaps without releasing the pages. Also in cma_release_nowait(), the first page in the allocated CMA region is reused to store struct cma_clear_bitmap_work, but the same method cannot be used during THP split, since the first page is still in-use. We might need to allocate some new memory for struct cma_clear_bitmap_work, which might not be successful under memory pressure. Any suggestion on where to store struct cma_clear_bitmap_work when I only want to clear bitmap without releasing the pages? Thanks. =E2=80=94 Best Regards, Yan Zi --=_MailMate_60AFCD9D-6CCF-4FC6-8444-6B791A110E49_= Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQJDBAEBCgAtFiEEh7yFAW3gwjwQ4C9anbJR82th+ooFAl+SGPUPHHppeUBudmlk aWEuY29tAAoJEJ2yUfNrYfqKKwwP/3PFE+jf79qDZDHPvFsnYevRicOlgcouKKF/ EEoMbvdcy9pL+zjLeb0Bd61SpwHumiX4kimgQmkY5ZU2VybJODexj1YJtNeM45oR eJ9iyzRhEczyPYhk0IBX8/tu/0wRLCoBtCMEmRuXPPQ5EptZEo9//s/kee1T6R9C 2YlVd3e1znXjnUtTjgE4lo/jj0dlos4Uf4j9HuiGyjB6z0HekIKgpGoKp3TJXgdW H3dRu9bG/mkfk1/AeXl3JKV6BFXZTkE+pM9Qyz2MpATphcXoJ/84ZkA9CJWNVrsE ktc9TnuntzSvml8sePdzsFdVoNq7mxuGJCrjoXgyyimRbUkrr2EFWBYDw0OQJyR6 oowEhXYpLYI1wiftdLUW+EyfUFyTTuEIE9/J0neb3qXzln3lYgsNYi08kCgM7Tha p4JJKqOK05HhDxmnpdingU8p/BHNGKPW8c17dm2e+Ec7pVfc2dnXx4cJ1zpkUQTh fXRMbZic8VeUslb+OyZ0aFsm6uvUHvApBoH58l36mmmtZb+0518xwb1EtUXy4Tlf ZGGLscqkvBtgZALS3XaO/UHiQoe97kQ23QY+2QRFJWpDs4xDIXG/tTHqDkBu1QCY PSm708gUgSftlhkErVNhHMBIRTe/uI94w+wUX+8u0HrrnlXn2NogbV5IEk76vQfA OrGx4Qtt =91mg -----END PGP SIGNATURE----- --=_MailMate_60AFCD9D-6CCF-4FC6-8444-6B791A110E49_=--