From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.9 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1DF80C433E0 for ; Mon, 1 Jun 2020 12:15:23 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id D17A52065C for ; Mon, 1 Jun 2020 12:15:22 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=oracle.com header.i=@oracle.com header.b="DyrTbxqF" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org D17A52065C Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=oracle.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 5EB5C80007; Mon, 1 Jun 2020 08:15:22 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 59CB88E0006; Mon, 1 Jun 2020 08:15:22 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 489EC80007; Mon, 1 Jun 2020 08:15:22 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0095.hostedemail.com [216.40.44.95]) by kanga.kvack.org (Postfix) with ESMTP id 2E30E8E0006 for ; Mon, 1 Jun 2020 08:15:22 -0400 (EDT) Received: from smtpin29.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay01.hostedemail.com (Postfix) with ESMTP id C1F93180AD822 for ; Mon, 1 Jun 2020 12:15:21 +0000 (UTC) X-FDA: 76880538042.29.fact35_68f15eaf9260b Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin29.hostedemail.com (Postfix) with ESMTP id AAB6618086CB5 for ; Mon, 1 Jun 2020 12:15:21 +0000 (UTC) X-HE-Tag: fact35_68f15eaf9260b X-Filterd-Recvd-Size: 4331 Received: from aserp2120.oracle.com (aserp2120.oracle.com [141.146.126.78]) by imf28.hostedemail.com (Postfix) with ESMTP for ; Mon, 1 Jun 2020 12:15:20 +0000 (UTC) Received: from pps.filterd (aserp2120.oracle.com [127.0.0.1]) by aserp2120.oracle.com (8.16.0.42/8.16.0.42) with SMTP id 051CCewJ020300; Mon, 1 Jun 2020 12:15:08 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=content-type : mime-version : subject : from : in-reply-to : date : cc : content-transfer-encoding : message-id : references : to; s=corp-2020-01-29; bh=pvydvjMPABjwOlqsP5kdKbFFDQuUrxgL69D4P2Biz38=; b=DyrTbxqFQaavRbPM5cYSYMlMsXJCcJwckQmQoQwMoMSx2zLrvtjt1DF5vyypbwUMzWKU ajbvzSFeU5iEnxjoeDiPodxC7yWkYIdro9C2lrJlaQVPfK5XQoZ7G7a7bFUWsDzLidbG QX3thtPEKa9NahrSDGMQvDXj1u2S/5FW4LP3xkE/kensCoRHF+Ge5H8OKbwE6amDqu9Q xfK6HReb7qQzOndOC9Th76PZB6nabubRo2fLusnDU0OHn0782J+z4ucLkQlIhwZRY/tq dfpXquY0uzlmM4f8BrGjIAs393GyX6nGBofVyomopJU+9A4OVLF/nch8FBbXwmWcFgq4 /g== Received: from aserp3030.oracle.com (aserp3030.oracle.com [141.146.126.71]) by aserp2120.oracle.com with ESMTP id 31bfekxcb0-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL); Mon, 01 Jun 2020 12:15:08 +0000 Received: from pps.filterd (aserp3030.oracle.com [127.0.0.1]) by aserp3030.oracle.com (8.16.0.42/8.16.0.42) with SMTP id 051CDMGr143797; Mon, 1 Jun 2020 12:15:08 GMT Received: from aserv0122.oracle.com (aserv0122.oracle.com [141.146.126.236]) by aserp3030.oracle.com with ESMTP id 31c12mdxeh-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Mon, 01 Jun 2020 12:15:07 +0000 Received: from abhmp0007.oracle.com (abhmp0007.oracle.com [141.146.116.13]) by aserv0122.oracle.com (8.14.4/8.14.4) with ESMTP id 051CF6BP013083; Mon, 1 Jun 2020 12:15:06 GMT Received: from [192.168.0.110] (/73.243.10.6) by default (Oracle Beehive Gateway v4.0) with ESMTP ; Mon, 01 Jun 2020 05:15:06 -0700 Content-Type: text/plain; charset=us-ascii Mime-Version: 1.0 (Mac OS X Mail 13.4 \(3608.80.23.2.2\)) Subject: Re: [PATCH] mm: Remove misleading comment From: William Kucharski In-Reply-To: <20200529123243.20640-1-willy@infradead.org> Date: Mon, 1 Jun 2020 06:15:05 -0600 Cc: Andrew Morton , linux-mm@kvack.org Content-Transfer-Encoding: 7bit Message-Id: References: <20200529123243.20640-1-willy@infradead.org> To: Matthew Wilcox X-Mailer: Apple Mail (2.3608.80.23.2.2) X-Proofpoint-Virus-Version: vendor=nai engine=6000 definitions=9638 signatures=668686 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 mlxscore=0 phishscore=0 malwarescore=0 adultscore=0 suspectscore=0 spamscore=0 bulkscore=0 mlxlogscore=999 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2004280000 definitions=main-2006010091 X-Proofpoint-Virus-Version: vendor=nai engine=6000 definitions=9638 signatures=668686 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 malwarescore=0 suspectscore=0 mlxlogscore=999 priorityscore=1501 bulkscore=0 phishscore=0 clxscore=1015 impostorscore=0 adultscore=0 spamscore=0 mlxscore=0 lowpriorityscore=0 cotscore=-2147483648 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2004280000 definitions=main-2006010091 X-Rspamd-Queue-Id: AAB6618086CB5 X-Spamd-Result: default: False [0.00 / 100.00] X-Rspamd-Server: rspam04 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000075, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: > On May 29, 2020, at 6:32 AM, Matthew Wilcox wrote: > > From: "Matthew Wilcox (Oracle)" > > We no longer return 0 here and the comment doesn't tell us anything > that we don't already know (SIGBUS is a pretty good indicator that > things didn't work out). > > Signed-off-by: Matthew Wilcox (Oracle) > --- > mm/filemap.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/mm/filemap.c b/mm/filemap.c > index 23a051a7ef0f..fe079e9219d1 100644 > --- a/mm/filemap.c > +++ b/mm/filemap.c > @@ -2566,7 +2566,6 @@ vm_fault_t filemap_fault(struct vm_fault *vmf) > if (!error || error == AOP_TRUNCATED_PAGE) > goto retry_find; > > - /* Things didn't work out. Return zero to tell the mm layer so. */ > shrink_readahead_size_eio(ra); > return VM_FAULT_SIGBUS; Reviewed-by: William Kucharski