From: Qian Cai <cai@lca.pw>
To: Christoph Hellwig <hch@infradead.org>
Cc: Alex Shi <alex.shi@linux.alibaba.com>,
Andrew Morton <akpm@linux-foundation.org>,
linux-mm@kvack.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] mm/vmscan: remove prefetch_prev_lru_page
Date: Wed, 15 Jan 2020 13:27:57 -0500 [thread overview]
Message-ID: <F5F5B735-2BEA-4B9D-8939-B24B9D9AA940@lca.pw> (raw)
In-Reply-To: <20200115082947.GA21018@infradead.org>
> On Jan 15, 2020, at 3:29 AM, Christoph Hellwig <hch@infradead.org> wrote:
>
> On Tue, Jan 14, 2020 at 08:46:21AM -0500, Qian Cai wrote:
>>
>>
>>> On Jan 14, 2020, at 7:55 AM, Alex Shi <alex.shi@linux.alibaba.com> wrote:
>>>
>>> This macro are never used in git history. So better to remove.
>>
>> When removing unused thingy, it is important to figure out which commit introduced it in the first place and Cc the relevant people in that commit.
>
> No, it isn't. It is at best nice to have, but for a trivial macro
> really doesn't matter.
A more of personal taste what the trivial macro is. I’d rather be on the caution side
when removing code especially nowaday developers may not even compile
test the patch properly given how many arches we have here which will only waste
time on other people when things goes wrong.
prev parent reply other threads:[~2020-01-15 18:28 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-14 12:55 Alex Shi
2020-01-14 13:46 ` Qian Cai
2020-01-15 2:31 ` Alex Shi
2020-01-16 12:26 ` Qian Cai
2020-01-16 23:37 ` Andrew Morton
2020-01-16 13:18 ` Guoqing Jiang
2020-01-15 8:29 ` Christoph Hellwig
2020-01-15 18:27 ` Qian Cai [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=F5F5B735-2BEA-4B9D-8939-B24B9D9AA940@lca.pw \
--to=cai@lca.pw \
--cc=akpm@linux-foundation.org \
--cc=alex.shi@linux.alibaba.com \
--cc=hch@infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox