From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-16.1 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id AC530C433E0 for ; Wed, 27 Jan 2021 15:58:15 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 0F27C207C4 for ; Wed, 27 Jan 2021 15:58:14 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 0F27C207C4 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=nvidia.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id ECCD86B006C; Wed, 27 Jan 2021 10:58:13 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id E7BFD6B006E; Wed, 27 Jan 2021 10:58:13 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id CF54B6B0070; Wed, 27 Jan 2021 10:58:13 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0206.hostedemail.com [216.40.44.206]) by kanga.kvack.org (Postfix) with ESMTP id B533D6B006C for ; Wed, 27 Jan 2021 10:58:13 -0500 (EST) Received: from smtpin16.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay01.hostedemail.com (Postfix) with ESMTP id 7A365180AD81D for ; Wed, 27 Jan 2021 15:58:13 +0000 (UTC) X-FDA: 77752011666.16.sun16_041599a27598 Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin16.hostedemail.com (Postfix) with ESMTP id 454EA100E6912 for ; Wed, 27 Jan 2021 15:58:13 +0000 (UTC) X-HE-Tag: sun16_041599a27598 X-Filterd-Recvd-Size: 5797 Received: from hqnvemgate25.nvidia.com (hqnvemgate25.nvidia.com [216.228.121.64]) by imf27.hostedemail.com (Postfix) with ESMTP for ; Wed, 27 Jan 2021 15:58:12 +0000 (UTC) Received: from hqmail.nvidia.com (Not Verified[216.228.121.13]) by hqnvemgate25.nvidia.com (using TLS: TLSv1.2, AES256-SHA) id ; Wed, 27 Jan 2021 07:58:11 -0800 Received: from [10.2.60.78] (172.20.145.6) by HQMAIL107.nvidia.com (172.20.187.13) with Microsoft SMTP Server (TLS) id 15.0.1473.3; Wed, 27 Jan 2021 15:58:09 +0000 From: Zi Yan To: David Hildenbrand CC: , , Andrew Morton , Thomas Gleixner , "Peter Zijlstra (Intel)" , Mike Rapoport , Oscar Salvador , Michal Hocko , Wei Yang Subject: Re: [PATCH v1 1/2] mm/cma: expose all pages to the buddy if activation of an area fails Date: Wed, 27 Jan 2021 10:58:07 -0500 X-Mailer: MailMate (1.14r5757) Message-ID: In-Reply-To: <20210127101813.6370-2-david@redhat.com> References: <20210127101813.6370-1-david@redhat.com> <20210127101813.6370-2-david@redhat.com> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=_MailMate_C33B7D64-5C83-4FBC-BA12-F7A9307092F5_="; micalg=pgp-sha512; protocol="application/pgp-signature" X-Originating-IP: [172.20.145.6] X-ClientProxiedBy: HQMAIL111.nvidia.com (172.20.187.18) To HQMAIL107.nvidia.com (172.20.187.13) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nvidia.com; s=n1; t=1611763091; bh=9f29pbSqkFcdd7oAkk+SxFMIq+bbPbn8eq0ySyEkrP8=; h=From:To:CC:Subject:Date:X-Mailer:Message-ID:In-Reply-To: References:MIME-Version:Content-Type:X-Originating-IP: X-ClientProxiedBy; b=ah2XlkaWBFiiZS0L9idrb9CF+xCVfPvoK3ioAPJQ4Uhc0WVBrrMJPJA8RUI/PRWmp Nn7Cf34Ip2pyzXs8ESvPdjyJtPMIsttP58MurpzmtYX0QOc7WjzFCh+f6Yccole0wO gkTZUW5ZMcR7kT55+8CYBNJNpMMI13q+3+dW6ER7YBe+cadDphDNWIfU4/bJ8Cxx// X+Yzx1AdQiBb66jOWBZ9Zmi+Qw+WJ0sOvSjhawUlMBNrVktOfwcuPtwaE3LuYPlfnW H5k8LQMj3hDXeXXbHjBK2kB71uHI+/Qd+quW1j+XJxspawmdXYb5KLyfdssuxAa8aY 4rkT6re6/mE6g== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: --=_MailMate_C33B7D64-5C83-4FBC-BA12-F7A9307092F5_= Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On 27 Jan 2021, at 5:18, David Hildenbrand wrote: > Right now, if activation fails, we might already have exposed some page= s to > the buddy for CMA use (although they will never get actually used by CM= A), > and some pages won't be exposed to the buddy at all. > > Let's check for "single zone" early and on error, don't expose any page= s > for CMA use - instead, expose them to the buddy available for any use. > Simply call free_reserved_page() on every single page - easier than > going via free_reserved_area(), converting back and forth between pfns > and virt addresses. > > In addition, make sure to fixup totalcma_pages properly. > > Example: 6 GiB QEMU VM with "... hugetlb_cma=3D2G movablecore=3D20% ...= ": > [ 0.006891] hugetlb_cma: reserve 2048 MiB, up to 2048 MiB per node= > [ 0.006893] cma: Reserved 2048 MiB at 0x0000000100000000 > [ 0.006893] hugetlb_cma: reserved 2048 MiB on node 0 > ... > [ 0.175433] cma: CMA area hugetlb0 could not be activated > > Before this patch: > # cat /proc/meminfo > MemTotal: 5867348 kB > MemFree: 5692808 kB > MemAvailable: 5542516 kB > ... > CmaTotal: 2097152 kB > CmaFree: 1884160 kB > > After this patch: > # cat /proc/meminfo > MemTotal: 6077308 kB > MemFree: 5904208 kB > MemAvailable: 5747968 kB > ... > CmaTotal: 0 kB > CmaFree: 0 kB > > Note: cma_init_reserved_mem() makes sure that we always cover full > pageblocks / MAX_ORDER - 1 pages. > > Cc: Andrew Morton > Cc: Thomas Gleixner > Cc: "Peter Zijlstra (Intel)" > Cc: Mike Rapoport > Cc: Oscar Salvador > Cc: Michal Hocko > Cc: Wei Yang > Signed-off-by: David Hildenbrand > --- > mm/cma.c | 43 +++++++++++++++++++++---------------------- > 1 file changed, 21 insertions(+), 22 deletions(-) LGTM. Reviewed-by: Zi Yan =E2=80=94 Best Regards, Yan Zi --=_MailMate_C33B7D64-5C83-4FBC-BA12-F7A9307092F5_= Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQJDBAEBCgAtFiEEh7yFAW3gwjwQ4C9anbJR82th+ooFAmARjY8PHHppeUBudmlk aWEuY29tAAoJEJ2yUfNrYfqKyU4P/22fuj51aHN6OYJfCdJFXadykeJMaDU8w57E P7k1tXv7vtcg7TWJBZLNLLVNU8myIzGs2Buj948GqSv0eiRzIElRx/5XWIjA6zz2 JJw8uY8NfoQcma0ooVxO7rf7TYU0sqwVXMy55yKvnP0jmMqnvcxgh4w47tWJHgno 8PiC49x00WmS6V/LO4/ve2qe65un0u7moyaf+7Ev1h9n2Dk9t8yR6jTAoq0nUIUo uRyuX0Rhc3o/1aic9vbN1aT/CF9b23utOdiwjGo2cWn0lIL8CLZKJ1Cu6UXsjV80 upibyL6hfsy8oXfH81BbLcuCCbslLKyxm+MPaAk81HgVdg9S0Joho6PGR82tpkmO 3vlIkhrNQ0USB9XaqJr2eYs8t2Zu0kABmonuJbbArBwDmRrDc5E5XKNgTA1XztiD Gxr2W85AJBexWySTc68YQEWJUhL+LJ5cqCsQg/C835ZLXGEMgirBiXeKzybTwwhh FbBiFzHFb5sN0aVC9RfM3IPQJ/dSWK3kIBe4l3EVS6Z0mWKzBAtJ54JOiTQSU5Ke MUBrvYUeFJdpaghds4G8iTfovDDyuG6UbZnK8v+/HdA2Z2RCvLTsDeMCziqvDtrh 6iT5Uu4GbXb62iAFtAtU5Ll+5K1s5YXa8I1vCWPGcKM3bqH/IFTBLzz4R+OR2Wkl F4+Y+kxh =drxX -----END PGP SIGNATURE----- --=_MailMate_C33B7D64-5C83-4FBC-BA12-F7A9307092F5_=--