From: "Li, Liang Z" <liang.z.li@intel.com>
To: "Michael S. Tsirkin" <mst@redhat.com>
Cc: Rik van Riel <riel@redhat.com>,
"viro@zeniv.linux.org.uk" <viro@zeniv.linux.org.uk>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"quintela@redhat.com" <quintela@redhat.com>,
"amit.shah@redhat.com" <amit.shah@redhat.com>,
"pbonzini@redhat.com" <pbonzini@redhat.com>,
"dgilbert@redhat.com" <dgilbert@redhat.com>,
"linux-mm@kvack.org" <linux-mm@kvack.org>,
"kvm@vger.kernel.org" <kvm@vger.kernel.org>,
"qemu-devel@nongnu.org" <qemu-devel@nongnu.org>,
"agraf@suse.de" <agraf@suse.de>,
"borntraeger@de.ibm.com" <borntraeger@de.ibm.com>
Subject: RE: [PATCH kernel 1/2] mm: add the related functions to build the free page bitmap
Date: Wed, 20 Apr 2016 01:41:24 +0000 [thread overview]
Message-ID: <F2CBF3009FA73547804AE4C663CAB28E0418339F@shsmsx102.ccr.corp.intel.com> (raw)
In-Reply-To: <20160419191111-mutt-send-email-mst@redhat.com>
> Cc: Rik van Riel; viro@zeniv.linux.org.uk; linux-kernel@vger.kernel.org;
> quintela@redhat.com; amit.shah@redhat.com; pbonzini@redhat.com;
> dgilbert@redhat.com; linux-mm@kvack.org; kvm@vger.kernel.org; qemu-
> devel@nongnu.org; agraf@suse.de; borntraeger@de.ibm.com
> Subject: Re: [PATCH kernel 1/2] mm: add the related functions to build the
> free page bitmap
>
> On Tue, Apr 19, 2016 at 03:02:09PM +0000, Li, Liang Z wrote:
> > > On Tue, 2016-04-19 at 22:34 +0800, Liang Li wrote:
> > > > The free page bitmap will be sent to QEMU through virtio interface
> > > > and used for live migration optimization.
> > > > Drop the cache before building the free page bitmap can get more
> > > > free pages. Whether dropping the cache is decided by user.
> > > >
> > >
> > > How do you prevent the guest from using those recently-freed pages
> > > for something else, between when you build the bitmap and the live
> > > migration completes?
> >
> > Because the dirty page logging is enabled before building the bitmap,
> > there is no need to prevent the guest from using the recently-freed
> pages ...
> >
> > Liang
>
> Well one point of telling host that page is free is so that it can mark it clean
> even if it was dirty previously.
> So I think you must pass the pages to guest under the lock.
Thanks! You mean save the free page bitmap in host pages?
> This will allow host optimizations such as marking these pages
> MADV_DONTNEED or MADV_FREE
> Otherwise it's all too tied up to a specific usecase - you aren't telling host that
> a page is free, you are telling it that a page was free in the past.
>
Then we should prevent the guest from using those recently-freed pages,
before doing the MADV_DONTNEED or MADV_FREE, or the pages in the
free page bitmap may be not free any more. In which case we will do something
like this? Balloon?
Liang
> --
> MST
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2016-04-20 1:41 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-19 14:34 [PATCH kernel 0/2] speed up live migration by skipping free pages Liang Li
2016-04-19 14:34 ` [PATCH kernel 1/2] mm: add the related functions to build the free page bitmap Liang Li
2016-04-19 14:54 ` Rik van Riel
2016-04-19 15:02 ` Li, Liang Z
2016-04-19 15:26 ` Rik van Riel
2016-04-20 0:57 ` Li, Liang Z
2016-04-19 16:15 ` Michael S. Tsirkin
2016-04-20 1:41 ` Li, Liang Z [this message]
2016-04-21 13:48 ` Michael S. Tsirkin
2016-04-22 1:36 ` Li, Liang Z
2016-04-22 9:48 ` Dr. David Alan Gilbert
2016-04-22 13:58 ` Michael S. Tsirkin
2016-04-25 3:11 ` Li, Liang Z
2016-04-25 10:43 ` Michael S. Tsirkin
2016-04-26 3:21 ` Li, Liang Z
2016-04-19 14:56 ` kbuild test robot
2016-04-19 16:01 ` kbuild test robot
2016-04-19 16:14 ` kbuild test robot
2016-04-19 14:34 ` [PATCH kernel 2/2] virtio-balloon: extend balloon driver to support the new feature Liang Li
2016-04-19 16:18 ` Michael S. Tsirkin
2016-04-25 6:06 ` [PATCH kernel 0/2] speed up live migration by skipping free pages Amit Shah
2016-04-25 11:04 ` Michael S. Tsirkin
2016-04-25 12:08 ` Amit Shah
2016-04-25 12:51 ` Michael S. Tsirkin
2016-04-25 13:17 ` Dr. David Alan Gilbert
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=F2CBF3009FA73547804AE4C663CAB28E0418339F@shsmsx102.ccr.corp.intel.com \
--to=liang.z.li@intel.com \
--cc=agraf@suse.de \
--cc=amit.shah@redhat.com \
--cc=borntraeger@de.ibm.com \
--cc=dgilbert@redhat.com \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mst@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=quintela@redhat.com \
--cc=riel@redhat.com \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox