From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 04A73C433E0 for ; Thu, 28 Jan 2021 22:03:54 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 5F86160C40 for ; Thu, 28 Jan 2021 22:03:53 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 5F86160C40 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id B418E6B0005; Thu, 28 Jan 2021 17:03:52 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id AF26F6B0006; Thu, 28 Jan 2021 17:03:52 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 9BAB86B006C; Thu, 28 Jan 2021 17:03:52 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0126.hostedemail.com [216.40.44.126]) by kanga.kvack.org (Postfix) with ESMTP id 86C286B0005 for ; Thu, 28 Jan 2021 17:03:52 -0500 (EST) Received: from smtpin13.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay05.hostedemail.com (Postfix) with ESMTP id 519E2181AEF30 for ; Thu, 28 Jan 2021 22:03:52 +0000 (UTC) X-FDA: 77756561904.13.wave91_5a0204f275a3 Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin13.hostedemail.com (Postfix) with ESMTP id 319AA18140B74 for ; Thu, 28 Jan 2021 22:03:52 +0000 (UTC) X-HE-Tag: wave91_5a0204f275a3 X-Filterd-Recvd-Size: 5680 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf05.hostedemail.com (Postfix) with ESMTP for ; Thu, 28 Jan 2021 22:03:51 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1611871430; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=HiRo01xvv1ratZMgs1U3MFKJ55kQXOvIZtuVl9DxNIQ=; b=ZJdHoJQs+OwWJc9bxrq2dEQNA1yohEgZxOOEx0SrLS2iGzY/NXtGlrm9QOMPT7EyYrI5VN Pb6QM4zNMCZ5jit3dTUZxVzNOkKLmIHpe7NpzXuM92xu+JVmtBUy2bwyurq6a0MvBM+vM9 YokwIkzeIfv1VTZx97Qfa5XAZZ5+eRE= Received: from mail-wr1-f72.google.com (mail-wr1-f72.google.com [209.85.221.72]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-18-JjJgVOJ6PP2SjSzWagblwA-1; Thu, 28 Jan 2021 17:03:49 -0500 X-MC-Unique: JjJgVOJ6PP2SjSzWagblwA-1 Received: by mail-wr1-f72.google.com with SMTP id d7so3855244wri.23 for ; Thu, 28 Jan 2021 14:03:48 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:content-transfer-encoding:from:mime-version :subject:date:message-id:references:cc:in-reply-to:to; bh=wfY5AvEwsoH+kbk1QwL4Ppj2/ZQAB0t6+ns8YqF9dOI=; b=ZOGVri+RfUBuPpCUAgVDkuFKqBmpkXEtV5RWsbb+mFg9EzUt0dr3WpF6kd9uC6jzzm lZpTfkzL0fMC26Dk1KyPfMZhxLjmiJqsNh3gwcPO+lkmAdSfEMDFRI0jwVbXO9iVYDGT Uk3RwsFiXbQxTAHZu/KAejvlWF1VJi/S/MMY0GthU4+xq8kVepG0yPTaTqgmIdEg0jJd tpaBcNVBiQ5VchyhRdaLwtcrzfLEyS6EZILjP+2HMfoPl1uMD5LV3B3MWXYOgyb853cu jU+Ea8BjmXmxpA4QnseJccACaZIUC2TdnvvDeqv9NQJ8YgI3atOTxN0eOitm+Atjvtf0 6KYg== X-Gm-Message-State: AOAM533SxwUBjQPn62PBONqLMCgSW8ZULpLNIURTce1wk1Sf7smDfhxy 2TocW+M/kNll/XLnY4Fks04MenxuFIh4CqC4efRR4AOTEmpsEn90b0iBvDAsXNKS+6taD+5YFU/ g5bANANWss2w= X-Received: by 2002:a5d:4f87:: with SMTP id d7mr1104978wru.385.1611871426952; Thu, 28 Jan 2021 14:03:46 -0800 (PST) X-Google-Smtp-Source: ABdhPJysqQfhWq7XvaSq0pHnWrOtVEhYLmCkcoS1wdNrN0T+39kv0KDA3j3fod8WE49oA05WGDtjug== X-Received: by 2002:a5d:4f87:: with SMTP id d7mr1104947wru.385.1611871426710; Thu, 28 Jan 2021 14:03:46 -0800 (PST) Received: from [192.168.3.108] (p5b0c66c6.dip0.t-ipconnect.de. [91.12.102.198]) by smtp.gmail.com with ESMTPSA id u5sm7723931wmg.9.2021.01.28.14.03.45 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 28 Jan 2021 14:03:46 -0800 (PST) From: David Hildenbrand Mime-Version: 1.0 (1.0) Subject: Re: [PATCH v2] mm/page_alloc: count CMA pages per zone and print them in /proc/zoneinfo Date: Thu, 28 Jan 2021 23:03:44 +0100 Message-Id: References: <6d9cff33-39c1-ef8e-a18e-c865b95240b6@google.com> Cc: David Hildenbrand , linux-kernel@vger.kernel.org, linux-mm@kvack.org, Andrew Morton , Thomas Gleixner , "Peter Zijlstra (Intel)" , Mike Rapoport , Oscar Salvador , Michal Hocko , Wei Yang , linux-api@vger.kernel.org In-Reply-To: <6d9cff33-39c1-ef8e-a18e-c865b95240b6@google.com> To: David Rientjes X-Mailer: iPhone Mail (18C66) Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=david@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: > Am 28.01.2021 um 22:54 schrieb David Rientjes : >=20 > =EF=BB=BFOn Thu, 28 Jan 2021, David Hildenbrand wrote: >=20 >> diff --git a/mm/vmstat.c b/mm/vmstat.c >> index 7758486097f9..957680db41fa 100644 >> --- a/mm/vmstat.c >> +++ b/mm/vmstat.c >> @@ -1650,6 +1650,11 @@ static void zoneinfo_show_print(struct seq_file *= m, pg_data_t *pgdat, >> zone->spanned_pages, >> zone->present_pages, >> zone_managed_pages(zone)); >> +#ifdef CONFIG_CMA >> + seq_printf(m, >> + "\n cma %lu", >> + zone->cma_pages); >> +#endif >>=20 >> seq_printf(m, >> "\n protection: (%ld", >=20 > Hmm, not sure about this. If cma is only printed for CONFIG_CMA, we can'= t=20 > distinguish between (1) a kernel without your patch without including som= e=20 > version checking and (2) a kernel without CONFIG_CMA enabled. IOW,=20 > "cma 0" carries value: we know immediately that we do not have any CMA=20 > pages on this zone, period. >=20 > /proc/zoneinfo is also not known for its conciseness so I think printing= =20 > "cma 0" even for !CONFIG_CMA is helpful :) >=20 > I think this #ifdef should be removed and it should call into a=20 > zone_cma_pages(struct zone *zone) which returns 0UL if disabled. >=20 Yeah, that=E2=80=99s also what I proposed in a sub-thread here. The last option would be going the full mile and not printing nr_free_cma. = Code might get a bit uglier though, but we could also remove that stats cou= nter ;) I don=E2=80=98t particularly care, while printing =E2=80=9E0=E2=80=9C might= be easier, removing nr_free_cma might be cleaner. But then, maybe there are tools that expect that value to be around on any = kernel? Thoughts? Thanks