[akpm-mm:mm-new 31/59] mm/mm_init.c:1512:30: error: 'PAGE_BLOCK_ORDER' undeclared; did you mean 'PAGE_BLOCK_ORDER_CEIL'?

[akpm-mm:mm-new 31/59] mm/mm_init.c:1512:30: error: 'PAGE_BLOCK_ORDER' undeclared; did you mean 'PAGE_BLOCK_ORDER_CEIL'?

[kernel test robot]

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/akpm/mm.git mm-new
head:   80bb0b2983e95be26d929303d589276875c8900a
commit: 2bb7d2079ada079bd9f25c92e6a4618ee1ce22db [31/59] mm: rename CONFIG_PAGE_BLOCK_ORDER to CONFIG_PAGE_BLOCK_ORDER_CEIL.
config: powerpc64-randconfig-002-20250604 (https://download.01.org/0day-ci/archive/20250604/202506042058.XgvABCE0-lkp@intel.com/config)
compiler: powerpc64-linux-gcc (GCC) 11.5.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20250604/202506042058.XgvABCE0-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202506042058.XgvABCE0-lkp@intel.com/

All errors (new ones prefixed by >>):

   mm/mm_init.c: In function 'set_pageblock_order':
>> mm/mm_init.c:1512:30: error: 'PAGE_BLOCK_ORDER' undeclared (first use in this function); did you mean 'PAGE_BLOCK_ORDER_CEIL'?
    1512 |         unsigned int order = PAGE_BLOCK_ORDER;
         |                              ^~~~~~~~~~~~~~~~
         |                              PAGE_BLOCK_ORDER_CEIL
   mm/mm_init.c:1512:30: note: each undeclared identifier is reported only once for each function it appears in


vim +1512 mm/mm_init.c

9420f89db2dd61 Mike Rapoport (IBM  2023-03-21  1508) 
9420f89db2dd61 Mike Rapoport (IBM  2023-03-21  1509) /* Initialise the number of pages represented by NR_PAGEBLOCK_BITS */
9420f89db2dd61 Mike Rapoport (IBM  2023-03-21  1510) void __init set_pageblock_order(void)
9420f89db2dd61 Mike Rapoport (IBM  2023-03-21  1511) {
e13e7922d03439 Juan Yescas         2025-05-21 @1512  	unsigned int order = PAGE_BLOCK_ORDER;
9420f89db2dd61 Mike Rapoport (IBM  2023-03-21  1513) 
9420f89db2dd61 Mike Rapoport (IBM  2023-03-21  1514) 	/* Check that pageblock_nr_pages has not already been setup */
9420f89db2dd61 Mike Rapoport (IBM  2023-03-21  1515) 	if (pageblock_order)
9420f89db2dd61 Mike Rapoport (IBM  2023-03-21  1516) 		return;
9420f89db2dd61 Mike Rapoport (IBM  2023-03-21  1517) 
9420f89db2dd61 Mike Rapoport (IBM  2023-03-21  1518) 	/* Don't let pageblocks exceed the maximum allocation granularity. */
9420f89db2dd61 Mike Rapoport (IBM  2023-03-21  1519) 	if (HPAGE_SHIFT > PAGE_SHIFT && HUGETLB_PAGE_ORDER < order)
9420f89db2dd61 Mike Rapoport (IBM  2023-03-21  1520) 		order = HUGETLB_PAGE_ORDER;
9420f89db2dd61 Mike Rapoport (IBM  2023-03-21  1521) 
9420f89db2dd61 Mike Rapoport (IBM  2023-03-21  1522) 	/*
9420f89db2dd61 Mike Rapoport (IBM  2023-03-21  1523) 	 * Assume the largest contiguous order of interest is a huge page.
e99fb98d478a04 Kefeng Wang         2023-12-22  1524  	 * This value may be variable depending on boot parameters on powerpc.
9420f89db2dd61 Mike Rapoport (IBM  2023-03-21  1525) 	 */
9420f89db2dd61 Mike Rapoport (IBM  2023-03-21  1526) 	pageblock_order = order;
9420f89db2dd61 Mike Rapoport (IBM  2023-03-21  1527) }
9420f89db2dd61 Mike Rapoport (IBM  2023-03-21  1528) #else /* CONFIG_HUGETLB_PAGE_SIZE_VARIABLE */
9420f89db2dd61 Mike Rapoport (IBM  2023-03-21  1529) 

:::::: The code at line 1512 was first introduced by commit
:::::: e13e7922d03439e374c263049af5f740ceae6346 mm: add CONFIG_PAGE_BLOCK_ORDER to select page block order

:::::: TO: Juan Yescas <jyescas@google.com>
:::::: CC: Andrew Morton <akpm@linux-foundation.org>

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki

Re: [akpm-mm:mm-new 31/59] mm/mm_init.c:1512:30: error: 'PAGE_BLOCK_ORDER' undeclared; did you mean 'PAGE_BLOCK_ORDER_CEIL'?

[Zi Yan]

On 4 Jun 2025, at 9:06, kernel test robot wrote:

> tree:   https://git.kernel.org/pub/scm/linux/kernel/git/akpm/mm.git mm-new
> head:   80bb0b2983e95be26d929303d589276875c8900a
> commit: 2bb7d2079ada079bd9f25c92e6a4618ee1ce22db [31/59] mm: rename CONFIG_PAGE_BLOCK_ORDER to CONFIG_PAGE_BLOCK_ORDER_CEIL.
> config: powerpc64-randconfig-002-20250604 (https://download.01.org/0day-ci/archive/20250604/202506042058.XgvABCE0-lkp@intel.com/config)
> compiler: powerpc64-linux-gcc (GCC) 11.5.0
> reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20250604/202506042058.XgvABCE0-lkp@intel.com/reproduce)
>
> If you fix the issue in a separate patch/commit (i.e. not just a new version of
> the same patch/commit), kindly add following tags
> | Reported-by: kernel test robot <lkp@intel.com>
> | Closes: https://lore.kernel.org/oe-kbuild-all/202506042058.XgvABCE0-lkp@intel.com/
>
> All errors (new ones prefixed by >>):
>
>    mm/mm_init.c: In function 'set_pageblock_order':
>>> mm/mm_init.c:1512:30: error: 'PAGE_BLOCK_ORDER' undeclared (first use in this function); did you mean 'PAGE_BLOCK_ORDER_CEIL'?
>     1512 |         unsigned int order = PAGE_BLOCK_ORDER;
>          |                              ^~~~~~~~~~~~~~~~
>          |                              PAGE_BLOCK_ORDER_CEIL
>    mm/mm_init.c:1512:30: note: each undeclared identifier is reported only once for each function it appears in
>
>
> vim +1512 mm/mm_init.c
>
Thanks. This patch should fix it.

From 616cc58d747d4b1c03e8db613b7f05c5005134d4 Mon Sep 17 00:00:00 2001
From: Zi Yan <ziy@nvidia.com>
Date: Wed, 4 Jun 2025 09:27:03 -0400
Subject: [PATCH] fixup: rename the missed PAGE_BLOCK_ORDER to
 PAGE_BLOCK_ORDER_CEIL.

Signed-off-by: Zi Yan <ziy@nvidia.com>
---
 mm/mm_init.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/mm/mm_init.c b/mm/mm_init.c
index f2944748f526..38a1abd49e57 100644
--- a/mm/mm_init.c
+++ b/mm/mm_init.c
@@ -1509,7 +1509,7 @@ static inline void setup_usemap(struct zone *zone) {}
 /* Initialise the number of pages represented by NR_PAGEBLOCK_BITS */
 void __init set_pageblock_order(void)
 {
-	unsigned int order = PAGE_BLOCK_ORDER;
+	unsigned int order = PAGE_BLOCK_ORDER_CEIL;

 	/* Check that pageblock_nr_pages has not already been setup */
 	if (pageblock_order)
-- 
2.47.2



--
Best Regards,
Yan, Zi