From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id F32A6C433FE for ; Mon, 17 Oct 2022 16:24:07 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 8F5826B0074; Mon, 17 Oct 2022 12:24:07 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 8A60F6B0078; Mon, 17 Oct 2022 12:24:07 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 7463C6B007B; Mon, 17 Oct 2022 12:24:07 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 63C166B0074 for ; Mon, 17 Oct 2022 12:24:07 -0400 (EDT) Received: from smtpin10.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 27D0E80702 for ; Mon, 17 Oct 2022 16:24:07 +0000 (UTC) X-FDA: 80030963334.10.7AB8F73 Received: from mx0a-00082601.pphosted.com (mx0a-00082601.pphosted.com [67.231.145.42]) by imf08.hostedemail.com (Postfix) with ESMTP id 8414716003A for ; Mon, 17 Oct 2022 16:24:06 +0000 (UTC) Received: from pps.filterd (m0044012.ppops.net [127.0.0.1]) by mx0a-00082601.pphosted.com (8.17.1.5/8.17.1.5) with ESMTP id 29HBvAxO005110; Mon, 17 Oct 2022 09:23:55 -0700 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=meta.com; h=from : to : cc : subject : date : message-id : references : in-reply-to : content-type : content-id : content-transfer-encoding : mime-version; s=s2048-2021-q4; bh=pH9LVmpgvColEuG+/LwHNZyAwuqCO5VBrhb3d4ucYHc=; b=Jc3Kf1ztpW7H3cW6YQj6XP/50RC2MRIUUWE5+IE6glK5VFXTVbdLCvDojw5L7WfJIcqM op7RhRtF50lEOZsBd3ylMWQuL830gYJDBuAPVlUwhs6mfrIuD/PrvwQAFhJ0ySm2xHcv xrMTnylgxlbSYlz3npBz6HKcmdPAxv0pg6qLWZPYI2a6l53sU2VZgbFSWpD4eAD6Ri8w Q2FbCPDIHajUrDFcJQo4dR1bEhVLwEq7k8DfAhlhmDX2peO80te3HABFC23URkauIFdn VLvOLvwhTlF+N8Ovwclfxd9472dpvbAUb8x6jOi0joJRJUkVSeWsnqE05muiTC/InckD rg== Received: from nam10-bn7-obe.outbound.protection.outlook.com (mail-bn7nam10lp2104.outbound.protection.outlook.com [104.47.70.104]) by mx0a-00082601.pphosted.com (PPS) with ESMTPS id 3k96mctd31-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 17 Oct 2022 09:23:54 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=PPdfbtAfeUgAokndiOEdL/dOp6hzBIQhA6OBEYIAh2PjiiMnkL82fNn0tSK0H0L7GgejaVZiJbIV3g/kPInhXjFphSBZvKBhBJiWa0y2XZmrEakqy5iV1CwXBjTFxDXkD1PvrVLdgZz3DleZVwud/bHElQMuc2qEHNmwGI4d7quH7zLGcJExTDGajAIBv2ptXeIB9xNIziQ+vxWsYvp+p8y9uQ+UWu1lUBr5Zq+o0TC0PyfuN3kmVPYavGdlUBvkjsQxovsgw9rciiqHOLq8bC2X+Utz/TnrRTWPu+hVJWyO3Rh1c8ZI3X5Tb5j8z7YNo1N0OzLH8rZb4fXDE6zcKg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=pH9LVmpgvColEuG+/LwHNZyAwuqCO5VBrhb3d4ucYHc=; b=dN9SdbABBw6BuoSCITmdK6Gs0metb5sPSfdGIVYNcAj6NeDbZd8+9fJj92Uz80eNeDIZsbQCnpdlZOw/xDCK/hH7/Zh9nkxp3TkxUi5FlcyMxrATiKkoPCrjh2yuv2MSm0hRhW79u439eV/FGt9bvPqggXHULwD30QMMONQMyDl/3MfUnd2jkka9U1TSAqO+l+32rSSLlEctOaIRc9IVNTq+FDC8CCTyWk4xcJXMywC/BUNuKHEvBSgOEacmcJzqYZLmGI6BZJc25RVkq3eKSwY5s3yLcstwWOe425csdUOGihIFOAJtFRbu2KGpPIIgLzGtqOemPBwQDF4xkUVaIQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=meta.com; dmarc=pass action=none header.from=meta.com; dkim=pass header.d=meta.com; arc=none Received: from SA1PR15MB5109.namprd15.prod.outlook.com (2603:10b6:806:1dc::10) by PH0PR15MB4557.namprd15.prod.outlook.com (2603:10b6:510:87::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5723.29; Mon, 17 Oct 2022 16:23:52 +0000 Received: from SA1PR15MB5109.namprd15.prod.outlook.com ([fe80::d70d:8cce:bb1:e537]) by SA1PR15MB5109.namprd15.prod.outlook.com ([fe80::d70d:8cce:bb1:e537%7]) with mapi id 15.20.5723.033; Mon, 17 Oct 2022 16:23:52 +0000 From: Song Liu To: Christoph Hellwig CC: Song Liu , Linux-MM , lkml , Andrew Morton , X86 ML , Peter Zijlstra , Kernel Team , "Edgecombe, Rick P" , "Hansen, Dave" , "urezki@gmail.com" Subject: Re: [RFC v2 0/4] vmalloc_exec for modules and BPF programs Thread-Topic: [RFC v2 0/4] vmalloc_exec for modules and BPF programs Thread-Index: AQHY2qb9UHFHCXXpukKxiSq7OlxGX64SPiOAgACWPoA= Date: Mon, 17 Oct 2022 16:23:52 +0000 Message-ID: References: <20221007234315.2877365-1-song@kernel.org> <20221017072607.GA30977@lst.de> In-Reply-To: <20221017072607.GA30977@lst.de> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-mailer: Apple Mail (2.3696.120.41.1.1) x-ms-publictraffictype: Email x-ms-traffictypediagnostic: SA1PR15MB5109:EE_|PH0PR15MB4557:EE_ x-ms-office365-filtering-correlation-id: 0edb50a9-30d9-42cd-b077-08dab05bfaf1 x-fb-source: Internal x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: K10cytw8jTB/jUJk2s3NrsuUunXqExCaNRz7LYNbo389+cMNuifvRl+YAc+qRgwW1g5AcK5Y6tULNuJyUeKs7SIi04AxeIJ3S/lrAFPf7oOTTxDQKev/F8JXsgkutxu3xBKXHsKXfF8uEtfGND26FUSiY3gehTnDrSEPUZzN3V9fgCX5HuPeB1KEVVKQ/wN5R7l9DZ969g2rqjfg/Cq1XlqdBzPKVn/hPxclIaHNg2Ax+pWb4I5CD8GyeZaz4f1uFkesET57TWIAMyhNc1FMXeq287zKv36o34/WXOYzTxyfLdc8aBFjzqLjZbzlbtG7ZNMhjVWj9ExZUEQHLuuOX1Ybi7+eMnZ6tJEBiLjXC+zpyj/EPue6nO0J2jQsbZdznEB+IhDinHkPYMuf8+7ckR2Z7iDt7T5Cs+FRFGLAW6t9O3nWrHOFVhtJFIdlI9V8DVWlJsyON9FSvNvl6dD+jg2TwoBqGU1TedICpuobHYkHE/KXNdSw6CfWUqaI5uht4rYlX1P8/hsKC3SQOo4s1yjbWMWHFmiICWjzbGHbVdgoFf3wI6pjXkwRB7e2X0QmHTOmAHks/vH47vT5zxDThk6F1nCQSptkNRnzi8Tjg0+nZ3wDZGSPEavOQ8hPjwyC2KIvCeOkgTXg6kaRhH/EOFyaiSbNtJ3jGGkt2Zf7i0r81O365BN/qGMZGSD6NQdN49jLQ+pKGies1DJMOyXvu1GKjI98AwFp5B+Y2Dg1Ge/1jDaUdTNnUR6fEA7j6N3x4i4gMHi2CMrTTHPCczy2Sw== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:SA1PR15MB5109.namprd15.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(396003)(346002)(376002)(136003)(366004)(39860400002)(451199015)(2906002)(36756003)(64756008)(4326008)(66446008)(8676002)(7416002)(66556008)(316002)(76116006)(66946007)(66476007)(91956017)(478600001)(41300700001)(54906003)(6916009)(6486002)(33656002)(5660300002)(71200400001)(8936002)(86362001)(6506007)(53546011)(186003)(9686003)(6512007)(38070700005)(38100700002)(122000001);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?XZfmO3YBqZ2+2fFUo1zU59a3J4Ni0iW+y4qOlcTlT2WanJl9AEoaCWx4ZVql?= =?us-ascii?Q?16hTZ84JbPAVgBmNx+rWy4t4mS/Oz9EK+lrT02eFwfcTmnGtT8C1wndXWU29?= =?us-ascii?Q?PH701mGoMky4eFjn+7N1YdXtoRbnmMFtutq8hDG9E74sbaqrzHWMEBHCFLbs?= =?us-ascii?Q?/ii2P7kf7+UIruFLZs5JhgSaHOarkTqZQfOWOE1irqLfbDBVxTtsKECsMrft?= =?us-ascii?Q?1REBQAe2YoxfLD1shhHlTgvcrCv21cjZWGQ/LkRg3kbWSlzKVy4Heiwi7mve?= =?us-ascii?Q?nAvT8pb6tGgcLR2C0ZVot0OyL2rKq1QftxjSq7ciT0NntWGMuW1pkfH9aSX3?= =?us-ascii?Q?xpdlD4AbVx/voUUILdvQS8DN0spj5+9X+cBqe0w2B+zYXaFkdO8zzY3FxDXV?= =?us-ascii?Q?it6Z45frvycRd/34ffMh+2zqZeJSswSFIXw353AdT+Rwa8zzYcl/j4E4bAdN?= =?us-ascii?Q?utEdXWgVtZA4gY2yMhj3iKYbxTQbxgoYby6Kh8EOUaHGSB7hu5/oRbU4ronL?= =?us-ascii?Q?OrTfA815UT9jlhyV131PtnldQNVnQTSyRZvA1mfCHiqD1pQSXJZpoKXJkRLc?= =?us-ascii?Q?P3h7GjjrPSERHUPYEf3LjiMJTV7DmM0UujEhlr6Gh6R6yaPBhSgfBBzsqnFu?= =?us-ascii?Q?CzAuZZkXadKcg+9yCqpUhvSt+SbAby24TweU/6/skmzspmnenETMr/+aL1t4?= =?us-ascii?Q?5dLBaTTsehRapoE90qD5o+UDfJVaJgsxZNtDpbu7DHXdv/8H4JAGvwhxMMSB?= =?us-ascii?Q?iU1Spl92Df6o1+ITPlAgXrMfrC6hQ7r8reE3Ainem06GeRqLlTmJ7dFLEgpc?= =?us-ascii?Q?EiuTJiqqRGaRuNHU61p82SopmufFO7xO8fIIOknwhekAQZcVGLXGkXX4HFzx?= =?us-ascii?Q?imfLg5oMBRaK4HD84kG+vekBahrTq7kz4ppktg6SZ08uXNAt1itSxtKKHvMm?= =?us-ascii?Q?p6eGMHCcbl2YX0yCKU44JM4doPlr80zl9Dt9ehzfaA+gcZiKSjG++3YyYtAM?= =?us-ascii?Q?A6nTdvUgAbXPVH5IyjfmsM49j+R9m3vq7q7IgNBIS4yVZUuWXqLGXKc5dtGj?= =?us-ascii?Q?9UVf/VNC7i9ONTHWt8Io/UhnkUFBmVfiZm0EwpNT/XbpZSEJWnzuBUowhxuU?= =?us-ascii?Q?V2bn5gpAf+tV9jCZoIjkNuhlFoOw89GO27z7HQ6P5C+UBr9xVWMSnSrNNbUO?= =?us-ascii?Q?B0h6nxUSHez956m4SjfhTi7TIg8l/FzfPLePWc+DEpfW+l+WWjkCJpnV2w6q?= =?us-ascii?Q?H0qWH+nBJnuYYt+ExAajrHQOp7FBIdPWoP6zXKYZa2Jg1eiy+Hf3g15bTEN3?= =?us-ascii?Q?WIOwdHYrPz8o1/MXL8zQBo41Y6HvbjM9NqMk0NS3KYjBbWode4gSsZhP1vbj?= =?us-ascii?Q?K3nfxe4LL7IruNgLU2zxPN4qI+1/vyZ+TX1EMC4WoNSQon5v+2cCb5jthn1f?= =?us-ascii?Q?h6iyWq/1Nh7+M11psxzVMQ5+Z7CdI3Z68CZOfVb+H24envHMrPnBrJMJwH+u?= =?us-ascii?Q?mJ2OYBamr8p6z/GD4JCS3FSiyr0PHDG9j3W2PBAdWcUcmnboiQpmKeeIMIKn?= =?us-ascii?Q?WMlHdYvAEqvt2lr6WK3ToPZlxRqLWIK2FHoktFq15EouDAgudJHEDAm1pHKR?= =?us-ascii?Q?IH2C+S3J5w7jQW3Vi0v5Rloda02O7s31zhww6XKw78Nz?= Content-Type: text/plain; charset="us-ascii" Content-ID: <7EA86F4E8C70DF4ABC9F1BE1BA590A7B@namprd15.prod.outlook.com> Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: meta.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: SA1PR15MB5109.namprd15.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 0edb50a9-30d9-42cd-b077-08dab05bfaf1 X-MS-Exchange-CrossTenant-originalarrivaltime: 17 Oct 2022 16:23:52.4846 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 8ae927fe-1255-47a7-a2af-5f3a069daaa2 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: 9O1eDnoXXKGXu+SasGluIPDQqOKaHBR7F0kzJ3txcf8Wb0rNZR6CNSRQWR+ofcgp10Q+9aHuAgwNcOmWrlVygw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR15MB4557 X-Proofpoint-ORIG-GUID: 92yCLevhn1Uv5LAh6RXNdCNBFOeA4b1q X-Proofpoint-GUID: 92yCLevhn1Uv5LAh6RXNdCNBFOeA4b1q X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.205,Aquarius:18.0.895,Hydra:6.0.545,FMLib:17.11.122.1 definitions=2022-10-17_13,2022-10-17_02,2022-06-22_01 ARC-Seal: i=2; s=arc-20220608; d=hostedemail.com; t=1666023846; a=rsa-sha256; cv=pass; b=IHpl9kFE8aCSA4C8H6i5Pb+W2HH8mnpwPG6wjlY35ctjEfzRnHlH7dZNvP5Gohgb20+ydb VpK7TyAaUoVJWn7UFLoV/Vvp3lzSVQXbYlnJgsOMgQ4KZ97uFMM4++kmn8TkXgMpX/fB5B TkiY8+kcxZ8Lw+C7lVXrTe+Vl/Zfd5k= ARC-Authentication-Results: i=2; imf08.hostedemail.com; dkim=pass header.d=meta.com header.s=s2048-2021-q4 header.b=Jc3Kf1zt; dmarc=pass (policy=reject) header.from=meta.com; arc=pass ("microsoft.com:s=arcselector9901:i=1"); spf=pass (imf08.hostedemail.com: domain of "prvs=1289f208c3=songliubraving@meta.com" designates 67.231.145.42 as permitted sender) smtp.mailfrom="prvs=1289f208c3=songliubraving@meta.com" ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1666023846; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=pH9LVmpgvColEuG+/LwHNZyAwuqCO5VBrhb3d4ucYHc=; b=D8Y9t6hD61Jrdfdyq3FvLMHNFOb6bn4n7CR38lRr9wyET/7ONwQNmbYvJ50MHRiiZwOgrj 5NaxUc/oxZxCNZaljYFUVabBAby4y3+M8qu/0i4IpRfDZV/EQ6My0/rymuw9DzOG8FQjLg 4ALwHJf6NlSFIHTsZ0ro1MtBnbFgEgw= X-Rspamd-Server: rspam05 X-Rspam-User: X-Rspamd-Queue-Id: 8414716003A Authentication-Results: imf08.hostedemail.com; dkim=pass header.d=meta.com header.s=s2048-2021-q4 header.b=Jc3Kf1zt; dmarc=pass (policy=reject) header.from=meta.com; arc=pass ("microsoft.com:s=arcselector9901:i=1"); spf=pass (imf08.hostedemail.com: domain of "prvs=1289f208c3=songliubraving@meta.com" designates 67.231.145.42 as permitted sender) smtp.mailfrom="prvs=1289f208c3=songliubraving@meta.com" X-Stat-Signature: aqbikzutyjhk5n7srm13eutegnzi44rj X-HE-Tag: 1666023846-92730 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Hi Chritoph,=20 > On Oct 17, 2022, at 12:26 AM, Christoph Hellwig wrote: >=20 > On Fri, Oct 07, 2022 at 04:43:11PM -0700, Song Liu wrote: >> Changes RFC v1 =3D> RFC v2: >> 1. Major rewrite of the logic of vmalloc_exec and vfree_exec. They now >> work fine with BPF programs (patch 1, 2, 4). But module side (patch 3) >> still need some work. >=20 > Can you please move the changelog under the description of WTF the > series actually does like the normal kernel process? Explaining the > changes from a previous version before you even describe what the series > does is completely incoherent. Will fix in the next version.=20 >=20 >> This set is a prototype that allows dynamic kernel text (modules, bpf >> programs, various trampolines, etc.) to share huge pages. The idea is >> similar to Peter's suggestion in [1]. Please refer to each patch for >> more detais. >=20 > Well, nothing explains what the method is to avoid having memory > that is mapped writable and executable at the same time, which really > could use some explanation here (and in the main patch as well). Thanks for the feedback. I will add this.=20 Does the code look good to you? I personally think patch 1, 2, 4 could ship with a little more work.=20 Thanks, Song