From: Qian Cai <cai@lca.pw>
To: Dan Williams <dan.j.williams@intel.com>
Cc: Linux MM <linux-mm@kvack.org>,
linux-nvdimm <linux-nvdimm@lists.01.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Andrey Ryabinin <aryabinin@virtuozzo.com>,
kasan-dev@googlegroups.com
Subject: Re: devm_memremap_pages() triggers a kasan_add_zero_shadow() warning
Date: Sat, 17 Aug 2019 07:12:43 -0400 [thread overview]
Message-ID: <E7A04694-504D-4FB3-9864-03C2CBA3898E@lca.pw> (raw)
In-Reply-To: <CAPcyv4h9Y7wSdF+jnNzLDRobnjzLfkGLpJsML2XYLUZZZUPsQA@mail.gmail.com>
> On Aug 16, 2019, at 11:57 PM, Dan Williams <dan.j.williams@intel.com> wrote:
>
> On Fri, Aug 16, 2019 at 8:34 PM Qian Cai <cai@lca.pw> wrote:
>>
>>
>>
>>> On Aug 16, 2019, at 5:48 PM, Dan Williams <dan.j.williams@intel.com> wrote:
>>>
>>> On Fri, Aug 16, 2019 at 2:36 PM Qian Cai <cai@lca.pw> wrote:
>>>>
>>>> Every so often recently, booting Intel CPU server on linux-next triggers this
>>>> warning. Trying to figure out if the commit 7cc7867fb061
>>>> ("mm/devm_memremap_pages: enable sub-section remap") is the culprit here.
>>>>
>>>> # ./scripts/faddr2line vmlinux devm_memremap_pages+0x894/0xc70
>>>> devm_memremap_pages+0x894/0xc70:
>>>> devm_memremap_pages at mm/memremap.c:307
>>>
>>> Previously the forced section alignment in devm_memremap_pages() would
>>> cause the implementation to never violate the KASAN_SHADOW_SCALE_SIZE
>>> (12K on x86) constraint.
>>>
>>> Can you provide a dump of /proc/iomem? I'm curious what resource is
>>> triggering such a small alignment granularity.
>>
>> This is with memmap=4G!4G ,
>>
>> # cat /proc/iomem
> [..]
>> 100000000-155dfffff : Persistent Memory (legacy)
>> 100000000-155dfffff : namespace0.0
>> 155e00000-15982bfff : System RAM
>> 155e00000-156a00fa0 : Kernel code
>> 156a00fa1-15765d67f : Kernel data
>> 157837000-1597fffff : Kernel bss
>> 15982c000-1ffffffff : Persistent Memory (legacy)
>> 200000000-87fffffff : System RAM
>
> Ok, looks like 4G is bad choice to land the pmem emulation on this
> system because it collides with where the kernel is deployed and gets
> broken into tiny pieces that violate kasan's. This is a known problem
> with memmap=. You need to pick an memory range that does not collide
> with anything else. See:
>
> https://nvdimm.wiki.kernel.org/how_to_choose_the_correct_memmap_kernel_parameter_for_pmem_on_your_system
>
> ...for more info.
Well, it seems I did exactly follow the information in that link,
[ 0.000000] BIOS-provided physical RAM map:
[ 0.000000] BIOS-e820: [mem 0x0000000000000000-0x0000000000093fff] usable
[ 0.000000] BIOS-e820: [mem 0x0000000000094000-0x000000000009ffff] reserved
[ 0.000000] BIOS-e820: [mem 0x00000000000e0000-0x00000000000fffff] reserved
[ 0.000000] BIOS-e820: [mem 0x0000000000100000-0x000000005a7a0fff] usable
[ 0.000000] BIOS-e820: [mem 0x000000005a7a1000-0x000000005b5e0fff] reserved
[ 0.000000] BIOS-e820: [mem 0x000000005b5e1000-0x00000000790fefff] usable
[ 0.000000] BIOS-e820: [mem 0x00000000790ff000-0x00000000791fefff] reserved
[ 0.000000] BIOS-e820: [mem 0x00000000791ff000-0x000000007b5fefff] ACPI NVS
[ 0.000000] BIOS-e820: [mem 0x000000007b5ff000-0x000000007b7fefff] ACPI data
[ 0.000000] BIOS-e820: [mem 0x000000007b7ff000-0x000000007b7fffff] usable
[ 0.000000] BIOS-e820: [mem 0x000000007b800000-0x000000008fffffff] reserved
[ 0.000000] BIOS-e820: [mem 0x00000000ff800000-0x00000000ffffffff] reserved
[ 0.000000] BIOS-e820: [mem 0x0000000100000000-0x000000087fffffff] usable
Where 4G is good. Then,
[ 0.000000] user-defined physical RAM map:
[ 0.000000] user: [mem 0x0000000000000000-0x0000000000093fff] usable
[ 0.000000] user: [mem 0x0000000000094000-0x000000000009ffff] reserved
[ 0.000000] user: [mem 0x00000000000e0000-0x00000000000fffff] reserved
[ 0.000000] user: [mem 0x0000000000100000-0x000000005a7a0fff] usable
[ 0.000000] user: [mem 0x000000005a7a1000-0x000000005b5e0fff] reserved
[ 0.000000] user: [mem 0x000000005b5e1000-0x00000000790fefff] usable
[ 0.000000] user: [mem 0x00000000790ff000-0x00000000791fefff] reserved
[ 0.000000] user: [mem 0x00000000791ff000-0x000000007b5fefff] ACPI NVS
[ 0.000000] user: [mem 0x000000007b5ff000-0x000000007b7fefff] ACPI data
[ 0.000000] user: [mem 0x000000007b7ff000-0x000000007b7fffff] usable
[ 0.000000] user: [mem 0x000000007b800000-0x000000008fffffff] reserved
[ 0.000000] user: [mem 0x00000000ff800000-0x00000000ffffffff] reserved
[ 0.000000] user: [mem 0x0000000100000000-0x00000001ffffffff] persistent (type 12)
[ 0.000000] user: [mem 0x0000000200000000-0x000000087fffffff] usable
The doc did mention that “There seems to be an issue with CONFIG_KSAN at the moment however.”
without more detail though.
next prev parent reply other threads:[~2019-08-17 11:12 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1565991345.8572.28.camel@lca.pw>
2019-08-16 21:48 ` Dan Williams
2019-08-17 3:34 ` Qian Cai
2019-08-17 3:57 ` Dan Williams
2019-08-17 11:12 ` Qian Cai [this message]
2019-08-17 16:59 ` Dan Williams
2019-08-18 3:25 ` Qian Cai
2019-08-21 21:12 ` Qian Cai
2019-08-22 1:31 ` Baoquan He
2019-08-22 1:52 ` Qian Cai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=E7A04694-504D-4FB3-9864-03C2CBA3898E@lca.pw \
--to=cai@lca.pw \
--cc=aryabinin@virtuozzo.com \
--cc=dan.j.williams@intel.com \
--cc=kasan-dev@googlegroups.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=linux-nvdimm@lists.01.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox