From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id D49B2C3DA6E for ; Fri, 5 Jan 2024 11:31:08 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 211AF6B02EA; Fri, 5 Jan 2024 06:31:08 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 1E9E16B02EF; Fri, 5 Jan 2024 06:31:08 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 062786B02F0; Fri, 5 Jan 2024 06:31:08 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id E7E9C6B02EA for ; Fri, 5 Jan 2024 06:31:07 -0500 (EST) Received: from smtpin25.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id BB95C40A81 for ; Fri, 5 Jan 2024 11:31:07 +0000 (UTC) X-FDA: 81645040974.25.F79F7FC Received: from mx0b-00069f02.pphosted.com (mx0b-00069f02.pphosted.com [205.220.177.32]) by imf24.hostedemail.com (Postfix) with ESMTP id F18E6180016 for ; Fri, 5 Jan 2024 11:31:03 +0000 (UTC) Authentication-Results: imf24.hostedemail.com; dkim=pass header.d=oracle.com header.s=corp-2023-11-20 header.b=l1fGXX2D; dkim=pass header.d=oracle.onmicrosoft.com header.s=selector2-oracle-onmicrosoft-com header.b=VQKyycSP; dmarc=pass (policy=none) header.from=oracle.com; arc=pass ("microsoft.com:s=arcselector9901:i=1"); spf=pass (imf24.hostedemail.com: domain of william.kucharski@oracle.com designates 205.220.177.32 as permitted sender) smtp.mailfrom=william.kucharski@oracle.com ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1704454264; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=J4bDkzAzPWkuZ2Z0vFn8o5TU32WfjPhDtKU7KIOf8ZY=; b=OhCTQNhPqHFwnubakO7DeqrQHVdIfAGc3EjATZFBmA25XigqXs/tnMBKqn2Wdo6Bc10m08 4wbiOYoDT7yJ0VjWQ6F76xazsGcyu6U5cunwNQZSvSx86SXqVasW36n5cBd+Gcx5Afiz0e YDUolCTu9TbM8prFjr/VKfr7o8MIsKk= ARC-Authentication-Results: i=2; imf24.hostedemail.com; dkim=pass header.d=oracle.com header.s=corp-2023-11-20 header.b=l1fGXX2D; dkim=pass header.d=oracle.onmicrosoft.com header.s=selector2-oracle-onmicrosoft-com header.b=VQKyycSP; dmarc=pass (policy=none) header.from=oracle.com; arc=pass ("microsoft.com:s=arcselector9901:i=1"); spf=pass (imf24.hostedemail.com: domain of william.kucharski@oracle.com designates 205.220.177.32 as permitted sender) smtp.mailfrom=william.kucharski@oracle.com ARC-Seal: i=2; s=arc-20220608; d=hostedemail.com; t=1704454264; a=rsa-sha256; cv=pass; b=s/LvZIa9hw2uVLYt0nSUSykKoW96hkvW24oI1ppy6sMuFjDiqyG7JUV+MVEWV4wv41na0+ S+dCv9ImtDG9OxlnyibvEbnoUJzSSwXpttPDhZ7FsgYBjF1fjJeXljR+vuR5VbqORAqo84 Vz53Qer0VsO2CnbarVFWWmFnAI24vNg= Received: from pps.filterd (m0246632.ppops.net [127.0.0.1]) by mx0b-00069f02.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 405BTfML011206; Fri, 5 Jan 2024 11:30:42 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=from : to : cc : subject : date : message-id : references : in-reply-to : content-type : content-id : content-transfer-encoding : mime-version; s=corp-2023-11-20; bh=J4bDkzAzPWkuZ2Z0vFn8o5TU32WfjPhDtKU7KIOf8ZY=; b=l1fGXX2DjkqRq3Nz/EtefXy0NOaC4NeLbxdnfyqSWQ04/ZvheKH8WyJ1HKcrBVbLXQOa Ai37gunhkXvwEkDsXZNbmoisQi04gQ/jcfxje6dPeHHu1GyBf/SCYB2DdQbkCj+O/Pp6 fLzUSVjBiI9Zh30Xmq6Z9SQ0vSwLBWsHJGlJi6iTLIFwfyJWuBKEYg26J+DZPs2nxEFH 3Fw8ROgI3HGnmTOAgOuDv2D4ap3CCBKo/cruC1yUjUS5+O+7A+p1ZdZcfHDilzr4Xyrn 2EyiGynnSwSiv01cN5cimRAzofZvXJj1HMSd12arg9YX/MC7aomhS+jjY0XCcAOfN85v Iw== Received: from phxpaimrmta01.imrmtpd1.prodappphxaev1.oraclevcn.com (phxpaimrmta01.appoci.oracle.com [138.1.114.2]) by mx0b-00069f02.pphosted.com (PPS) with ESMTPS id 3vegxfg03y-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Fri, 05 Jan 2024 11:30:42 +0000 Received: from pps.filterd (phxpaimrmta01.imrmtpd1.prodappphxaev1.oraclevcn.com [127.0.0.1]) by phxpaimrmta01.imrmtpd1.prodappphxaev1.oraclevcn.com (8.17.1.19/8.17.1.19) with ESMTP id 405AdAgi023265; Fri, 5 Jan 2024 11:30:41 GMT Received: from nam11-dm6-obe.outbound.protection.outlook.com (mail-dm6nam11lp2169.outbound.protection.outlook.com [104.47.57.169]) by phxpaimrmta01.imrmtpd1.prodappphxaev1.oraclevcn.com (PPS) with ESMTPS id 3ve1n7634t-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Fri, 05 Jan 2024 11:30:40 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=T+HmwO1ZaaI14KxSf7xIQfk7LrojA9ahsak/96OOLPLhyCAveiuLl6hK6hgVhFkMxtTc/Bn1XdBNjYtYy/7l0UUwE0eeg8khsTpI3hl3tN/DWFWuviEo1eU7YDqHK1lIWz/UmRJFBWUUs/acgOt4t8jxGlO4lbwhEQiJblCOCGjRf0BruM52Gp6AV3JIK6BiTEX4uYiX0HgUcaC2cU3MvEkZkK/NmcNSImEjv6pVlU2jhLuDZUSljsfxgAJGou96JJ4AFjxYHOWEm6op306GQEJ68owbbmqeUXl2XTff0jtCNA1TapkFq7Ckgx1nCqAGMAj3oIQY14ODqqg9Gv0lEg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=J4bDkzAzPWkuZ2Z0vFn8o5TU32WfjPhDtKU7KIOf8ZY=; b=OY0+LWGxD2NuVbQcGisfLgJdaSOV/6VYEIynKa6M14PTRRuG3mAyjSN5fFRvFraAWuieOBi1E3FNc2ouON/6B7/Gi++34QUpIA6v5JGgrYzRvsSng3ZjjfTm7hS7VPePVTU9dNZic1AFLNC7AI369Ja88gH5KXFJhQfu00yw1mvLlc2CCiSrrKJieW7flGzFNwFhfAXDeyYrLVKLE3YcZ0DGr3Al5Lw7fVOERimxwh4salYBS7gPqhy9AvQFaXzE1j9Sf0LBhhNysGNiQBPrBxhn7yJ2nI8j6wK2ZytBKxXFu9keRpV/02/zDLFJFFsWWar6Q85MZKvchnOYJkKizw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oracle.com; dmarc=pass action=none header.from=oracle.com; dkim=pass header.d=oracle.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.onmicrosoft.com; s=selector2-oracle-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=J4bDkzAzPWkuZ2Z0vFn8o5TU32WfjPhDtKU7KIOf8ZY=; b=VQKyycSPykqB+PMHr0km++TWOzkanrs9d85zwGOvPMMxBoiofCBCGglR4LSe7I2BMGS9Qi9/hQCE4VlEm1TQYnEU6O68k5iiflaJrWRarwnlbCCYXKLjaBpcK78tuQ8tsWLL8VkSDEKIiA4G2meumuxLPit5/8H+uLuBvS+KjJk= Received: from SN4PR10MB5559.namprd10.prod.outlook.com (2603:10b6:806:202::16) by CH2PR10MB4136.namprd10.prod.outlook.com (2603:10b6:610:7f::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7159.16; Fri, 5 Jan 2024 11:30:38 +0000 Received: from SN4PR10MB5559.namprd10.prod.outlook.com ([fe80::e442:1469:266f:609c]) by SN4PR10MB5559.namprd10.prod.outlook.com ([fe80::e442:1469:266f:609c%7]) with mapi id 15.20.7159.015; Fri, 5 Jan 2024 11:30:38 +0000 From: William Kucharski To: Ryan Roberts CC: John Hubbard , Barry Song <21cnbao@gmail.com>, Andrew Morton , Zenghui Yu , Matthew Wilcox , David Hildenbrand , Kefeng Wang , Zi Yan , Alistair Popple , "linux-mm@kvack.org" Subject: Re: [RFC PATCH v1] tools/mm: Add thpmaps script to dump THP usage info Thread-Topic: [RFC PATCH v1] tools/mm: Add thpmaps script to dump THP usage info Thread-Index: AQHaPZHRZOEbm+6RskiJLYiSFdrYzbDHpZCAgAAXLQCAAATNgIAADkSAgAAFaACAAAmJgIAAAyiAgAJjOoCAAKPggIAAMQSA Date: Fri, 5 Jan 2024 11:30:37 +0000 Message-ID: References: <20240102153828.1002295-1-ryan.roberts@arm.com> <29007216-8A9B-4CA2-8A87-EB33E338CBA7@oracle.com> <84b43094-9b16-40a5-94e8-6dd4e859a01f@arm.com> <0d06b0fd-01f3-4a93-811d-f39c0b326b23@arm.com> <26dc2b09-b298-4fb7-81e1-4bfba6afaff4@nvidia.com> <146a88e6-a647-4b8f-8472-af3ff7ae6b93@arm.com> In-Reply-To: <146a88e6-a647-4b8f-8472-af3ff7ae6b93@arm.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-mailer: Apple Mail (2.3774.400.11) x-ms-publictraffictype: Email x-ms-traffictypediagnostic: SN4PR10MB5559:EE_|CH2PR10MB4136:EE_ x-ms-office365-filtering-correlation-id: 782e5a51-6105-4f15-d576-08dc0de1bda2 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: s4DeCxjvE5Z+ItMx9TYfhX0Z4kmYZ/ZBLnIX7/pLNoRCaf/2sbFk42AMfqkRxjgfQRkRmXUhrZDF6tpvTju9NmDFtfPEu/tk2sQUb5Y0iffUUO79xEQXGEWOU2mx1tug2UGiq5uRXeSMQjkou/SnZ2doU4RPSNN4nxO3qqktVLHETtWwFCTunDAWrl7phIYwHIO3fEQBQ0JBe4Uzb47yEszagSEnggEtCS2zNrL8ABq7f7Pdx+71zE2IwLp5Xe36DEA9kTA4Qmb6ZfseeEAJMFZbOe/ayhqbl4CfUfZINjBhqXxT7SjfzexZRaf3X2es2dXnt0/scPh7rI29vDIo5ZIGu6SXOmtBFjxmXDG7jIUuSVpEu70P31ofhCFbW03tkCPK5u5laf3bmY+nz5M670kKFENlZaxEBcyR4Te8T4FMVIFaWxRWHOuxV2O14tVQ2butbDAUlr0xOCOMBL/CwfPEGeRLHQ7URqEnECZxegNbdLP//ml3A6p0feFZ7o5evOVGpt2iemm3cpu+FbIjWVwRZPgYG0VcsxtWQeu71N8pYu9aUb4Wyv0dWJoxrUyTK2Z2hq0f4Cp7bwnAWhQpU0UZsNf8OGwz/yXwFThTo9J/HIi1qgXap9C4xrB6VZMG8TDskDyGQzum0CVnh9Iz+w== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:SN4PR10MB5559.namprd10.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230031)(39860400002)(396003)(136003)(376002)(346002)(366004)(230922051799003)(1800799012)(451199024)(186009)(64100799003)(66556008)(66476007)(66446008)(64756008)(6916009)(76116006)(66946007)(38100700002)(122000001)(91956017)(6512007)(6506007)(53546011)(71200400001)(86362001)(2616005)(44832011)(5660300002)(7416002)(36756003)(2906002)(478600001)(6486002)(33656002)(83380400001)(54906003)(316002)(8936002)(4326008)(8676002)(38070700009)(41300700001)(45980500001);DIR:OUT;SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?iSrhLEYbYShoHCwsOxlTzGozPmlz4IyDa2RqkvlP6sNlWk2XrkyJVyN5hHk7?= =?us-ascii?Q?XtleIfj6Ji4IpgLnd9eF5lPInYMTtcNfeVpcIO4IkFld+24HcMhaEBRIN+AO?= =?us-ascii?Q?ivBNFydXvhuVW3B8M5ZGOue/lBJ0KUPg7KVG5bSchRzigiKhHkwi/NPn2E82?= =?us-ascii?Q?8RbVTlfUPAvoX1yAMB2L1EbjnD4QoyOKhzyYEJUIpavqgrowjR61ImIwmDEV?= =?us-ascii?Q?7deFGwxJLz2sI6pgajsLqoEpWz0gss3UQ6mbNKHaSoYbD3q8f+OFpfrHRPLo?= =?us-ascii?Q?Z+mLPo93TqtGpnStSmK9G2cFULxw8aqTtN97U7f97dsIjVbVRQthFkUp6zu9?= =?us-ascii?Q?4SMiqbgzdD0L2L85k0McEd+ivRf5Y1014HMxbgbicODG6mthqGAUlB14TvqS?= =?us-ascii?Q?MHzHOds2aRrZaJ2oXgeQyYcBOsasazYBkBXM/AE/VUXOftAsGiF4CqIHMmn2?= =?us-ascii?Q?mixjy0Mha2jqdeCBU11Ywd0Ekrq8y8G3EHMo0ALdASYLJece+cKl3lOlTKwe?= =?us-ascii?Q?q8CE5fURJgKy3wx3RP7jbMIyXyXeLhQa2Hsu3TnZppikt/JFs+VQK4iJnILb?= =?us-ascii?Q?M99O9IHAnrs9zk2xCVc46/uP4xWbgXShg602J+7mb0OTqMT/GVrIi++BH4or?= =?us-ascii?Q?PFpc6ueEEmTlx0vG92vpbXIrP3sxYICbeKToK+E1UfwjgzvwD0I25/Yqw8eQ?= =?us-ascii?Q?7f9tg9qIg/PEAZPXdaWPiaWXuPQ9e4ivs5fl8hj8g0SMi+dpaEa0LOQRVSgn?= =?us-ascii?Q?yHhC/vTgumcsMHiP80/XLnADgg1H5tzN53M4tsLWDKjOcIgqy/gDBp/fXyrE?= =?us-ascii?Q?zPaa9LZKKVXK6GGEb9Z5GnLrv50k9w9tfMr0T3tGpXKXJ6EC9Awqu1UKMc9D?= =?us-ascii?Q?2HIVQZFez+6GB8VJhqYBQNcbiRoFk59r5bxgi+kGDBtz8s6npAFpJLcmquEj?= =?us-ascii?Q?NOwoiQtYVyahLizHscYdyPUkFovNo/UMw6gpl8Qm74x2zPdqWg5Dfiq7j+Ec?= =?us-ascii?Q?cZZCaHRV6RFKwcD78f1WiLZz2amAsPBCtV52/hxJPd8lvlhdG3o0m0DAgC2h?= =?us-ascii?Q?KWTy73IEJWZ/EQERTf9XYSfg4kD6o0Mo6YVkgjVC+qiPrv8Fdw46ivI8dOXE?= =?us-ascii?Q?+ssNqp35RaYu0jA4LbtE31/mvhEEM4IJ9krLNfSjfpt2n9oRWIfJFfJxuC4t?= =?us-ascii?Q?H6c9AU40/OrIQMEmMsK/KbanQzWj0zrU7BzpC1LkAQXk1VRXD9u+sGd1ZzWF?= =?us-ascii?Q?qoFNdRpZsNNxgEprhB6ZqSQl5e3PtYaUF5e+JTladPDP70mZVtHCB+rYC54N?= =?us-ascii?Q?ooqsH1C78rTTGnw60g8h8X0p4O4MfnRFQcYy/Nq9nYayn4EDea5Kq4eFpmJt?= =?us-ascii?Q?rnLjMLMPziZ7VhjRuheHyezm6IOWVJiYIzRdLVrExDt/OcbXjEhRB7Xj2aXu?= =?us-ascii?Q?Jyida/TyiFUm7ZCLd5xKtXlJo/nryLF8GIRXdcIFkvYgWO5Tw71mj79/eKEp?= =?us-ascii?Q?Ath7oG688FGNZApsWXTmLJG+U79q59fLHpx/WZVjhWJwldhD6apsfYZ6MTHS?= =?us-ascii?Q?W1mXfOgAusT8w2jgNkd7uNF3hq/WRkqBxO7sqLWH5cm793A55a/i6rwpXBlK?= =?us-ascii?Q?HgC9wyEpZ9x/6aFCNFPc6oh4QQ1kpXM5wAN6RqgTThqHB9MeymYZI3aCETQ6?= =?us-ascii?Q?/Nkp66Og8LKxfK4Iw37SfdJKgzQ=3D?= Content-Type: text/plain; charset="us-ascii" Content-ID: <0C650E66D8DE4740B2326A7CFAAB3389@namprd10.prod.outlook.com> Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: N3eDAT8vXJcQits3CTvvP+pMz+8tYuJcl4SuF4oUF+RIGSxaa7V3fabKlZPa3IQV+HChLblLvcDmzk0+v+ivJyG1+TOZAxIqemMsD8Z7HH8JhLqkbkUUoW3uwF+scSpxEbjx4jOvScPj+aJYwnl9Qc78k6wLz1DAo5OotkXADmUkCWu8xqubvf3vPMffBJb+vIHP1ka3ImMluD8OMRaAFTKHpMg+VGOQOl4BXBXDAGsGQ2dQQ2K00ldS04nin5pui49lr6E93oqOsihIoQbGB0k//UtN/VaNRYpcqMd2g9j4L2pnOrpMKu2e3WTJM5vLuMV1ftycbk5DrwI6B9TFDFv87DRESJ47Ur/rU1YhxwGWAAdTwyRzlKoWtG++EIjD3JpyqMb8nBnsNiAmKDI8sM3uhcu7i0FUUhoih10W+F0ArK7h0nxnYUjSfMfVS2JO4qNMDer+DG8OdfC5F/b1fTxKO7syp+yM3bsIi1/uYtX1Ie1bmzez3+djD4mOVyD75UVHrAI5lMZcLIiQlHi1b9VqnWBo2HliKrchJVYlgTgMitYImuACl6syzOshgeqcsvegD/bowswyZ+58y/VL1HOZ681wLgohGkjfVlhppT4= X-OriginatorOrg: oracle.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: SN4PR10MB5559.namprd10.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 782e5a51-6105-4f15-d576-08dc0de1bda2 X-MS-Exchange-CrossTenant-originalarrivaltime: 05 Jan 2024 11:30:38.0028 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: RO1ilN9FioVc+P+IvK9yf1TOHulr5hrEBwFqw5aupE8z0biYedTal/1v7wOKC3oGugEG85QzOBkHMgEwU1RFs1VOad3/nuBH0Zp34f1KxGA= X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH2PR10MB4136 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.272,Aquarius:18.0.997,Hydra:6.0.619,FMLib:17.11.176.26 definitions=2024-01-05_05,2024-01-05_01,2023-05-22_02 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 mlxscore=0 phishscore=0 spamscore=0 mlxlogscore=999 malwarescore=0 suspectscore=0 adultscore=0 bulkscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2311290000 definitions=main-2401050098 X-Proofpoint-GUID: 9Va5UpwWQb8oTSaqKZu_WwCYmjauaO31 X-Proofpoint-ORIG-GUID: 9Va5UpwWQb8oTSaqKZu_WwCYmjauaO31 X-Rspamd-Server: rspam09 X-Rspamd-Queue-Id: F18E6180016 X-Stat-Signature: 6bmny1bjdybhtpwqmohwhn9gofe71kuq X-Rspam-User: X-HE-Tag: 1704454263-92311 X-HE-Meta: U2FsdGVkX1/6G02cKeuspyeq5LzglPI00F+26QmkWztKQX3b2fwYGh+IU2YGpOuxmklqAFtPUsXCDU8dldM+JAGkpV7PDlTNkLKTqRcMNkucw3ZIBGphKq91l+370R450CaBJTnFHIPWJnC/irldhjO2XbiB/8G/1p4MkED+Q8JS8+DD96CBMvSRiTYma+q1qkUgP2kMLihrA3W/AZrNusiPcDURr8ghIZE58wPZEuzrmYP7snpO6HTypMDzaoCRfowmcAGbxdJ0+AwXWAN1JWSKly/paZZdRO+wryORP4DtaaWU4i4OJFpFQfaNFK3rRt1s/xedod5SBXG8jBhVyhQpvhZaxv0576TWtBVVEYa7r8zq4tl00uzqz+MRU5b6sQsWb/vBbRbJYOB5LwnZDlYF1ErIrqLv3nus81tKHUVs8hQpbYHnUENn7jWamS6ElmKD7T8B3J6eLO4SsIVkK3cQ/RPIa53K/5rDJqtSImM2dWSb6D88iPToN18X9Mf7Ave7F1i28DpXiLyV0MsJSw39ZrZvOa/+As0IS+Ip2E8JBxFNYD6LlhfxhDweT1OptrzTYZEFOwrcvrZlHLS78i90PyJklhHKraLR0DyvUlmYCMKQy5okASibKsauU8cZnWBOZQ8M47Evjvmxdo2ZUV0Xct8E4SUKwhkDUBotrPtOeU7pUzunVGsCtW0PbFfxIFnSjEc8Ffsexs3kbh/VcZXAq+6hAsV/lFdFG4BaXVrZxm3prLUO1lQ1X5ONiHaNfstn26GP4b+8Njf70DcEsUa7/HzLqpcIM0B8CGsKNKC3+QIcHkAV/XTlUrskOq5FvebLBY/zP9CRXDs8X2ZI+69pPTPIJDVcno6IHF+RBfVE+8nr7FBenPOiabltT+qujx2gg12QJdhjGqqdtqzl8vq13nY36Fh0afX6BBBpmkdXy1+ZMe2wJdFEwQUtvqD0tySo0bNobiXXj4A2TpP cUXBBAPq VZRDzWvDxOGNE8T9he0JcdP8woaMCyDarM2OESxvaClpb2jfin0Fp0o83oDnN8HNWJR7Ziot8Vq/Tvy5zEtzhJIjoaOWmGE4IWfbfoxAPiT9gGsxnHsxukvvAmUTCnpTLnEJX0GS6FiMlv0GzJB7IMrd1yPrayHE637RNCoARHfqSp6+6GYzftnSfKadrugL57KT7Qgmn18ldImDTD20hHQy6Fv//NO2c+uSw0ANjbLMvkjatlPkbd39coOslYlhVPJ0xXKFJC5Io4C7kGsqqEJ7olB7FUhGTi94Af8KWHUzFY2ETM7iD+WJ+s4GvBtNpCDtewreykBPM7V6FAWQfjr2OT4rKGvQ/WVnTMz4x/60TL4AffkUD9dRQkaUsDFQywkPPNvW2pYSyZgT5LPVJbGLs1LIgiJX1mCwyYsItaLhrBc5hsajyGcoUwq46U93J/BLZJd7tys/YDEIwTKjekcN2U6D18e+8oMtxjBOxKkKU/lr6ZWLVKO0050gjCHnjH9PtRN4EMTKXVsWKUMNTif4g7kzhMCtx6nox X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Personally I like either of these: 00000206: 0000aaaadbb20000-0000aaaadbb21000 r-xp 00000000 fe:00 00426969 206: 0000aaaadbb20000-0000aaaadbb21000 r-xp 00000000 fe:00 00426969 With a header that looks something like this; I suspect the formatting will= get mangled in email anyway: PID START END PROT OFF MJ:MN INODE = FILE 00000206: 0000aaaadbb20000-0000aaaadbb21000 r-xp 00000000 fe:00 00426969 -- William Kucharski > On Jan 5, 2024, at 01:35, Ryan Roberts wrote: >=20 > On 04/01/2024 22:48, John Hubbard wrote: >> On 1/3/24 02:20, Ryan Roberts wrote: >>> On 03/01/2024 10:09, William Kucharski wrote: >> ... >>>>> The reason is that it is also possible to invoke the tool with --cgro= up instead >>>>> of --pid. In this case, the tool will iterate over all the pids in th= e >>>>> cgroup so >>>>> (when --summary is not specified) having the pid associated with each= vma is >>>>> useful. >>>>>=20 >>>>> I could change it to conditionally output the pid only when --cgroup = is >>>>> specified? >>>>=20 >>>> You could, or perhaps emit a colon after the pid to delineate it, e.g.= : >>>>=20 >>>>> 000000ce: 0000aaaadbb20000-0000aaaadbb21000 r-xp 00000000 fe:00004269= 69 >>>>> /root/a.out >>>=20 >>> Yeah that sounds like the least worst option. Let's go with that. >>=20 >> I'm trying this out and had the exact same issue with pid. I'd suggest: >>=20 >> a) pid should always be printed in decimal, because that's what ps(1) us= es >> and no one expects to see it in other formats such as hex. >=20 > right aligned with 0 or ' ' as the pad? I guess ' ' if you want it to loo= k like > ps? But given pid is the first column, I think it will look weird right a= ligned. > Perhaps left aligned, followed by colon, followed by pad? Here are the 3 = options: >=20 > 00000206: 0000aaaadbb20000-0000aaaadbb21000 r-xp 00000000 fe:00 00426969 > 206: 0000aaaadbb20000-0000aaaadbb21000 r-xp 00000000 fe:00 00426969 > 206: 0000aaaadbb20000-0000aaaadbb21000 r-xp 00000000 fe:00 00426969 >=20 > My personal preference is the first option; right aligned with 0 pad. >=20 >>=20 >> b) In fact, perhaps a header row would help. There could be a --no-heade= r-row >> option for cases that want to feed this to other scripts, but the def= ault >> would be to include a human-friendly header. >=20 > How about this for a header (with example first data row): >=20 > PID START END PROT OFF MJ:MN INODE F= ILE > 00000206: 0000aaaadbb20000-0000aaaadbb21000 r-xp 00000000 fe:00 00426969 >=20 > Personally I wouldn't bother with a --no-header option; just keep it alwa= ys on. >=20 >>=20 >> c) pid should probably be suppressed if --pid is specified, but that's >> less important than the other points. >=20 > If we have the header then I think its clear what it is and I'd prefer to= keep > the data format consistent between --pid and --cgroup. So prefer to leave= pid in > always. >=20 >>=20 >> In a day or two I'll get a chance to run this on something that allocate= s >> lots of mTHPs, and give a closer look. >=20 > Thanks - it would be great to get some feedback on the usefulness of the = actual > counters! :) >=20 > I'm considering adding an --ignore-folio-boundaries option, which would m= odify > the way the cont counters work, to only look for contiguity and alignment= and > ignore any folio boundaries. At the moment, if you have multiple contiguo= us > folios, they don't count, because the memory doesn't all belong to the sa= me > folio. I think this could be useful in some (limited) circumstances. >=20 >>=20 >>=20 >> thanks,