From: Zi Yan <ziy@nvidia.com>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: Shivank Garg <shivankg@amd.com>,
David Hildenbrand <david@kernel.org>,
Lorenzo Stoakes <lorenzo.stoakes@oracle.com>,
Baolin Wang <baolin.wang@linux.alibaba.com>,
"Liam R . Howlett" <Liam.Howlett@oracle.com>,
Nico Pache <npache@redhat.com>,
Ryan Roberts <ryan.roberts@arm.com>, Dev Jain <dev.jain@arm.com>,
Barry Song <baohua@kernel.org>, Lance Yang <lance.yang@linux.dev>,
linux-mm@kvack.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH V3 0/5] mm/khugepaged: cleanups and scan limit fix
Date: Sun, 18 Jan 2026 19:17:42 -0500 [thread overview]
Message-ID: <E560B4E0-68CD-4773-B35B-30745D56E8B3@nvidia.com> (raw)
In-Reply-To: <20260118123442.f55db3e141388836df0c7785@linux-foundation.org>
On 18 Jan 2026, at 15:34, Andrew Morton wrote:
> On Sun, 18 Jan 2026 19:22:51 +0000 Shivank Garg <shivankg@amd.com> wrote:
>
>> This series contains several cleanups for mm/khugepaged.c to improve code
>> readability and type safety, and one functional fix to ensure
>> khugepaged_scan_mm_slot() correctly accounts for small VMAs towards
>> scan limit.
>>
>
> That's a lot of changes to a well-reviewed 24 day old patchset.
>
>>
>> v3:
>> - Fold mm-khugepaged-count-small-vmas-towards-scan-limit-fix: add comment (Lance)
>> - Remove extern and use two tabs indent (David)
>
> Are you sure? The v2->v3 diff is large. A lot of (unchangelogged)
> alterations from `int' to `enum scan_result'.
V2 has this change[1].
[1] https://lore.kernel.org/all/20251224111351.41042-12-shivankg@amd.com/
>
> It all looks pretty simple/straightforward to me but again, can
> reviewers please check this over fairly soonly, thanks.
I have reviewed it when it was out last year.
--
Best Regards,
Yan, Zi
next prev parent reply other threads:[~2026-01-19 0:17 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-01-18 19:22 Shivank Garg
2026-01-18 19:22 ` [PATCH V3 1/5] mm/khugepaged: remove unnecessary goto 'skip' label Shivank Garg
2026-01-22 7:04 ` Dev Jain
2026-01-22 11:56 ` Nico Pache
2026-01-18 19:22 ` [PATCH V3 2/5] mm/khugepaged: count small VMAs towards scan limit Shivank Garg
2026-01-22 7:32 ` Dev Jain
2026-01-22 8:44 ` Lance Yang
2026-01-22 12:26 ` Garg, Shivank
2026-01-23 10:42 ` Garg, Shivank
2026-01-23 15:37 ` Andrew Morton
2026-01-23 20:07 ` Garg, Shivank
2026-01-18 19:22 ` [PATCH V3 3/5] mm/khugepaged: change collapse_pte_mapped_thp() to return void Shivank Garg
2026-01-22 12:17 ` Nico Pache
2026-01-18 19:22 ` [PATCH V3 4/5] mm/khugepaged: use enum scan_result for result variables and return types Shivank Garg
2026-01-19 10:24 ` David Hildenbrand (Red Hat)
2026-01-22 9:19 ` Dev Jain
2026-01-22 12:14 ` Nico Pache
2026-01-18 19:23 ` [PATCH V3 5/5] mm/khugepaged: make khugepaged_collapse_control static Shivank Garg
2026-01-22 9:28 ` Dev Jain
2026-01-23 7:48 ` Dev Jain
2026-01-23 9:33 ` Garg, Shivank
2026-01-24 1:21 ` Andrew Morton
2026-01-24 3:02 ` Andrew Morton
2026-01-24 9:02 ` Lorenzo Stoakes
2026-01-24 9:01 ` Lorenzo Stoakes
2026-01-24 10:54 ` Dev Jain
2026-01-24 11:40 ` Lorenzo Stoakes
2026-01-24 11:56 ` Dev Jain
2026-01-24 18:37 ` Garg, Shivank
2026-01-18 20:34 ` [PATCH V3 0/5] mm/khugepaged: cleanups and scan limit fix Andrew Morton
2026-01-19 0:17 ` Zi Yan [this message]
2026-01-19 5:50 ` Garg, Shivank
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=E560B4E0-68CD-4773-B35B-30745D56E8B3@nvidia.com \
--to=ziy@nvidia.com \
--cc=Liam.Howlett@oracle.com \
--cc=akpm@linux-foundation.org \
--cc=baohua@kernel.org \
--cc=baolin.wang@linux.alibaba.com \
--cc=david@kernel.org \
--cc=dev.jain@arm.com \
--cc=lance.yang@linux.dev \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=lorenzo.stoakes@oracle.com \
--cc=npache@redhat.com \
--cc=ryan.roberts@arm.com \
--cc=shivankg@amd.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox